Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs

330 views
Skip to first unread message

Paul Drews

unread,
Nov 25, 2013, 5:20:02 PM11/25/13
to
This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
banks as seen on a BayTrail M System-On-Chip platform. This
ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
manage the Low Power Subsystem (LPSS).

Signed-off-by: Paul Drews <paul....@intel.com>
---
drivers/acpi/acpi_lpss.c | 1 +
drivers/pinctrl/pinctrl-baytrail.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 6745fe1..e603905 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -162,6 +162,7 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
{ "80860F14", (unsigned long)&byt_sdio_dev_desc },
{ "80860F41", (unsigned long)&byt_i2c_dev_desc },
{ "INT33B2", },
+ { "INT33FC", },

{ "INT3430", (unsigned long)&lpt_dev_desc },
{ "INT3431", (unsigned long)&lpt_dev_desc },
diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
index 2832576..114f5ef 100644
--- a/drivers/pinctrl/pinctrl-baytrail.c
+++ b/drivers/pinctrl/pinctrl-baytrail.c
@@ -512,6 +512,7 @@ static const struct dev_pm_ops byt_gpio_pm_ops = {

static const struct acpi_device_id byt_gpio_acpi_match[] = {
{ "INT33B2", 0 },
+ { "INT33FC", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, byt_gpio_acpi_match);
--
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Rafael J. Wysocki

unread,
Nov 25, 2013, 5:50:01 PM11/25/13
to
On Monday, November 25, 2013 02:15:55 PM Paul Drews wrote:
> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
> banks as seen on a BayTrail M System-On-Chip platform. This
> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
> manage the Low Power Subsystem (LPSS).
>
> Signed-off-by: Paul Drews <paul....@intel.com>

Am I supposed to take this (in which case I need an ACK from the pinctrl
maintainer)?

Or is it supposed to go through the pinctrl subsystem? In which case feel free
to add

Acked-by: Rafael J. Wysocki <rafael.j...@intel.com> # for the ACPI part

to the patch.

Thanks!
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Matthew Garrett

unread,
Nov 25, 2013, 8:10:01 PM11/25/13
to
On Mon, Nov 25, 2013 at 02:15:55PM -0800, Paul Drews wrote:
> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
> banks as seen on a BayTrail M System-On-Chip platform. This
> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
> manage the Low Power Subsystem (LPSS).

Not that we can do anything about this now, but if they have the same
programming model why isn't there a CID that covers them?

--
Matthew Garrett | mj...@srcf.ucam.org

Rafael J. Wysocki

unread,
Nov 28, 2013, 8:20:01 AM11/28/13
to
On Monday, November 25, 2013 02:15:55 PM Paul Drews wrote:
> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
> banks as seen on a BayTrail M System-On-Chip platform. This
> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
> manage the Low Power Subsystem (LPSS).
>
> Signed-off-by: Paul Drews <paul....@intel.com>

Linus, any objections to this? If not, I'll take it for 3.14.

Thanks,
Rafael
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Linus Walleij

unread,
Nov 29, 2013, 7:20:02 AM11/29/13
to
On Thu, Nov 28, 2013 at 2:29 PM, Rafael J. Wysocki <r...@rjwysocki.net> wrote:
> On Monday, November 25, 2013 02:15:55 PM Paul Drews wrote:
>> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
>> banks as seen on a BayTrail M System-On-Chip platform. This
>> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
>> manage the Low Power Subsystem (LPSS).
>>
>> Signed-off-by: Paul Drews <paul....@intel.com>
>
> Linus, any objections to this? If not, I'll take it for 3.14.

Go ahead,
Acked-by: Linus Walleij <linus....@linaro.org>

Yours,
Linus Walleij

Rafael J. Wysocki

unread,
Nov 29, 2013, 10:20:01 AM11/29/13
to
On Friday, November 29, 2013 01:16:31 PM Linus Walleij wrote:
> On Thu, Nov 28, 2013 at 2:29 PM, Rafael J. Wysocki <r...@rjwysocki.net> wrote:
> > On Monday, November 25, 2013 02:15:55 PM Paul Drews wrote:
> >> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
> >> banks as seen on a BayTrail M System-On-Chip platform. This
> >> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
> >> manage the Low Power Subsystem (LPSS).
> >>
> >> Signed-off-by: Paul Drews <paul....@intel.com>
> >
> > Linus, any objections to this? If not, I'll take it for 3.14.
>
> Go ahead,
> Acked-by: Linus Walleij <linus....@linaro.org>

Thanks!
0 new messages