[PATCH] Avoid implicit constant truncation

[imu...@au1.ibm.com]

From: Ian Munsie <imu...@au.ibm.com>

When building on 64 bit platforms, the compiler throws the following
warning:

drivers/pci/probe.c:197: warning: large integer implicitly truncated to unsigned type

This patch adds an explicit truncation to silence the compiler warning.

Signed-off-by: Ian Munsie <imu...@au.ibm.com>
---
drivers/pci/probe.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 2a94309..c5d9668 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -195,7 +195,7 @@ int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type,
res->flags |= pci_calc_resource_flags(l) | IORESOURCE_SIZEALIGN;
if (type == pci_bar_io) {
l &= PCI_BASE_ADDRESS_IO_MASK;
- mask = PCI_BASE_ADDRESS_IO_MASK & IO_SPACE_LIMIT;
+ mask = (u32)(PCI_BASE_ADDRESS_IO_MASK & IO_SPACE_LIMIT);
} else {
l &= PCI_BASE_ADDRESS_MEM_MASK;
mask = (u32)PCI_BASE_ADDRESS_MEM_MASK;
--
1.6.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

[Randy Dunlap]

On 03/02/10 16:01, imu...@au1.ibm.com wrote:
> From: Ian Munsie <imu...@au.ibm.com>
>
> When building on 64 bit platforms, the compiler throws the following
> warning:
>
> drivers/pci/probe.c:197: warning: large integer implicitly truncated to unsigned type
>
> This patch adds an explicit truncation to silence the compiler warning.

Please see/read/use Documentation/SubmittingPatches. E.g.:

The canonical patch subject line is:

Subject: [PATCH 001/123] subsystem: summary phrase

I.e., the subject: should tell us that this is a PCI: patch.

(or even pci: -- i don't care which)

thanks,
--
~Randy

[Ian Munsie]

Randy Dunlap writes:

> The canonical patch subject line is:
>
> Subject: [PATCH 001/123] subsystem: summary phrase
>
> I.e., the subject: should tell us that this is a PCI: patch.
>
> (or even pci: -- i don't care which)

Appologies and thanks for the pointer - I'm new to this.

Cheers,
-Ian

[Jesse Barnes]

On Tue, 02 Mar 2010 16:06:33 -0800
Randy Dunlap <rdu...@xenotime.net> wrote:

> On 03/02/10 16:01, imu...@au1.ibm.com wrote:
> > From: Ian Munsie <imu...@au.ibm.com>
> >
> > When building on 64 bit platforms, the compiler throws the following
> > warning:
> >
> > drivers/pci/probe.c:197: warning: large integer implicitly
> > truncated to unsigned type
> >
> > This patch adds an explicit truncation to silence the compiler
> > warning.
>
>
> Please see/read/use Documentation/SubmittingPatches. E.g.:
>
> The canonical patch subject line is:
>
> Subject: [PATCH 001/123] subsystem: summary phrase
>
> I.e., the subject: should tell us that this is a PCI: patch.
>
> (or even pci: -- i don't care which)

No need to resubmit though; I usually have to fix up the summary and
changelog a bit when applying anyway.

That said, this patch rings a bell; I think the warning is signalling a
real bug in the ppc code. IIRC Ben was going to look at it awhile
back, but I think it's mostly harmless so it's probably low on his list.

--
Jesse Barnes, Intel Open Source Technology Center