Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH 3.13-rc5] module: Add missing newline in printk call.

2 views
Skip to first unread message

Tetsuo Handa

unread,
Dec 23, 2013, 2:10:02 AM12/23/13
to
>From cc90e27d5cda227e7a0cbeb5de3cc1cbb1595dfa Mon Sep 17 00:00:00 2001
From: Tetsuo Handa <penguin...@I-love.SAKURA.ne.jp>
Date: Mon, 23 Dec 2013 15:52:42 +0900
Subject: [PATCH] module: Add missing newline in printk call.

Add missing \n and also follow commit bddb12b3 "kernel/module.c: use pr_foo()".

Signed-off-by: Tetsuo Handa <penguin...@I-love.SAKURA.ne.jp>
---
kernel/module.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index f5a3b1e..d24fcf2 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -815,10 +815,8 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
return -EFAULT;
name[MODULE_NAME_LEN-1] = '\0';

- if (!(flags & O_NONBLOCK)) {
- printk(KERN_WARNING
- "waiting module removal not supported: please upgrade");
- }
+ if (!(flags & O_NONBLOCK))
+ pr_warn("waiting module removal not supported: please upgrade\n");

if (mutex_lock_interruptible(&module_mutex) != 0)
return -EINTR;
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Tetsuo Handa

unread,
Jan 17, 2014, 7:00:01 AM1/17/14
to
Rusty, would you pick up this patch?

This message was added in 3.13-rc1. Thus, should be fixed in 3.13.

Rusty Russell

unread,
Jan 20, 2014, 7:40:01 PM1/20/14
to
Tetsuo Handa <penguin...@I-love.SAKURA.ne.jp> writes:
> Rusty, would you pick up this patch?
>
> This message was added in 3.13-rc1. Thus, should be fixed in 3.13.

Thanks, applied. It's a bit trivial for a CC:stable though.

Cheers,
Rusty.
0 new messages