Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH v1 0/3] Add support for Broadcom OTP controller

20 views
Skip to first unread message

Jonathan Richardson

unread,
Oct 24, 2016, 3:20:06 PM10/24/16
to
This patch set adds support for Broadcom's OTP controller found on chips such
as Cygnus and Stingray. A node has been added to the Cygnus dts.


Jonathan Richardson (3):
dt-bindings: Document Broadcom OTP controller driver
nvmem: Add the Broadcom OTP controller driver
ARM: dts: Add node for Broadcom OTP controller driver

.../devicetree/bindings/nvmem/brcm,ocotp.txt | 17 ++
arch/arm/boot/dts/bcm-cygnus.dtsi | 7 +
drivers/nvmem/Kconfig | 12 +
drivers/nvmem/Makefile | 2 +
drivers/nvmem/bcm-ocotp.c | 335 +++++++++++++++++++++
5 files changed, 373 insertions(+)
create mode 100644 Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt
create mode 100644 drivers/nvmem/bcm-ocotp.c

--
1.9.1

Jonathan Richardson

unread,
Oct 24, 2016, 3:20:07 PM10/24/16
to
From: Jonathan Richardson <jona...@broadcom.com>

Reviewed-by: Ray Jui <ray...@broadcom.com>
Tested-by: Jonathan Richardson <jonathan....@broadcom.com>
Signed-off-by: Scott Branden <scott....@broadcom.com>
Signed-off-by: Oza Pawandeep <o...@broadcom.com>
Signed-off-by: Jonathan Richardson <jonathan....@broadcom.com>
---
arch/arm/boot/dts/bcm-cygnus.dtsi | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index fabc9f3..a74a430 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -91,6 +91,13 @@
#address-cells = <1>;
#size-cells = <1>;

+ otp: otp@0301c800 {
+ compatible = "brcm,ocotp";
+ reg = <0x0301c800 0x2c>;
+ brcm,ocotp-size = <2048>;
+ status = "disabled";
+ };
+
pcie_phy: phy@0301d0a0 {
compatible = "brcm,cygnus-pcie-phy";
reg = <0x0301d0a0 0x14>;
--
1.9.1

Linus Torvalds

unread,
Oct 24, 2016, 3:40:06 PM10/24/16
to
On Mon, Oct 24, 2016 at 12:12 PM, Jonathan Richardson
<jonathan....@broadcom.com> wrote:
> This patch set adds support for Broadcom's OTP controller found on chips such
> as Cygnus and Stingray. A node has been added to the Cygnus dts.

These patches fail DKIM and will thus be marked as spam for a lot of people.

The usual reason tends to be that you use the wrong smtp server that
doesn't add the right signature. That's happened before with
broadcom.com addresses.

Linus

Florian Fainelli

unread,
Oct 24, 2016, 4:00:05 PM10/24/16
to
The older setup was using smtphost.broadcom.com which we have now
documented as being invalid, here Jonathan used gmail directly (since
that's our mail provider now):

Received: from lbrmn-lnxub108.corp.ad.broadcom.com ([216.31.219.19])
by smtp.gmail.com with ESMTPSA id
s89sm8325746qkl.44.2016.10.24.12.12.00
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Mon, 24 Oct 2016 12:12:03 -0700 (PDT)

Is there something else we need to check? Here is what I read for the
cover-letter:

Authentication-Results: mx.google.com;
dkim=pass header.i=@broadcom.com;
spf=pass (google.com: domain of
bcm-kernel-feedback-list.pdl+bn...@broadcom.com
designates 2607:f8b0:400c:c08::247 as permitted sender)
smtp.mailfrom=bcm-kernel-feedback-list.pdl+bn...@broadcom.com;
dmarc=pass (p=QUARANTINE dis=NONE) header.from=broadcom.com
--
Florian

Linus Torvalds

unread,
Oct 24, 2016, 4:20:06 PM10/24/16
to
On Mon, Oct 24, 2016 at 12:54 PM, Florian Fainelli <f.fai...@gmail.com> wrote:
>
> The older setup was using smtphost.broadcom.com which we have now
> documented as being invalid, here Jonathan used gmail directly (since
> that's our mail provider now):
>
> Received: from lbrmn-lnxub108.corp.ad.broadcom.com ([216.31.219.19])
> by smtp.gmail.com with ESMTPSA id
> s89sm8325746qkl.44.2016.10.24.12.12.00
> (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
> Mon, 24 Oct 2016 12:12:03 -0700 (PDT)

Hmm. I get that too, so if that's the right thing for a broadcom.com
address, it's not the smtp server issue.

We had a few cases of the kernel mailing list itself messing up emails
sufficiently to fail dkim, but that shouldn't be an issue for the
relaxed/relaxed model that broadcom uses (the vger mailing list
software screws up whitespace, which "relaxed" ignores).

> Is there something else we need to check? Here is what I read for the
> cover-letter:
>
> Authentication-Results: mx.google.com;
> dkim=pass header.i=@broadcom.com;
> spf=pass (google.com: domain of ...

Hmm. I get:

Authentication-Results: mx.google.com;
dkim=fail header.i=@broadcom.com;

with the actual dkim signature looking like this:

DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=broadcom.com; s=google;
h=from:to:cc:subject:date:message-id;
bh=9zStGnsZQDQqP6cm1CHPk7EYVtLvDsm2wN5qy5Mgx7M=;
b=Z/1QD+FwJogJY9D8Qd197Q+VJt7Tr9+WoHFeKYRL00yhvxrMg0P8jKj1FbucJTluvM
agC2eq9qCpZcNAfridjExDRDCuUPAIJIXTr9Npkpqlk6gEMq2FysrGer2D9Z4HQ/atTX
67VirFsQK0gK7impYMn9kW5Q9BIIw5bOg7OdI=

and those fields that it protects look like this:

From: Jonathan Richardson <jonathan....@broadcom.com>
To: Srinivas Kandagatla <srinivas....@linaro.org>, Maxime
Ripard <maxime...@free-electrons.com>
Cc: linux-ar...@lists.infradead.org,
linux-...@vger.kernel.org, devic...@vger.kernel.org, Mark Rutland
<mark.r...@arm.com>, Rob Herring <rob...@kernel.org>, Scott
Branden <sbra...@broadcom.com>, Ray Jui <rj...@broadcom.com>,
bcm-kernel-f...@broadcom.com, Jonathan Richardson
<jonathan....@broadcom.com>
Subject: [PATCH v1 0/3] Add support for Broadcom OTP controller
Date: Mon, 24 Oct 2016 12:12:01 -0700
Message-Id: <1477336324-10543-1-git-sen...@broadcom.com>

and I don't see anything obviously wrong anywhere - except for that
"dkim=fail" thing, and the email being in my spam folder.

Linus

Florian Fainelli

unread,
Oct 24, 2016, 5:30:06 PM10/24/16
to
Should we compare the headers added by lists.infradead.org and see what
could possibly go wrong here? I can see that by being delivered to
lists.infradead.org and then back to my personal gmail.com (not my other
broadcom.com account), there are a bunch of extra headers:

X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3
X-CRM114-CacheID: sfid-20161024_121226_013940_81319C20
X-CRM114-Status: GOOD ( 13.05 )
X-Spam-Score: -2.7 (--)
X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary:
Content analysis details: (-2.7 points)
pts rule name description
---- ----------------------
--------------------------------------------------
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at
http://www.dnswl.org/, low
trust [2607:f8b0:400d:c09:0:0:0:22f listed in] [list.dnswl.org]
-0.0 SPF_PASS SPF: sender matches SPF record
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
X-BeenThere: linux-ar...@lists.infradead.org
X-Mailman-Version: 2.1.20
Precedence: list

Would those be used by your mail client to put this mail in spam, or was
that done by the linux-foundation.org (also gmail?) mail upon reception?
--
Florian

Linus Torvalds

unread,
Oct 24, 2016, 6:00:05 PM10/24/16
to
On Mon, Oct 24, 2016 at 2:27 PM, Florian Fainelli <f.fai...@gmail.com> wrote:
>
> Should we compare the headers added by lists.infradead.org

So for me, it didn't go through infraded.org, but I got it through the
kernel mailing list.

I'll send you the raw email data in private, you can compare it
against your good one.

Linus

Markus Mayer

unread,
Oct 24, 2016, 6:50:05 PM10/24/16
to
FWIW, this thread ends up in the spam folder for me also on my private
e-mail account. And it's not the only Broadcom thread. Quite a few
Broadcom e-mails end up there. The thread was sent to me via
infradead.org. My private e-mail is also hosted by Gmail.

I get this:

SPF: PASS with IP 2001:1868:205:0:0:0:0:9 Learn more
DKIM: NEUTRAL with domain null Learn more
DMARC: FAIL Learn more

So, it's not DKIM for me, but DMARC that's failing.

The actual headers:

Received: from bombadil.infradead.org (bombadil.infradead.org.
[2001:1868:205::9])
by mx.google.com with ESMTPS id
r127si16944054pgr.251.2016.10.24.12.13.37
for <mmayer at mmayer.net>
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Mon, 24 Oct 2016 12:13:37 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of
linux-arm-kernel-bounces+mmayer=mmaye...@lists.infradead.org
designates 2001:1868:205::9 as permitted sender)
client-ip=2001:1868:205::9;
Authentication-Results: mx.google.com;
dkim=neutral (body hash did not verify) header.i=@broadcom.com;
spf=pass (google.com: best guess record for domain of
linux-arm-kernel-bounces+mmayer=mmaye...@lists.infradead.org
designates 2001:1868:205::9 as permitted sender)
smtp.mailfrom=linux-arm-kernel-bounces+mmayer=mmaye...@lists.infradead.org;
dmarc=fail (p=QUARANTINE dis=NONE) header.from=broadcom.com
Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by
bombadil.infradead.org

Regards,
-Markus

Florian Fainelli

unread,
Nov 16, 2016, 4:00:05 PM11/16/16
to
On 10/24/2016 12:12 PM, Jonathan Richardson wrote:
> From: Jonathan Richardson <jona...@broadcom.com>
>
> Reviewed-by: Ray Jui <ray...@broadcom.com>
> Tested-by: Jonathan Richardson <jonathan....@broadcom.com>
> Signed-off-by: Scott Branden <scott....@broadcom.com>
> Signed-off-by: Oza Pawandeep <o...@broadcom.com>
> Signed-off-by: Jonathan Richardson <jonathan....@broadcom.com>

Applied, thanks
--
Florian
0 new messages