Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] Spelling in in /arch/x86/mm

0 views
Skip to first unread message

Shaun Patterson

unread,
Dec 3, 2009, 8:20:01 PM12/3/09
to
Spelling fix
Signed-off-by: Shaun Patterson shaunpa...@gmail.com
---
�arch/x86/mm/kmmio.c |��� 2 +-
�1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
index 16ccbd7..72f1572 100644
--- a/arch/x86/mm/kmmio.c
+++ b/arch/x86/mm/kmmio.c
@@ -490,7 +490,7 @@ static void remove_kmmio_fault_pages(struct rcu_head *head)
� * 2. remove_kmmio_fault_pages()
� *��� Remove the pages from kmmio_page_table.
� * 3. rcu_free_kmmio_fault_pages()
- *��� Actally free the kmmio_fault_page structs as with RCU.
+ *��� Actually free the kmmio_fault_page structs as with RCU.
� */
�void unregister_kmmio_probe(struct kmmio_probe *p)
�{
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Ingo Molnar

unread,
Dec 4, 2009, 2:50:02 AM12/4/09
to

* Shaun Patterson <shaunpa...@gmail.com> wrote:

> Spelling fix
> Signed-off-by: Shaun Patterson shaunpa...@gmail.com
> ---

> ?arch/x86/mm/kmmio.c |??? 2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)


>
> diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
> index 16ccbd7..72f1572 100644
> --- a/arch/x86/mm/kmmio.c
> +++ b/arch/x86/mm/kmmio.c
> @@ -490,7 +490,7 @@ static void remove_kmmio_fault_pages(struct rcu_head *head)

> ? * 2. remove_kmmio_fault_pages()
> ? *??? Remove the pages from kmmio_page_table.
> ? * 3. rcu_free_kmmio_fault_pages()
> - *??? Actally free the kmmio_fault_page structs as with RCU.
> + *??? Actually free the kmmio_fault_page structs as with RCU.
> ? */
> ?void unregister_kmmio_probe(struct kmmio_probe *p)
> ?{

The fix looks good - but the patch is mangled. Please see
Documentation/email-clients.txt for details.

Thanks,

Ingo

Jiri Kosina

unread,
Dec 4, 2009, 7:50:01 AM12/4/09
to
On Fri, 4 Dec 2009, Ingo Molnar wrote:

> > Spelling fix
> > Signed-off-by: Shaun Patterson shaunpa...@gmail.com
> > ---
> > ?arch/x86/mm/kmmio.c |??? 2 +-
> > ?1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
> > index 16ccbd7..72f1572 100644
> > --- a/arch/x86/mm/kmmio.c
> > +++ b/arch/x86/mm/kmmio.c
> > @@ -490,7 +490,7 @@ static void remove_kmmio_fault_pages(struct rcu_head *head)
> > ? * 2. remove_kmmio_fault_pages()
> > ? *??? Remove the pages from kmmio_page_table.
> > ? * 3. rcu_free_kmmio_fault_pages()
> > - *??? Actally free the kmmio_fault_page structs as with RCU.
> > + *??? Actually free the kmmio_fault_page structs as with RCU.
> > ? */
> > ?void unregister_kmmio_probe(struct kmmio_probe *p)
> > ?{
>
> The fix looks good - but the patch is mangled. Please see
> Documentation/email-clients.txt for details.

Plus the Signed-off-by: line doesn't really have correct format (the valid
e-mail address format is expected here).

--
Jiri Kosina
SUSE Labs, Novell Inc.

Ingo Molnar

unread,
Dec 5, 2009, 2:20:02 AM12/5/09
to

* Jiri Kosina <jko...@suse.cz> wrote:

> On Fri, 4 Dec 2009, Ingo Molnar wrote:
>
> > > Spelling fix
> > > Signed-off-by: Shaun Patterson shaunpa...@gmail.com
> > > ---
> > > ?arch/x86/mm/kmmio.c |??? 2 +-
> > > ?1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
> > > index 16ccbd7..72f1572 100644
> > > --- a/arch/x86/mm/kmmio.c
> > > +++ b/arch/x86/mm/kmmio.c
> > > @@ -490,7 +490,7 @@ static void remove_kmmio_fault_pages(struct rcu_head *head)
> > > ? * 2. remove_kmmio_fault_pages()
> > > ? *??? Remove the pages from kmmio_page_table.
> > > ? * 3. rcu_free_kmmio_fault_pages()
> > > - *??? Actally free the kmmio_fault_page structs as with RCU.
> > > + *??? Actually free the kmmio_fault_page structs as with RCU.
> > > ? */
> > > ?void unregister_kmmio_probe(struct kmmio_probe *p)
> > > ?{
> >
> > The fix looks good - but the patch is mangled. Please see
> > Documentation/email-clients.txt for details.
>
> Plus the Signed-off-by: line doesn't really have correct format (the valid
> e-mail address format is expected here).

I can fix that - not the garbled-beyond-recognition patch though.

Ingo

Shaun Patterson

unread,
Dec 5, 2009, 10:00:02 AM12/5/09
to
> I can fix that - not the garbled-beyond-recognition patch though

Sorry about that. Try this.


Signed-off-by: Shaun Patterson <shaunpa...@gmail.com>
---

arch/x86/mm/kmmio.c | 2 +-


1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
index 16ccbd7..72f1572 100644
--- a/arch/x86/mm/kmmio.c
+++ b/arch/x86/mm/kmmio.c
@@ -490,7 +490,7 @@ static void remove_kmmio_fault_pages(struct rcu_head *head)

* 2. remove_kmmio_fault_pages()
* Remove the pages from kmmio_page_table.
* 3. rcu_free_kmmio_fault_pages()
- * Actally free the kmmio_fault_page structs as with RCU.
+ * Actually free the kmmio_fault_page structs as with RCU.


*/
void unregister_kmmio_probe(struct kmmio_probe *p)

{

tip-bot for Shaun Patterson

unread,
Dec 6, 2009, 4:20:02 AM12/6/09
to
Commit-ID: 8055039c2a2454c7159dcbde3161943b757a6e0e
Gitweb: http://git.kernel.org/tip/8055039c2a2454c7159dcbde3161943b757a6e0e
Author: Shaun Patterson <shaunpa...@gmail.com>
AuthorDate: Sat, 5 Dec 2009 10:41:34 -0500
Committer: Ingo Molnar <mi...@elte.hu>
CommitDate: Sun, 6 Dec 2009 09:23:40 +0100

x86: Fix typo in arch/x86/mm/kmmio.c

Signed-off-by: Shaun Patterson <shaunpa...@gmail.com>
Cc: Jiri Kosina <jko...@suse.cz>
Cc: p...@iki.fi
LKML-Reference: <1260027694.10...@linux-4lgc.site>
Signed-off-by: Ingo Molnar <mi...@elte.hu>

0 new messages