Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH 4/4] USB: option driver: add PID for Vodafone-Huawei K4511

432 views
Skip to first unread message

Andrew Bird

unread,
Jul 27, 2011, 12:30:19 PM7/27/11
to
This patch adds the product ID of Huawei's Vodafone K4511 mobile broadband
modem to option.c. This is necessary so that the driver gets loaded on demand
without the intervention of usb_modeswitch. This has the benefit of it becoming
available faster and also ensures that the option driver is not bound to a
network interface that should be claimed by cdc_ether.

Signed-off-by: Andrew Bird <a...@spheresystems.co.uk>
---
drivers/usb/serial/option.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index ceb9336..8156561 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -151,6 +151,7 @@ static void option_instat_callback(struct urb *urb);
#define HUAWEI_PRODUCT_K3770 0x14C9
#define HUAWEI_PRODUCT_K3771 0x14CA
#define HUAWEI_PRODUCT_K4510 0x14CB
+#define HUAWEI_PRODUCT_K4511 0x14CC
#define HUAWEI_PRODUCT_ETS1220 0x1803
#define HUAWEI_PRODUCT_E353 0x1506

@@ -556,6 +557,8 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3771, 0xff, 0x02, 0x32) },
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4510, 0xff, 0x01, 0x31) },
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4510, 0xff, 0x01, 0x32) },
+ { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4511, 0xff, 0x01, 0x31) },
+ { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4511, 0xff, 0x01, 0x32) },
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x01, 0x01) },
{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V640) },
{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V620) },
--
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Andrew Bird

unread,
Jul 27, 2011, 12:40:18 PM7/27/11
to
This patch adds the product ID of Huawei's Vodafone K3770 mobile broadband

modem to option.c. This is necessary so that the driver gets loaded on demand
without the intervention of usb_modeswitch. This has the benefit of it becoming
available faster and also ensures that the option driver is not bound to a
network interface that should be claimed by cdc_ether.

Signed-off-by: Andrew Bird <a...@spheresystems.co.uk>
---
drivers/usb/serial/option.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 60b25d8..4dbce2d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -148,6 +148,7 @@ static void option_instat_callback(struct urb *urb);
#define HUAWEI_PRODUCT_K4505 0x1464
#define HUAWEI_PRODUCT_K3765 0x1465
#define HUAWEI_PRODUCT_E14AC 0x14AC
+#define HUAWEI_PRODUCT_K3770 0x14C9


#define HUAWEI_PRODUCT_ETS1220 0x1803
#define HUAWEI_PRODUCT_E353 0x1506

@@ -547,6 +548,8 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3765, 0xff, 0xff, 0xff) },
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_ETS1220, 0xff, 0xff, 0xff) },
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E14AC, 0xff, 0xff, 0xff) },
+ { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3770, 0xff, 0x02, 0x31) },
+ { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3770, 0xff, 0x02, 0x32) },

Andrew Bird

unread,
Jul 27, 2011, 12:40:30 PM7/27/11
to
This patch adds the product ID of Huawei's Vodafone K4510 mobile broadband

modem to option.c. This is necessary so that the driver gets loaded on demand
without the intervention of usb_modeswitch. This has the benefit of it becoming
available faster and also ensures that the option driver is not bound to a
network interface that should be claimed by cdc_ether.

Signed-off-by: Andrew Bird <a...@spheresystems.co.uk>
---
drivers/usb/serial/option.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index b9783b6..ceb9336 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -150,6 +150,7 @@ static void option_instat_callback(struct urb *urb);
#define HUAWEI_PRODUCT_E14AC 0x14AC


#define HUAWEI_PRODUCT_K3770 0x14C9
#define HUAWEI_PRODUCT_K3771 0x14CA

+#define HUAWEI_PRODUCT_K4510 0x14CB


#define HUAWEI_PRODUCT_ETS1220 0x1803
#define HUAWEI_PRODUCT_E353 0x1506

@@ -553,6 +554,8 @@ static const struct usb_device_id option_ids[] = {


{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3770, 0xff, 0x02, 0x32) },

{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3771, 0xff, 0x02, 0x31) },


{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3771, 0xff, 0x02, 0x32) },

+ { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4510, 0xff, 0x01, 0x31) },
+ { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4510, 0xff, 0x01, 0x32) },

Andrew Bird

unread,
Jul 27, 2011, 12:50:01 PM7/27/11
to
This patch adds the product ID of Huawei's Vodafone K3771 mobile broadband

modem to option.c. This is necessary so that the driver gets loaded on demand
without the intervention of usb_modeswitch. This has the benefit of it becoming
available faster and also ensures that the option driver is not bound to a
network interface that should be claimed by cdc_ether.

Signed-off-by: Andrew Bird <a...@spheresystems.co.uk>
---
drivers/usb/serial/option.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 4dbce2d..b9783b6 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -149,6 +149,7 @@ static void option_instat_callback(struct urb *urb);


#define HUAWEI_PRODUCT_K3765 0x1465
#define HUAWEI_PRODUCT_E14AC 0x14AC

#define HUAWEI_PRODUCT_K3770 0x14C9
+#define HUAWEI_PRODUCT_K3771 0x14CA


#define HUAWEI_PRODUCT_ETS1220 0x1803
#define HUAWEI_PRODUCT_E353 0x1506

@@ -550,6 +551,8 @@ static const struct usb_device_id option_ids[] = {


{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E14AC, 0xff, 0xff, 0xff) },

{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3770, 0xff, 0x02, 0x31) },

{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3770, 0xff, 0x02, 0x32) },

+ { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3771, 0xff, 0x02, 0x31) },
+ { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3771, 0xff, 0x02, 0x32) },

Sergei Shtylyov

unread,
Jul 28, 2011, 7:00:02 AM7/28/11
to
Hello.

On 27-07-2011 20:03, Andrew Bird wrote:

> This patch adds the product ID of Huawei's Vodafone K3770 mobile broadband
> modem to option.c. This is necessary so that the driver gets loaded on demand
> without the intervention of usb_modeswitch. This has the benefit of it becoming
> available faster and also ensures that the option driver is not bound to a
> network interface that should be claimed by cdc_ether.

You seem to be adding 4 product IDs with the identical patch descriptions.
Why not do it in a single patch?

> Signed-off-by: Andrew Bird <a...@spheresystems.co.uk>

WBR, Sergei

Andrew Bird (Sphere Systems)

unread,
Jul 28, 2011, 7:20:01 AM7/28/11
to
Hi Sergei,

On Thursday 28 July 2011, Sergei Shtylyov wrote:
> Hello.
>
> On 27-07-2011 20:03, Andrew Bird wrote:
> > This patch adds the product ID of Huawei's Vodafone K3770 mobile
> > broadband modem to option.c. This is necessary so that the driver gets
> > loaded on demand without the intervention of usb_modeswitch. This has
> > the benefit of it becoming available faster and also ensures that the
> > option driver is not bound to a network interface that should be claimed
> > by cdc_ether.
>
> You seem to be adding 4 product IDs with the identical patch
> descriptions. Why not do it in a single patch?
>
> > Signed-off-by: Andrew Bird <a...@spheresystems.co.uk>
>
> WBR, Sergei

I'm pretty new to this, but I was following the one patch per change
idea, so as there are four devices I did a patch for each.

Happy to squash into one if that's more acceptable to people?


Andrew

Greg KH

unread,
Jul 28, 2011, 11:30:02 AM7/28/11
to
On Thu, Jul 28, 2011 at 12:10:05PM +0100, Andrew Bird (Sphere Systems) wrote:
> Hi Sergei,
>
> On Thursday 28 July 2011, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 27-07-2011 20:03, Andrew Bird wrote:
> > > This patch adds the product ID of Huawei's Vodafone K3770 mobile
> > > broadband modem to option.c. This is necessary so that the driver gets
> > > loaded on demand without the intervention of usb_modeswitch. This has
> > > the benefit of it becoming available faster and also ensures that the
> > > option driver is not bound to a network interface that should be claimed
> > > by cdc_ether.
> >
> > You seem to be adding 4 product IDs with the identical patch
> > descriptions. Why not do it in a single patch?
> >
> > > Signed-off-by: Andrew Bird <a...@spheresystems.co.uk>
> >
> > WBR, Sergei
>
> I'm pretty new to this, but I was following the one patch per change
> idea, so as there are four devices I did a patch for each.
>
> Happy to squash into one if that's more acceptable to people?

As you did it is fine, I'll queue it up next week when I return from
vacation.

greg k-h

0 new messages