Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] kbuild: Unbreak cleaning external module build directory

11 views
Skip to first unread message

Bart Van Assche

unread,
Nov 18, 2012, 10:10:02 AM11/18/12
to
Avoid that "$(MAKE) -C $(KDIR) M=$(PWD) clean" triggers the following
error message when invoked from inside the Makefile of an external
kernel module:

rm: cannot remove 'System.map': Permission denied
make[1]: *** [clean] Error 1

Cc: Sam Ravnborg <s...@ravnborg.org>
Cc: Arnaud Lacombe <laco...@gmail.com>
Cc: Nick Bowler <nbo...@elliptictech.com>
Cc: Richard Weinberger <ric...@nod.at>
Cc: Michal Marek <mma...@suse.cz>
Cc: <sta...@vger.kernel.org>
Signed-off-by: Bart Van Assche <bvana...@acm.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 9f6ca12..46b9be5 100644
--- a/Makefile
+++ b/Makefile
@@ -1252,7 +1252,7 @@ scripts: ;
endif # KBUILD_EXTMOD

clean: $(clean-dirs)
- $(Q)$(CONFIG_SHELL) $(srctree)/scripts/link-vmlinux.sh clean
+ $(Q)$(if $(KBUILD_EXTMOD),,$(CONFIG_SHELL) $(srctree)/scripts/link-vmlinux.sh clean)
$(call cmd,rmdirs)
$(call cmd,rmfiles)
@find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \
--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Michal Marek

unread,
Dec 9, 2012, 10:10:02 AM12/9/12
to
On 18.11.2012 16:01, Bart Van Assche wrote:
> Avoid that "$(MAKE) -C $(KDIR) M=$(PWD) clean" triggers the following
> error message when invoked from inside the Makefile of an external
> kernel module:
>
> rm: cannot remove 'System.map': Permission denied
> make[1]: *** [clean] Error 1

I just applied an earlier patch to fix this:
https://patchwork.kernel.org/patch/1663011/

Michal
0 new messages