Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[gentoo-dev] [PATCH 2/5] meson.eclass: Support dev-util/samurai

5 views
Skip to first unread message

Sam James

unread,
May 8, 2022, 7:10:03 PM5/8/22
to
From: orbea <or...@riseup.net>

samurai is a ninja-compatible build tool written in C which
works with cmake, meson and other users of ninja.

It is feature-complete and supports most of the same options
as ninja.

Signed-off-by: orbea <or...@riseup.net>
Signed-off-by: Sam James <s...@gentoo.org>
---
eclass/meson.eclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/meson.eclass b/eclass/meson.eclass
index f2f7173f5a9a..57f5be610340 100644
--- a/eclass/meson.eclass
+++ b/eclass/meson.eclass
@@ -48,7 +48,7 @@ inherit multiprocessing ninja-utils python-utils-r1 toolchain-funcs
EXPORT_FUNCTIONS src_configure src_compile src_test src_install

_MESON_DEPEND=">=dev-util/meson-0.59.4
- >=dev-util/ninja-1.8.2
+ ${NINJA_DEPEND}
dev-util/meson-format-array
"

--
2.35.1

Mike Gilbert

unread,
May 9, 2022, 11:10:03 AM5/9/22
to
On Sun, May 8, 2022 at 7:07 PM Sam James <s...@gentoo.org> wrote:
>
> From: orbea <or...@riseup.net>
>
> samurai is a ninja-compatible build tool written in C which
> works with cmake, meson and other users of ninja.
>
> It is feature-complete and supports most of the same options
> as ninja.

The patch looks fine, but the commit message doesn't describe the
change very well. It should probably mention something like "use
NINJA_DEPEND variable from ninja-utils.eclass".
0 new messages