[gentoo-dev] New eclasses for KDE 4
Wulf C. Krueger
Attached you'll find the new eclasses for KDE 4. We'd like to commit them
on Sunday, 14th, to be able to get KDE 4.0.0 into the official tree
(package.masked, though).
We would welcome any comments, especially if accompanied by patches ;)
and, of course, your kind approval to commit it. :-)
You can always find the current version of the eclasses in my gitweb as
well:
https://www2.mailstation.de/gitweb/?p=genkde4svn-dev.git;a=tree;f=eclass;hb=HEAD
--
Best regards, Wulf
Vlastimil Babka
Hash: SHA1
Wulf C. Krueger wrote:
| We would welcome any comments, especially if accompanied by patches ;)
| and, of course, your kind approval to commit it. :-)
Hi,
Checked only briefly, it's late :) but I miss a comment in the header
that you need EAPI=1 in ebuild to use this eclass (slot deps...),
perhaps a check that it's really set?
And some small things I noticed:
DEPEND="${DEPEND} - first time you define DEPEND it's empty, no? Not
carried from eclass to eclass (as it used to be when the portage
behavior was broken IIRC) but separate in each eclass.
kde4-meta.eclass says # @ECLASS: kde4-functions.eclass
The (non-existing atm :) Copyright could use 2008 already :)
VB
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.8 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkeIB5wACgkQtbrAj05h3oTtbQCeM+V7yKKG5uOLablx357W8QId
2KAAn1bTJvdZ8wM+38QgWBnHwGO0cbB0
=rVAg
-----END PGP SIGNATURE-----
--
gento...@lists.gentoo.org mailing list
Donnie Berkholz
> Hello, fellow Gentoo devs!
>
> Attached you'll find the new eclasses for KDE 4. We'd like to commit them
> on Sunday, 14th, to be able to get KDE 4.0.0 into the official tree
> (package.masked, though).
>
> We would welcome any comments, especially if accompanied by patches ;)
> and, of course, your kind approval to commit it. :-)
Could you use has() instead of hasq() ?
Thanks,
Donnie
--
gento...@lists.gentoo.org mailing list