Bug#1040817: glibc: Please ignore some tests on sparc64

[John Paul Adrian Glaubitz]

Source: glibc
Version: 2.37-5
Severity: normal
User: debian...@lists.debian.org
Usertags: sparc64
X-Debbugs-Cc: debian...@lists.debian.org

Hi!

The list of currently failing tests on sparc64 is:

FAIL: elf/tst-audit24a
FAIL: elf/tst-audit24b
FAIL: elf/tst-audit24c
FAIL: elf/tst-audit24d
FAIL: elf/tst-rtld-run-static
FAIL: nptl/tst-cancel24-static
FAIL: nptl/tst-cancel30
FAIL: socket/tst-socket-timestamp
FAIL: stdlib/isomac

According to upstream, the following audit tests are not going to be
fixed soon since the SPARC ABI makes it more difficult:

FAIL: elf/tst-audit24a
FAIL: elf/tst-audit24b
FAIL: elf/tst-audit24c
FAIL: elf/tst-audit24d

These are going to be fixed upstream soon, the fixes are supposedly
trivial:

FAIL: elf/tst-rtld-run-static
FAIL: nptl/tst-cancel24-static
FAIL: nptl/tst-cancel30

This test is supposedly a kernel issue:

FAIL: socket/tst-socket-timestamp

And this one allegedly not related to sparc64:

FAIL: stdlib/isomac

So, my suggestion would be to ignore the following tests for now:

FAIL: elf/tst-audit24a
FAIL: elf/tst-audit24b
FAIL: elf/tst-audit24c
FAIL: elf/tst-audit24d
FAIL: socket/tst-socket-timestamp
FAIL: stdlib/isomac

And looking at the testsuite results with 32-bit tests enabled [1], it looks like
the failures are the same. So, I think we can just ignore the above tests and then
re-enable testing on 32 bit as well.

Thanks,
Adrian

> [1] https://buildd.debian.org/status/fetch.php?pkg=glibc&arch=sparc64&ver=2.37-1&stamp=1684283585&raw=0

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

[John Paul Adrian Glaubitz]

Hi!

Correction: These two tests should be ignored as well:

FAIL: elf/tst-rtld-run-static
FAIL: nptl/tst-cancel24-static

So, it's only this failure that just got fixed today upstream [1]:

FAIL: nptl/tst-cancel30

Adrian

> [1] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=260d4b742bc36744aa2282421547f1a7b483d2f8

[Aurelien Jarno]

Hi,

On 2023-07-11 14:33, John Paul Adrian Glaubitz wrote:
> Hi!
>
> On Tue, 2023-07-11 at 06:17 +0200, John Paul Adrian Glaubitz wrote:
> > These are going to be fixed upstream soon, the fixes are supposedly
> > trivial:
> >
> > FAIL: elf/tst-rtld-run-static
> > FAIL: nptl/tst-cancel24-static
> > FAIL: nptl/tst-cancel30
> >
> > This test is supposedly a kernel issue:
> >
> > FAIL: socket/tst-socket-timestamp
> >
> > And this one allegedly not related to sparc64:
> >
> > FAIL: stdlib/isomac
> >
> > So, my suggestion would be to ignore the following tests for now:
> >
> > FAIL: elf/tst-audit24a
> > FAIL: elf/tst-audit24b
> > FAIL: elf/tst-audit24c
> > FAIL: elf/tst-audit24d
> > FAIL: socket/tst-socket-timestamp
> > FAIL: stdlib/isomac
>
> Correction: These two tests should be ignored as well:
>
> FAIL: elf/tst-rtld-run-static
> FAIL: nptl/tst-cancel24-static

Noted.

> So, it's only this failure that just got fixed today upstream [1]:
>
> FAIL: nptl/tst-cancel30

Ok, I see it's also fixed on the 2.37 branch, I'll pull it from there.

Cheers
Aurelien

--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aure...@aurel32.net http://aurel32.net

[John Paul Adrian Glaubitz]

On Tue, 2023-07-11 at 20:57 +0200, Aurelien Jarno wrote:
> > Correction: These two tests should be ignored as well:
> >
> > FAIL: elf/tst-rtld-run-static
> > FAIL: nptl/tst-cancel24-static
>
> Noted.
>
> > So, it's only this failure that just got fixed today upstream [1]:
> >
> > FAIL: nptl/tst-cancel30
>
> Ok, I see it's also fixed on the 2.37 branch, I'll pull it from there.

And there is now a fix for the audit issues:

> https://patchwork.sourceware.org/project/glibc/patch/20230711151558.314216...@linaro.org/

And re-enable the 32-bit tests then.

Adrian

[John Paul Adrian Glaubitz]

Hi!

On Tue, 2023-07-11 at 20:52 +0200, Aurelien Jarno wrote:
> > According to upstream, the following audit tests are not going to be
> > fixed soon since the SPARC ABI makes it more difficult:
> >
> > FAIL: elf/tst-audit24a
> > FAIL: elf/tst-audit24b
> > FAIL: elf/tst-audit24c
> > FAIL: elf/tst-audit24d
>

> Ok.

It happens that Adhemerval just posted a patch for the audit issue a few hours ago:

> https://patchwork.sourceware.org/project/glibc/patch/20230711151558.314216...@linaro.org/

So, we might not have the blacklist these as well.

> > These are going to be fixed upstream soon, the fixes are supposedly
> > trivial:
> >
> > FAIL: elf/tst-rtld-run-static
> > FAIL: nptl/tst-cancel24-static
> > FAIL: nptl/tst-cancel30
>

> Great.

>
> > This test is supposedly a kernel issue:
> >
> > FAIL: socket/tst-socket-timestamp
> >
> > And this one allegedly not related to sparc64:
> >
> > FAIL: stdlib/isomac
>

> What do you mean by "allegedly not related to sparc64"? This failure
> only appears on sparc*. The sparc32 has the following comment in
> debian/testsuite-xfail-debian.mk to ignore the failure:
>
> # Even if configured using --with-long-double-128, the biarch32 compiler
> # on sparc64 defaults to 64-bit doubles, causing the failure below. This
> # should be fixed by the following gcc patch:
> # http://gcc.gnu.org/ml/gcc-patches/2013-12/msg00318.html
> test-xfail-stdlib/isomac = yes
>
> Can you please check if there is a similar issue with the GCC
> configuration on sparc64?

That was the comment by Adhemerval when he looked at the issue.

> > So, my suggestion would be to ignore the following tests for now:
> >
> > FAIL: elf/tst-audit24a
> > FAIL: elf/tst-audit24b
> > FAIL: elf/tst-audit24c
> > FAIL: elf/tst-audit24d
> > FAIL: socket/tst-socket-timestamp
> > FAIL: stdlib/isomac
>

> Ok.

>
> > And looking at the testsuite results with 32-bit tests enabled [1], it looks like
> > the failures are the same. So, I think we can just ignore the above tests and then
> > re-enable testing on 32 bit as well.
>

> It appears that none of those fails on sparc32. Looking at it again, it
> even appears that the sparc32 build passed the testsuite without issue,
> so there was no need to disable it.

Hmm, then I actually mixed up the two testsuites, sorry. You can re-enable it then.

With the above fix for the audit tests, the tests to ignore should be:

FAIL: elf/tst-rtld-run-static
FAIL: nptl/tst-cancel24-static
FAIL: socket/tst-socket-timestamp
FAIL: stdlib/isomac

Adrian

[John Paul Adrian Glaubitz]

Hi!

On Tue, 2023-07-11 at 20:59 +0200, John Paul Adrian Glaubitz wrote:
> With the above fix for the audit tests, the tests to ignore should be:
>
> FAIL: elf/tst-rtld-run-static
> FAIL: nptl/tst-cancel24-static
> FAIL: socket/tst-socket-timestamp
> FAIL: stdlib/isomac

Just verified this. With both patches above applied, the failures reduce
to the four tests above.