Bug#1025779: onetbb: Please add patch to add support for ia64

[John Paul Adrian Glaubitz]

Source: onetbb
Version: 2021.7.0-1
Severity: normal
Tags: patch
User: debia...@lists.debian.org
Usertags: ia64
X-Debbugs-Cc: debia...@lists.debian.org

Hello!

The attached patch defines fetchadd4() on ia64 where it's currently
undefined which leads to the following build error:

FAILED: src/tbbmalloc/CMakeFiles/tbbmalloc.dir/__/tbb/itt_notify.cpp.o
/usr/bin/c++ -D__TBBMALLOC_BUILD -D__TBB_USE_ITT_NOTIFY -I/<<PKGBUILDDIR>>/src/tbbmalloc/../../include -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -specs=/usr/share/dpkg/pie-compile.specs -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -flto=auto -fno-fat-lto-objects -fPIC -flifetime-dse=1 -fno-rtti -fno-exceptions -std=c++11 -MD -MT src/tbbmalloc/CMakeFiles/tbbmalloc.dir/__/tbb/itt_notify.cpp.o -MF src/tbbmalloc/CMakeFiles/tbbmalloc.dir/__/tbb/itt_notify.cpp.o.d -o src/tbbmalloc/CMakeFiles/tbbmalloc.dir/__/tbb/itt_notify.cpp.o -c /<<PKGBUILDDIR>>/src/tbb/itt_notify.cpp
In file included from /<<PKGBUILDDIR>>/src/tbb/tools_api/ittnotify_static.c:17,
from /<<PKGBUILDDIR>>/src/tbb/itt_notify.cpp:43:
/<<PKGBUILDDIR>>/src/tbb/tools_api/ittnotify_config.h: In function ‘long int __itt_interlocked_increment(volatile long int*)’:
/<<PKGBUILDDIR>>/src/tbb/tools_api/ittnotify_config.h:370:12: error: ‘__TBB_machine_fetchadd4’ was not declared in this scope
370 | return __TBB_machine_fetchadd4(ptr, 1) + 1L;
| ^~~~~~~~~~~~~~~~~~~~~~~

Could you include the patch for the next upload?

I've also opened a PR upstream [1].

Thanks,
Adrian

> [1] https://github.com/oneapi-src/oneTBB/pull/983

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

[John Paul Adrian Glaubitz]

Hi Petter!

On Thu, 2023-08-03 at 09:28 +0200, Petter Reinholdtsen wrote:
> [Petter Reinholdtsen]
> > Perhaps you can provide more information now the patched code is
> > upstream?
>
> Note, the latest version fail during testing in
> <URL: https://buildd.debian.org/status/fetch.php?pkg=onetbb&arch=ia64&ver=2021.9.0-2&stamp=1691031827&raw=0 >:
>
> > 87% tests passed, 18 tests failed out of 136
>
> The failing tests segfaults. Could the issue be data type alignment?
> ia64 will segfault on unaligned data access.

If you feel fixing this, you can use yttrium.debian.net.

I don't have much time for ia64 at the moment.

Adrian

[Petter Reinholdtsen]

[John Paul Adrian Glaubitz]

> If you feel fixing this, you can use yttrium.debian.net.
>
> I don't have much time for ia64 at the moment.

Thanks. I just wanted to check the status and hopefully reduce the
amount of open bugs. I do not plan to increase the number of
architectures provided at this time, in case it will make it harder for
the package to propagate into testing.

--
Happy hacking
Petter Reinholdtsen

[John Paul Adrian Glaubitz]

Hello Petter!

Ports architectures do not affect the propagation of packages to testing.

So, feel free to ignore the tests on ia64.

FWIW, I have also a patch that I sent upstream that fixes powerpc, but I
need to clean it up again before upstream accepts it.

Adrian

[Petter Reinholdtsen]

[John Paul Adrian Glaubitz]

> Ports architectures do not affect the propagation of packages to
> testing.
>
> So, feel free to ignore the tests on ia64.

Ah, good point.

Part of the reason I do not want to introduce new architectures is that
I am just a drive-by team member looking at the package for a brief
moment in time, and believe such change, introducing debian-specific
patches for extra architectures, is better left to someone looking after
the package in the long run. I only look at onetbb to fix a freecad
propagation issue. :)

> FWIW, I have also a patch that I sent upstream that fixes powerpc, but
> I need to clean it up again before upstream accepts it.

I hope upstream fixes these issues. :)