Re: Request for review for Poetry(Was: Re: Asking for help Poetry)

Taihsiang Ho (tai271828)

unread,

Nov 19, 2021, 10:20:03 AM11/19/21

to

Hi Emmanuel,

I failed to build the poetry deb with the latest package source[1] for some pytest cases[4][5] since I was aware of this thread https://lists.debian.org/debian-python/2021/06/msg00017.html . Do you suggest where I should report or record the error messages I found?

By following my build steps[2] I could:

- successfully build the source with the commit "Initial review pass for python-poetry package"[3]
- fail to build the source with the commit "ignore tests that use tar.gz file instead of skip them"[4]
- fail to build the latest source[1][5]

Would you mind elaborating a bit more regarding the packaging steps or the current packaging status? I walked through the mailing list and the latest update I found is this email https://lists.debian.org/debian-python/2021/08/msg00025.html thread. It must be me not following the latest status and missing some necessary information.

I will try to fix these pytest errors during package building. It would be much appreciated that you could let me know if you are aware of anything that I should know for fixing these errors or regarding the packaging status. Thank you!

[1] git clone g...@salsa.debian.org:python-team/packages/poetry.git

[2] (build environment: ubuntu 20.04 on amd64)
1. Use this script to prepare the build environment https://gitlab.com/tai271828/tool-box/-/blob/dev/scripts/prepare-deb-build-poetry.sh
2. gbp buildpackage --git-ignore-new --git-builder=sbuild --extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-cleo_0.8.1-2_all.deb --extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-httpretty_1.1.4-1_all.deb --extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-pkginfo_1.4.2-3_all.deb

[3] The source of the commit 92c24884d3d1a67fa5de490520d1baf83dc208bf . Besides, I performed a quick test of the deb I built by installing it on Sid and trying some basic commands like "poetry init" and "poetry shell". The basic function behaviors expectedly.

[4] The source of the commit c20a910ab5ca679a362f762f5c317ca3af0e0989 and some of the error messages:

short test summary info
=======================
FAILED tests/test_factory.py::test_create_poetry - AssertionError: assert ['L...
FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error - ...
FAILED tests/masonry/builders/test_editable_builder.py::test_builder_installs_proper_files_for_standard_packages
### 3 failed, 576 passed, 5 skipped, 21 deselected, 15 warnings in 25.73s
<message skipped>
short test summary info ============================
====================================================
FAILED tests/test_factory.py::test_create_poetry - AssertionError: assert ['L...
FAILED tests/masonry/builders/test_editable_builder.py::test_builder_installs_proper_files_for_standard_packages
2 failed, 577 passed, 5 skipped, 21 deselected, 14 warnings in 24.09s
---------------------------------------------------------------------
<message skipped>
dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.10 3.9" returned exit code 13
make: *** [debian/rules:41: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

[5] Some of the error messages from latest package source:

short test summary info ============================
====================================================
FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error - ...
1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s
---------------------------------------------------------------------
<message skipped>
588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==========
======================================================================
dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.10 3.9" returned exit code 13
make: *** [debian/rules:44: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Kind regards,
Tai

Andrey Rahmatullin

unread,

Nov 19, 2021, 10:20:03 AM11/19/21

to

On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828) wrote:
> [5] Some of the error messages from latest package source:
>
> short test summary info ============================
> ====================================================
> FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error
> - ...
> 1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s
> ---------------------------------------------------------------------
> <message skipped>
> 588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==========
> ======================================================================
> dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
> "3.10 3.9" returned exit code 13
> make: *** [debian/rules:44: binary] Error 25
>
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit
> status 2

Yes, one test fails with 3.10 which isn't unexpected because the package
wasn't tested with it.

--
WBR, wRAR

signature.asc

Taihsiang Ho (tai271828)

unread,

Nov 19, 2021, 10:40:02 AM11/19/21

to

Hi Andrey,

Thank you for your information. I will have a look at the failure. If anyone has been working on this error, it would be appreciated to let me know how I can help.

Besides, I found this thread https://lists.debian.org/debian-python/2021/11/msg00025.html soon after I sent out my previous email. I believe I have followed up the latest process and status of poetry packaging for now. My apologies for not checking the email threads carefully enough.

-tai

Emmanuel Arias

unread,

Nov 19, 2021, 3:50:03 PM11/19/21

to

Hi Tai,

First of all thanks for the mail, and for the work in the poetry package. Very

detailed mail, amazing :)

As mentioned Andrey, yes there's a test that failed with py3.10. The package is

already in NEW, so we need to wait. In spite of this we can work to fix it.

I didn't investigate yet, So feel free to send a patch if you have one :).

For point [2] , call gbp with the b-depends are no longer needed, because all of them

are already in Debian.

Cheers,

Emmanuel

Taihsiang Ho (tai271828)

unread,

Nov 21, 2021, 11:10:03 AM11/21/21

to

Hi Emmanuel,

Thank you for your tip : )

Cheers,

Ta