Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#690281: unblock: file-mmagic/1.29-1
1 view
Skip to first unread message
intrigeri
Nov 10, 2012, 9:20:01 AM11/10/12
to
Hi,
Adam D. Barratt wrote (13 Oct 2012 15:06:42 GMT) :
>> Old file-mmagic uses deprecated perl syntax, so I want to unblock it.
>> The follwing is diff (really small changes):
>> http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=286&r2=279
(That's the diff from "somewhere in between 1.27 and 1.28" to 1.29...)
> The upstream diff for that particular fix might be really small
> and targeted.
It is. The revision that fixes this specific bug is 281:
http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=279&r2=281
It is really tiny and looks correct to me.
It might be a fine candidate for 1.27-2 and tpu
if someone cares enough.
The upstream ticket corresponding to this issue is
https://rt.cpan.org/Public/Bug/Display.html?id=74252
It seems to me the actual issue that patch fixes only may impact the
test suite of other modules that check for unexpected warnings. AFAIK,
Lucas' archive rebuilds did not detect any FTBFS caused by this bug in
Debian, so I would say it's low priority. Fellow debian-perl members,
did you see any?
Another bugfix that might be useful to include in Wheezy is r279
(memory leak fix):
http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=278&r2=279
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org
Adam D. Barratt wrote (13 Oct 2012 15:06:42 GMT) :
>> Old file-mmagic uses deprecated perl syntax, so I want to unblock it.
>> The follwing is diff (really small changes):
>> http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=286&r2=279
(That's the diff from "somewhere in between 1.27 and 1.28" to 1.29...)
> The upstream diff for that particular fix might be really small
> and targeted.
It is. The revision that fixes this specific bug is 281:
http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=279&r2=281
It is really tiny and looks correct to me.
It might be a fine candidate for 1.27-2 and tpu
if someone cares enough.
The upstream ticket corresponding to this issue is
https://rt.cpan.org/Public/Bug/Display.html?id=74252
It seems to me the actual issue that patch fixes only may impact the
test suite of other modules that check for unexpected warnings. AFAIK,
Lucas' archive rebuilds did not detect any FTBFS caused by this bug in
Debian, so I would say it's low priority. Fellow debian-perl members,
did you see any?
Another bugfix that might be useful to include in Wheezy is r279
(memory leak fix):
http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=278&r2=279
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org
gregor herrmann
Nov 10, 2012, 10:10:01 AM11/10/12
to
On Sat, 10 Nov 2012 15:12:56 +0100, intrigeri wrote:
> The upstream ticket corresponding to this issue is
> https://rt.cpan.org/Public/Bug/Display.html?id=74252
>
> It seems to me the actual issue that patch fixes only may impact the
> test suite of other modules that check for unexpected warnings. AFAIK,
> Lucas' archive rebuilds did not detect any FTBFS caused by this bug in
> Debian, so I would say it's low priority. Fellow debian-perl members,
> did you see any?
I don't remember any problems either.
> The upstream ticket corresponding to this issue is
> https://rt.cpan.org/Public/Bug/Display.html?id=74252
>
> It seems to me the actual issue that patch fixes only may impact the
> test suite of other modules that check for unexpected warnings. AFAIK,
> Lucas' archive rebuilds did not detect any FTBFS caused by this bug in
> Debian, so I would say it's low priority. Fellow debian-perl members,
> did you see any?
The CPAN ticket mentions as broken modules:
- CPAN::Digger: not in Debian
- Module::CPANTS::Analyse: here we repackage the dist and don't run
all tests, and it still builds
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Rebekka Bakken: As Tears Clear Our Eyes
0 new messages