Bug#1055694: initramfs-tools: After updating coreutils cp: not replacing in console when running update-initramfs

[Konomi]

Package: initramfs-tools
Version: 0.142
Severity: normal
X-Debbugs-Cc: konomi...@gmail.com

Dear Maintainer,

After updating coreutils from 9.1-1 to 9.4-1+b1 the following lines appear when
running update-initramfs -u:

cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/cat'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/cpio'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/dd'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/dmesg'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/false'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/gunzip'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/kill'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/ln'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/ls'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/mkdir'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/mkfifo'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/mknod'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/mount'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/mv'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/nuke'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/readlink'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/resume'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/sh'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/sleep'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/sync'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/true'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/umount'
cp: not replacing '/var/tmp/mkinitramfs_vZS3YW/bin/uname'

The lines seem to be a cosmetic issue only, but I cannot be entirely sure.


-- Package-specific info:
-- initramfs sizes
-rw-r--r-- 1 root root 78M Nov 10 19:13 /boot/initrd.img-6.5.0-3-amd64
-rw-r--r-- 1 root root 78M Nov 10 19:13 /boot/initrd.img-6.5.0-4-amd64
-- /proc/cmdline
BOOT_IMAGE=/boot/vmlinuz-6.5.0-4-amd64 root=UUID=e7b71052-3dff-454b-9730-7b146ebdf115 ro preempt=full quiet

-- /proc/filesystems
btrfs
fuseblk
vfat

-- lsmod
Module Size Used by
tcp_diag 12288 0
inet_diag 28672 1 tcp_diag
vboxnetadp 28672 0
vboxnetflt 40960 0
vboxdrv 716800 2 vboxnetadp,vboxnetflt
nvme_fabrics 32768 0
ccm 20480 9
rfcomm 102400 16
snd_seq_dummy 12288 0
snd_hrtimer 12288 1
snd_seq 114688 7 snd_seq_dummy
qrtr 57344 4
cmac 12288 3
algif_hash 12288 1
algif_skcipher 12288 1
af_alg 36864 6 algif_hash,algif_skcipher
bnep 36864 2
zstd 12288 12
zram 40960 2
zsmalloc 36864 1 zram
btusb 81920 0
btrtl 28672 1 btusb
btbcm 24576 1 btusb
intel_rapl_msr 20480 0
btintel 57344 1 btusb
intel_rapl_common 36864 1 intel_rapl_msr
btmtk 12288 1 btusb
binfmt_misc 28672 1
bluetooth 1126400 44 btrtl,btmtk,btintel,btbcm,bnep,btusb,rfcomm
edac_mce_amd 40960 0
kvm_amd 184320 0
iwlmvm 589824 0
kvm 1359872 1 kvm_amd
mac80211 1392640 1 iwlmvm
sha3_generic 16384 1
jitterentropy_rng 20480 1
snd_hda_codec_realtek 192512 1
irqbypass 12288 1 kvm
snd_hda_codec_generic 114688 1 snd_hda_codec_realtek
ledtrig_audio 12288 1 snd_hda_codec_generic
snd_hda_codec_hdmi 90112 1
libarc4 12288 1 mac80211
ghash_clmulni_intel 16384 0
sha512_ssse3 53248 1
snd_hda_intel 61440 4
sha512_generic 16384 1 sha512_ssse3
snd_usb_audio 417792 3
ctr 12288 3
snd_intel_dspcfg 32768 1 snd_hda_intel
snd_usbmidi_lib 49152 1 snd_usb_audio
snd_intel_sdw_acpi 16384 1 snd_intel_dspcfg
drbg 49152 1
snd_rawmidi 53248 1 snd_usbmidi_lib
aesni_intel 360448 10
ansi_cprng 12288 0
iwlwifi 544768 1 iwlmvm
snd_hda_codec 225280 4 snd_hda_codec_generic,snd_hda_codec_hdmi,snd_hda_intel,snd_hda_codec_realtek
crypto_simd 16384 1 aesni_intel
cryptd 28672 3 crypto_simd,ghash_clmulni_intel
ecdh_generic 16384 2 bluetooth
rapl 20480 0
ecc 45056 1 ecdh_generic
snd_seq_device 16384 2 snd_seq,snd_rawmidi
crc16 12288 1 bluetooth
snd_hda_core 147456 5 snd_hda_codec_generic,snd_hda_codec_hdmi,snd_hda_intel,snd_hda_codec,snd_hda_codec_realtek
mc 94208 1 snd_usb_audio
wmi_bmof 12288 0
snd_hwdep 20480 2 snd_usb_audio,snd_hda_codec
gigabyte_wmi 12288 0
sg 45056 0
cfg80211 1339392 3 iwlmvm,iwlwifi,mac80211
joydev 24576 0
snd_pcm 188416 8 snd_hda_codec_hdmi,snd_hda_intel,snd_usb_audio,snd_hda_codec,snd_hda_core
snd_timer 53248 3 snd_seq,snd_hrtimer,snd_pcm
snd 151552 26 snd_hda_codec_generic,snd_seq,snd_seq_device,snd_hda_codec_hdmi,snd_hwdep,snd_hda_intel,snd_usb_audio,snd_usbmidi_lib,snd_hda_codec,snd_hda_codec_realtek,snd_timer,snd_pcm,snd_rawmidi
sp5100_tco 16384 0
acpi_cpufreq 32768 0
nls_ascii 12288 1
soundcore 16384 1 snd
watchdog 49152 1 sp5100_tco
nls_cp437 16384 1
ccp 139264 4 kvm_amd
k10temp 12288 0
rfkill 40960 8 iwlmvm,bluetooth,cfg80211
vfat 20480 1
fat 102400 1 vfat
nft_nat 12288 4
evdev 28672 14
nft_chain_nat 12288 2
nf_nat 65536 2 nft_nat,nft_chain_nat
nf_conntrack 212992 2 nf_nat,nft_nat
nf_defrag_ipv6 24576 1 nf_conntrack
nf_defrag_ipv4 12288 1 nf_conntrack
nf_tables 372736 30 nft_nat,nft_chain_nat
msr 12288 0
it87 77824 0
hwmon_vid 12288 1 it87
nfnetlink 20480 1 nf_tables
parport_pc 40960 0
ppdev 24576 0
lp 20480 0
parport 81920 3 parport_pc,lp,ppdev
fuse 208896 5
dm_mod 221184 0
loop 36864 0
efi_pstore 12288 0
configfs 69632 1
ip_tables 28672 0
x_tables 57344 1 ip_tables
autofs4 57344 2
btrfs 2023424 1
blake2b_generic 24576 0
efivarfs 24576 1
raid10 77824 0
raid456 200704 0
async_raid6_recov 20480 1 raid456
async_memcpy 16384 2 raid456,async_raid6_recov
async_pq 16384 2 raid456,async_raid6_recov
async_xor 16384 3 async_pq,raid456,async_raid6_recov
async_tx 16384 5 async_pq,async_memcpy,async_xor,raid456,async_raid6_recov
xor 20480 2 async_xor,btrfs
raid6_pq 122880 4 async_pq,btrfs,raid456,async_raid6_recov
libcrc32c 12288 5 nf_conntrack,nf_nat,btrfs,nf_tables,raid456
crc32c_generic 12288 0
raid1 57344 0
raid0 24576 0
multipath 16384 0
linear 16384 0
md_mod 225280 6 raid1,raid10,raid0,linear,raid456,multipath
sd_mod 86016 0
uas 32768 0
usb_storage 86016 1 uas
hid_generic 12288 0
amdgpu 11436032 43
usbhid 73728 0
hid 176128 2 usbhid,hid_generic
amdxcp 12288 1 amdgpu
drm_buddy 20480 1 amdgpu
gpu_sched 57344 1 amdgpu
video 73728 1 amdgpu
drm_suballoc_helper 12288 1 amdgpu
drm_display_helper 233472 1 amdgpu
cec 69632 1 drm_display_helper
rc_core 73728 1 cec
drm_ttm_helper 12288 1 amdgpu
ttm 106496 2 amdgpu,drm_ttm_helper
ahci 49152 0
xhci_pci 24576 0
nvme 57344 2
libahci 61440 1 ahci
drm_kms_helper 270336 4 drm_display_helper,amdgpu
xhci_hcd 352256 1 xhci_pci
libata 475136 2 libahci,ahci
nvme_core 196608 4 nvme,nvme_fabrics
drm 765952 29 gpu_sched,drm_kms_helper,drm_suballoc_helper,drm_display_helper,drm_buddy,amdgpu,drm_ttm_helper,ttm,amdxcp
igb 311296 0
t10_pi 20480 2 sd_mod,nvme_core
usbcore 409600 8 xhci_hcd,snd_usb_audio,usbhid,snd_usbmidi_lib,usb_storage,btusb,xhci_pci,uas
crc32_pclmul 12288 0
crc32c_intel 16384 2
scsi_mod 327680 5 sd_mod,usb_storage,uas,libata,sg
crc64_rocksoft 16384 1 t10_pi
i2c_piix4 32768 0
crc64 16384 1 crc64_rocksoft
dca 16384 1 igb
crc_t10dif 16384 1 t10_pi
crct10dif_generic 12288 0
i2c_algo_bit 12288 2 igb,amdgpu
crct10dif_pclmul 12288 1
usb_common 20480 2 xhci_hcd,usbcore
scsi_common 16384 6 scsi_mod,sd_mod,usb_storage,uas,libata,sg
crct10dif_common 12288 3 crct10dif_generic,crc_t10dif,crct10dif_pclmul
wmi 40960 3 video,gigabyte_wmi,wmi_bmof
gpio_amdpt 16384 0
gpio_generic 20480 1 gpio_amdpt
button 24576 0

-- /etc/initramfs-tools/modules
amdgpu

-- /etc/kernel-img.conf
# Kernel image management overrides
# See kernel-img.conf(5) for details
do_symlinks = yes
do_bootloader = no
do_initrd = yes
link_in_boot = no

-- /etc/initramfs-tools/initramfs.conf
MODULES=most
BUSYBOX=auto
KEYMAP=n
COMPRESS=zstd
DEVICE=
NFSROOT=auto
RUNSIZE=10%
FSTYPE=auto

-- /etc/initramfs-tools/update-initramfs.conf
update_initramfs=yes
backup_initramfs=no

-- /etc/crypttab
# <target name> <source device> <key file> <options>

-- /proc/mdstat
Personalities : [linear] [multipath] [raid0] [raid1] [raid6] [raid5] [raid4] [raid10]
unused devices: <none>

-- mkinitramfs hooks
/etc/initramfs-tools/hooks/:

/usr/share/initramfs-tools/hooks:
amd64_microcode
btrfs
dmsetup
fsck
fuse
intel_microcode
keymap
klibc-utils
kmod
mdadm
ntfs_3g
plymouth
resume
thermal
udev
xfs
zz-busybox


-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-4-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages initramfs-tools depends on:
ii initramfs-tools-core 0.142
ii linux-base 4.9

initramfs-tools recommends no packages.

Versions of packages initramfs-tools suggests:
ii bash-completion 1:2.11-8

-- no debconf information

[Debian Bug Tracking System]

Processing control commands:

> reassign -1 klibc-utils
Bug #1055694 [initramfs-tools] initramfs-tools: After updating coreutils cp: not replacing in console when running update-initramfs
Bug reassigned from package 'initramfs-tools' to 'klibc-utils'.
No longer marked as found in versions initramfs-tools/0.142.
Ignoring request to alter fixed versions of bug #1055694 to the same values previously set
> affects -1 initramfs-tools
Bug #1055694 [klibc-utils] initramfs-tools: After updating coreutils cp: not replacing in console when running update-initramfs
Added indication that 1055694 affects initramfs-tools

--
1055694: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1055694
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[Sven Joachim]

Control: reassign -1 klibc-utils
Control: affects -1 initramfs-tools

FWIW, this has been triggered by the following changes in coreutils:

,----
| * Noteworthy changes in release 9.3 (2023-04-18) [stable]
|
| ** Changes in behavior
|
| 'cp -n' and 'mv -n' now issue an error diagnostic if skipping a file,
| to correspond with -n inducing a nonzero exit status as of coreutils 9.2.
|
| * Noteworthy changes in release 9.2 (2023-03-20) [stable]
|
| ** Changes in behavior
|
| 'cp -n' and 'mv -n' now exit with nonzero status if they skip their
| action because the destination exists, and likewise for 'cp -i',
| 'ln -i', and 'mv -i' when the user declines. (POSIX specifies this
| for 'cp -i' and 'mv -i'.)
`----

I looked for 'cp -n' in the initramfs-tools source and could not find
it. It turns out that the actual culprit is the file
/usr/share/initramfs-tools/hooks/klibc-utils which uses the -n option,
apparently with good reason, namely not to overwrite files from busybox.

> The lines seem to be a cosmetic issue only, but I cannot be entirely sure.

There do not seem to be any ill effects beside the warnings.

Cheers,
Sven

[Thorsten Glaser]

On Fri, 10 Nov 2023, Sven Joachim wrote:

>| 'cp -n' and 'mv -n' now exit with nonzero status if they skip their
>| action because the destination exists, and likewise for 'cp -i',

Ouch! Nonzero? That’s harsh, and bad as it’s impossible to distinguish
between error and declining to copy/move.

There is a good example in diff(1) for how to handle this better:
use distinct errorlevels for each case.

Michael, could you perhaps throw that upstream?

bye,
//mirabilos
--
15:41⎜<Lo-lan-do:#fusionforge> Somebody write a testsuite for helloworld :-)

[Sven Joachim]

On 2023-11-11 01:32 +0100, Thorsten Glaser wrote:

> On Fri, 10 Nov 2023, Sven Joachim wrote:
>
>>| 'cp -n' and 'mv -n' now exit with nonzero status if they skip their
>>| action because the destination exists, and likewise for 'cp -i',
>
> Ouch! Nonzero? That’s harsh, and bad as it’s impossible to distinguish
> between error and declining to copy/move.
>
> There is a good example in diff(1) for how to handle this better:
> use distinct errorlevels for each case.
>
> Michael, could you perhaps throw that upstream?

There is already an upstream bug report for this, see
https://debbugs.gnu.org/62572.

Cheers,
Sven

[Mario Izquierdo (mariodebian)]

Package: klibc-utils
Version: 2.0.13-2
Followup-For: Bug #1055694

Dear Maintainer,

I found a small typo in initramfs-tools klibc-utils script:

# diff -ur klibc-utils /usr/share/initramfs-tools/hooks/klibc-utils
--- klibc-utils 2023-12-07 10:35:52.738502916 +0100
+++ /usr/share/initramfs-tools/hooks/klibc-utils 2023-12-07 10:36:02.686695427 +0100
@@ -27,7 +27,7 @@
;;
*)
# Don't install commands that already exist in /bin or /sbin
- if ! [ -e "${DESTDIR}/sbin/$command" ]; then
+ if ! [ -e "${DESTDIR}/bin/$command" ]; then
cp -pnL "$src" "${DESTDIR}/bin"
fi
;;


With this change "if" works ok detecting file exists and don't try to overwrite.

Greetings

-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-4-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8), LANGUAGE not set

Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages klibc-utils depends on:
ii libklibc 2.0.13-2

klibc-utils recommends no packages.

klibc-utils suggests no packages.

-- no debconf information

[Vincent Lefevre]

Hi,

On 2023-12-07 10:43:23 +0100, Mario Izquierdo (mariodebian) wrote:
> I found a small typo in initramfs-tools klibc-utils script:
>
> # diff -ur klibc-utils /usr/share/initramfs-tools/hooks/klibc-utils
> --- klibc-utils 2023-12-07 10:35:52.738502916 +0100
> +++ /usr/share/initramfs-tools/hooks/klibc-utils 2023-12-07 10:36:02.686695427 +0100
> @@ -27,7 +27,7 @@
> ;;
> *)
> # Don't install commands that already exist in /bin or /sbin
> - if ! [ -e "${DESTDIR}/sbin/$command" ]; then
> + if ! [ -e "${DESTDIR}/bin/$command" ]; then
> cp -pnL "$src" "${DESTDIR}/bin"
> fi
> ;;

But the code doesn't match the comment ("in /bin or /sbin").
What is actually expected?

--
Vincent Lefèvre <vin...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

[Florent 'Skia' Jacquet]

Hi,

There is a Merge Request on Salsa to fix this here (didn't test it yet):
https://salsa.debian.org/kernel-team/klibc/-/merge_requests/12

Also, here is the corresponding Ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/klibc/+bug/2046336

Cheers
Skia

[Michael Stone]

Where do we stand on this after coreutils 9.4-3? The autopkgtest is
failing, but I think at this point that's bogus (because of the new
deprecation warning), and the functionality is actually ok?

[Chris Hofstaedtler]

On Wed, Jan 03, 2024 at 04:59:15PM -0500, Michael Stone wrote:
> On Sat, Nov 11, 2023 at 01:32:59AM +0100, Thorsten Glaser wrote:
> > On Fri, 10 Nov 2023, Sven Joachim wrote:
> >
> > > | 'cp -n' and 'mv -n' now exit with nonzero status if they skip their
> > > | action because the destination exists, and likewise for 'cp -i',
> >
> > Ouch! Nonzero? That’s harsh, and bad as it’s impossible to distinguish
> > between error and declining to copy/move.
> >
> > There is a good example in diff(1) for how to handle this better:
> > use distinct errorlevels for each case.
> >
> > Michael, could you perhaps throw that upstream?
>

> Where do we stand on this after coreutils 9.4-3? The autopkgtest is failing,
> but I think at this point that's bogus (because of the new deprecation
> warning), and the functionality is actually ok?

Failing autopkgtest:
https://ci.debian.net/packages/i/initramfs-tools/testing/amd64/41469415/

"Good" reference:
https://ci.debian.net/packages/i/initramfs-tools/testing/amd64/41379006/

The autopkgtest now probably "just" fails because of the
deprecation warning on stderr. Might be best to update cp usage in
/usr/share/initramfs-tools/hooks/klibc-utils, then it should be
good?

Chris

[Debian Bug Tracking System]

Your message dated Wed, 21 Feb 2024 14:37:16 +0000
with message-id <E1rcnim-...@fasolo.debian.org>
and subject line Bug#1055694: fixed in klibc 2.0.13-4
has caused the Debian Bug report #1055694,
regarding /usr/share/initramfs-tools/hooks/klibc-utils: cp: warning: behavior of -n is non-portable and may change in future; use --update=none instead
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)