Bug#1064276: bookworm-pu: package python-channels-redis/4.0.0-1+deb12u1

Colin Watson

unread,

Feb 19, 2024, 8:30:05 AM2/19/24

to

Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.d...@packages.debian.org
Usertags: pu
X-Debbugs-Cc: python-cha...@packages.debian.org, Michael Fladischer <fl...@debian.org>
Control: affects -1 + src:python-channels-redis

[ Reason ]
The version of python-channels-redis in bookworm suffers from
https://bugs.debian.org/1027387 /
https://github.com/django/channels_redis/issues/332, which was
introduced in 4.0.0 and is a regression from bullseye. I ran into this
while working on debusine.

[ Impact ]
I believe that any application that (a) runs Celery, (b) uses
channels-redis, and (c) sends to a channel via async_to_sync in a Celery
task without explicitly closing redis pools will encounter RuntimeErrors
as per the upstream bug report above.

I was able to work around this in my application
(https://salsa.debian.org/freexian-team/debusine/-/merge_requests/594),
but I lost a few hours to figuring this out and it would be good if
others didn't have to.

[ Tests ]
It's covered by the upstream test suite, which is run via autopkgtest.

I also confirmed that this change fixes the problems I ran into in
debusine, without applying any workarounds.

[ Risks ]
The alternative is letting applications work around this individually,
which I think on balance is probably worse - I initially tried switching
to RedisPubSubChannelLayer instead, which did more or less work but
required various other rather strange workarounds.

[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable

[ Changes ]
This is a straight cherry-pick of an upstream change to close redis
connection pools when closing the asyncio loop.

--
Colin Watson (he/him) [cjwa...@debian.org]

python-channels-redis_4.0.0-1+deb12u1.debdiff

Jonathan Wiltshire

unread,

Feb 21, 2024, 2:50:04 AM2/21/24

to

Control: tag -1 confirmed

On Mon, Feb 19, 2024 at 01:26:17PM +0000, Colin Watson wrote:
> [ Reason ]
> The version of python-channels-redis in bookworm suffers from
> https://bugs.debian.org/1027387 /
> https://github.com/django/channels_redis/issues/332, which was
> introduced in 4.0.0 and is a regression from bullseye. I ran into this
> while working on debusine.

Please go ahead.

Thanks,

--
Jonathan Wiltshire j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1

Debian Bug Tracking System

unread,

Feb 21, 2024, 2:50:05 AM2/21/24

to

Processing control commands:

> tag -1 confirmed
Bug #1064276 [release.debian.org] bookworm-pu: package python-channels-redis/4.0.0-1+deb12u1
Added tag(s) confirmed.

--
1064276: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064276
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Colin Watson

unread,

Feb 21, 2024, 6:00:05 AM2/21/24

to

On Wed, Feb 21, 2024 at 07:40:27AM +0000, Jonathan Wiltshire wrote:
> On Mon, Feb 19, 2024 at 01:26:17PM +0000, Colin Watson wrote:
> > [ Reason ]
> > The version of python-channels-redis in bookworm suffers from
> > https://bugs.debian.org/1027387 /
> > https://github.com/django/channels_redis/issues/332, which was
> > introduced in 4.0.0 and is a regression from bullseye. I ran into this
> > while working on debusine.
>
> Please go ahead.

Uploaded, thanks.