Bug#861649: Newer version uploaded

[Adam Borowski]

Hi!

On Fri, Oct 13, 2017 at 11:09:41AM +0200, Gard Spreemann wrote:
> The package has now been updated to the latest upstream (2.0.1).
>
> It can be downloaded by
>
> dget -x https://mentors.debian.net/debian/pool/main/g/gudhi/gudhi_2.0.1+dfsg-1.dsc

Before a human review, it'd be good to fix issues found by automated tools.
In particular, lintian throws a lot. Please run it on both source and built
packages (lintian gudhi*changes).

"lintian -i" gives a helpful explanation how to fix these problems.


Meow!
--
⢀⣴⠾⠻⢶⣦⠀ We domesticated dogs 36000 years ago; together we chased
⣾⠁⢰⠒⠀⣿⡁ animals, hung out and licked or scratched our private parts.
⢿⡄⠘⠷⠚⠋⠀ Cats domesticated us 9500 years ago, and immediately we got
⠈⠳⣄⠀⠀⠀⠀ agriculture, towns then cities. -- whitroth on /.

[Tobias Frost]

Control: tags -1 moreinfo

Hi Gard,

I was checking your RFS, but I cannot get it compiled...
Please check and then remove the moreinfo tag again...

tobi

excerpt from the log:

/build/gudhi-
2.0.1+dfsg/example/Persistent_cohomology/weighted_alpha_complex_3d_pers
istence.cpp:57:21: error: 'Bare_point' in 'using Gt = class
CGAL::Regular_triangulation_euclidean_traits_3<CGAL::Epick> {aka class
CGAL::Regular_triangulation_euclidean_traits_3<CGAL::Epick>}' does not
name a type
using Point_3 = Gt::Bare_point;
^~~~~~~~~~
/build/gudhi-
2.0.1+dfsg/example/Persistent_cohomology/weighted_alpha_complex_3d_pers
istence.cpp:58:30: error: 'Weighted_point' in 'using Gt = class
CGAL::Regular_triangulation_euclidean_traits_3<CGAL::Epick> {aka class
CGAL::Regular_triangulation_euclidean_traits_3<CGAL::Epick>}' does not
name a type
using Weighted_point_3 = Gt::Weighted_point;
^~~~~~~~~~~~~~
/build/gudhi-
2.0.1+dfsg/example/Persistent_cohomology/weighted_alpha_complex_3d_pers
istence.cpp: In function 'int main(int, char* const*)':
/build/gudhi-
2.0.1+dfsg/example/Persistent_cohomology/weighted_alpha_complex_3d_pers
istence.cpp:107:31: error: 'Point_3' was not declared in this scope
Gudhi::Points_3D_off_reader<Point_3> off_reader(offInputFile);
^~~~~~~
/build/gudhi-
2.0.1+dfsg/example/Persistent_cohomology/weighted_alpha_complex_3d_pers
istence.cpp:107:31: note: suggested alternative:
In file included from /usr/include/CGAL/user_classes.h:42:0,
from /usr/include/CGAL/Kernel/global_functions_2.h:33,
from /usr/include/CGAL/Kernel/global_functions.h:31,
from /usr/include/CGAL/Cartesian/Cartesian_base.h:30,
from /usr/include/CGAL/Simple_cartesian.h:28,
from
/usr/include/CGAL/Exact_predicates_inexact_constructions_kernel.h:28,
from /build/gudhi-
2.0.1+dfsg/example/Persistent_cohomology/weighted_alpha_complex_3d_pers
istence.cpp:29:
/usr/include/CGAL/Point_3.h:39:7: note: 'CGAL::Point_3'
class Point_3 : public R_::Kernel_base::Point_3
^~~~~~~
/build/gudhi-
2.0.1+dfsg/example/Persistent_cohomology/weighted_alpha_complex_3d_pers
istence.cpp:107:38: error: template argument 1 is invalid
Gudhi::Points_3D_off_reader<Point_3> off_reader(offInputFile);
^
/build/gudhi-
2.0.1+dfsg/example/Persistent_cohomology/weighted_alpha_complex_3d_pers
istence.cpp:107:63: error: cannot convert 'std::__cxx11::string {aka
std::__cxx11::basic_string<char>}' to 'int' in initialization
Gudhi::Points_3D_off_reader<Point_3> off_reader(offInputFile);

[Tobias Frost]

Control: tags -1 moreinfo

On Mon, 05 Feb 2018 11:07:40 +0100 Gard Spreemann <gspre...@gmail.com
> wrote:
> Control: tags -1 - moreinfo

>
> On Tuesday 26 December 2017 21:58:36 CET Tobias Frost wrote:
> > I was checking your RFS, but I cannot get it compiled...
> > Please check and then remove the moreinfo tag again...
>

> Hello again,
>
> Upstream has now released GUDHI 2.1.0 which is compatible with the
> CGAL version in sid.
>
> If you have a chance to take a look, version 2.1.0-1 of the package
> can be obtained from
>
> https://mentors.debian.net/debian/pool/main/g/gudhi/gudhi_2.1.0+dfsg
-1.dsc
>

Ok, it builds now.
But there are tons of lintian warnings "privacy-break-generic", just
one example: Not checked, but maybe some template for the doc
generation has a link to this site?

W: libgudhi-doc: privacy-breach-generic
usr/share/doc/libgudhi/html/_active__witness_8h_source.html [<img src="
http://gudhi.gforge.inria.fr/assets/img/home.png"
alt="&nbsp;&nbsp;gudhi">] (http://gudhi.gforge.inria.fr/assets/img/home
.png)
W: libgudhi-doc: privacy-breach-generic
usr/share/doc/libgudhi/html/_active__witness_8h_source.html [<link
rel="stylesheet" type="text/css" href="http://pages.saclay.inria.fr/vin
cent.rouvreau/gudhi/gudhi-doc-
2.0.0/assets/css/styles_feeling_responsive.css" />] (http://pages.sacla
y.inria.fr/vincent.rouvreau/gudhi/gudhi-doc-
2.0.0/assets/css/styles_feeling_responsive.css)

There are other lintian warnings as well; just a friendly reminder to
alwyays run linitian. Better, include it in your build process so that
it is automatically executed...


--
tobi

[Tobias Frost]

Control: tags -1 moreinfo

On Tue, 06 Mar 2018 16:24:53 +0100 Gard Spreemann <gspre...@gmail.com
>
> Upstream provided a patch that fixes this. I've updated
>
> https://mentors.debian.net/debian/pool/main/g/gudhi/gudhi_2.1.0+dfsg
-1.dsc

Thanks!

But the lintian stuff I complained about is not completly fixed, there
is even a new tag:
I: gudhi source: quilt-patch-missing-description no-external-doc-
resources.patch

Please run lintian after every build! Best, include it into pbuilder or
like! Remember "some sponsors are evil and pedantic [1] when running
lintian.

[1] https://nthykier.wordpress.com/2012/02/23/some-sponsors-are-evil-a
nd-pedantic/

Those linitian messages should be fixed before an upload:
(As at least partially already asked for in earlier reviews)

N: Starting on group gudhi/2.1.0+dfsg-1
N: Unpacking packages in group gudhi/2.1.0+dfsg-1
N: ----
N: Processing changes file gudhi (version 2.1.0+dfsg-1, arch source
amd64 all) ...
N: ----
N: Processing source package gudhi (version 2.1.0+dfsg-1, arch source)
...
I: gudhi source: binary-control-field-duplicates-source field "section"
in package gudhui
P: gudhi source: file-contains-trailing-whitespace debian/control (line
110)
P: gudhi source: package-uses-old-debhelper-compat-version 10
I: gudhi source: quilt-patch-missing-description no-external-doc-
resources.patch
W: gudhi source: unnecessary-testsuite-autopkgtest-field
N: ----
N: Processing binary package python3-gudhi (version 2.1.0+dfsg-1, arch
amd64) ...
I: python3-gudhi: spelling-error-in-binary usr/lib/python3/dist-
packages/gudhi.cpython-36m-x86_64-linux-gnu.so ment meant
I: python3-gudhi: spelling-error-in-binary usr/lib/python3/dist-
packages/gudhi.cpython-36m-x86_64-linux-gnu.so preambule preamble
I: python3-gudhi: spelling-error-in-binary usr/lib/python3/dist-
packages/gudhi.cpython-36m-x86_64-linux-gnu.so choosen chosen
N: ----
N: Processing binary package libgudhi-examples (version 2.1.0+dfsg-1,
arch all) ...
W: libgudhi-examples: lib-recommends-documentation recommends:
libgudhi-doc
N: ----
N: Processing binary package libgudhi-doc (version 2.1.0+dfsg-1, arch
all) ...
I: libgudhi-doc: possible-documentation-but-no-doc-base-registration
N: ----
N: Processing binary package libgudhi-dev (version 2.1.0+dfsg-1, arch
all) ...
N: ----
N: Processing binary package python3-gudhi-dbgsym (version 2.1.0+dfsg-
1, arch amd64) ...
N: ----
N: Processing binary package gudhui (version 2.1.0+dfsg-1, arch amd64)
...
I: gudhui: spelling-error-in-binary usr/bin/gudhui preambule preamble
P: gudhui: no-upstream-changelog
W: gudhui: binary-without-manpage usr/bin/gudhui


Please review d/copyright. I found at least one undocumented file which
is licensed Apache 2.0 and another one under LGPL3+. Neither are in
d/copyright.

Again, remove moreinfo when ready.

--

tobi

[Tobias Frost]

Argh, was not done yet when I hit send...

- d/rules:
- the override for dh_autoclean could be replaced by the file d/clean
- as you arch all packages: please build those in build-indep.
Especially doxygen has a huge dependency chain, so this will take load
off the buildds, especially those archs which are not that beefy.
(This point is optionally, but I would really appreciate it and it is
not that much effort)
- d/control
- wrap-and-sort(1) would improve readability, especially for
reviewing (this is optional)
- many versioned build dependencies are already satisfied since
oldstable. As thus those old version constraint can be removed,
especially as this is a new package.
- d/compat newest compat is now at 11

--
tobi



On Wed, 07 Mar 2018 19:32:48 +0100 Tobias Frost <to...@debian.org>
wrote:
> Control: tags -1 moreinfo
>
> On Tue, 06 Mar 2018 16:24:53 +0100 Gard Spreemann <gspreemann@gmail.c

[Tobias Frost]

Saw this mail too late, sorry for this

On Sun, Mar 11, 2018 at 12:20:52AM +0100, Gard Spreemann wrote:
> On Wednesday 7 March 2018 20:10:29 CET Tobias Frost wrote:

(...)

> > - many versioned build dependencies are already satisfied since
> > oldstable. As thus those old version constraint can be removed,
> > especially as this is a new package.
>

> Is this discouraged? If the information is correct, couldn't it
> theoretically be useful info for someone building from source on an
> old system? I'm fine with removing them if you prefer.

Yes, we try to keep them tidy. And backporting so much time back is
not supported and will unlikely work out of the box anyway... (e.g they
would have a really old debhelper)

> > - d/compat newest compat is now at 11
>

> Fixed.
>
>
> Thanks again.
>
> -- Gard
>

[Tobias Frost]

Control: tags -1 moreinfo

On Sun, Mar 11, 2018 at 06:48:10PM +0100, Gard Spreemann wrote:
> On Sunday 11 March 2018 00:18:32 CET Gard Spreemann wrote:

> > On Wednesday 7 March 2018 19:32:48 CET Tobias Frost wrote:
> > > Please review d/copyright. I found at least one undocumented file which
> > > is licensed Apache 2.0 and another one under LGPL3+. Neither are in
> > > d/copyright.
> >

> > I'm looking into this, and will get back to you.
> >
>
> I've updated the copyright information for the Apache 2.0-licensed
> file, as well as another MIT-licensed file with missing coverage.

Thanks!.

Note that some files are claimed copyright just by "20xx INRIA" and
"20xx INRIA (France)"
As copyright must be verbatim, you need to addtionalyl write this in d/copyright.
Not sure about all those other variants of INRIA: Are they different
organisattions (like a subsidiary) of just different writing of the same
one? In the first case, you need to have one stanca for every different
organisations,
(hint: license-reconcile might help here)

> It turns out that the swaths of LGPL3+-licensed files were CGAL
> patches carried by upstream to support CGAL << 4.11. Since CGAL 4.11.1
> is in buster, and there's already a lot of DFSG modifications to the
> upstream source in my package, I simply added deletion of these
> patches in the DFSG modifications and bumped the CGAL version
> requirements accordingly. I verified that the patches are only used
> when CGAL << 4.11 is detected. Is this satisfactory?

Yes, this will work.
Speaking about external sources... I see that there is also cpython in
the source. As cpython is packaged, can it be also removed via
Files-Exluded (as you said, you're repacking already, so we can reduce
the size of the source package even more)

> A new version has been uploaded to mentors:
>
> https://mentors.debian.net/debian/pool/main/g/gudhi/gudhi_2.1.0+dfsg-1.dsc


Older stuff already mentioned, but still not fixed:

- many versioned build dependencies are already satisfied since
oldstable. As thus those old version constraint can be removed,
especially as this is a new package.

Many thanks for putting doxygen generation into build-indep!

>
> Thanks again!
>
> -- Gard


Ok, otherwise package is ready... So please fix the last bits,
especially the copyright remarks, and then it will be ready.

--
tobi

[Tobias Frost]

On Mon, Mar 26, 2018 at 04:40:12PM +0200, Gard Spreemann wrote:
> Hello again,
>
> A new version has been uploaded to mentors. It contains the following
> changes since last time:
>
> - Upstream's CGAL patches were removed from the DFSG sources to
> simplify copyright information. These are not needed for CGAL >>
> 4.11, and so the build-deps were updated accordingly.
>
> - A small man page for gudhui(1) was added to the gudhui package.
>
> - Build-depend on python3-all per
> https://wiki.debian.org/Python/LibraryStyleGuide
>
> - Remove trivially satisfiable build-dep version bounds.
>
> - The short-name for GPL-3+ was changed from GPL-3.0+.
>
> - Lower the recommends deps of libgudhi-examples to suggests.
>
> - The copyright information was hopefully rectified; I'd appreciate
> it if you could have a look.

I think that will work out, though the last word will be of the FTP
masters ;-)

> - Excluded C++ source files from compression. These are in the
> examples package, and it seems reasonable to me that anyone
> installing that package wants the uncompressed example sources.
>
>
> Thanks again!

Welcome! I will upload the package ASAP, thanks for your contributions to
Debian!
>
> -- Gard
>
>

tobi