Re: Bug#1064077: RFS: qt5ct/1.8-1 -- Qt5 Configuration Utility
Soren Stoutner
Mateusz,
I would be interested in sponsoring your package. Everything looks good with with it, but before I upload it you might want to consider adding an upstream metadata file. For ideas of which fields might be useful, see the following two examples.
https://salsa.debian.org/soren/privacybrowser/-/blob/master/debian/upstream/metadata?ref_type=heads
Of course, when you add this file you will also need to bump the copyright date to include 2024.
Thanks,
Soren
On Friday, February 16, 2024 1:03:05 PM MST Mateusz Łukasik wrote:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "qt5ct":
>
> * Package name : qt5ct
> Version : 1.8-1
> Upstream contact : [fill in name and email of upstream]
> * URL :https://sourceforge.net/projects/qt5ct/
> * License : BSD-2-clause
> * Vcs :https://salsa.debian.org/qt-kde-team/extras/qt5ct
> Section : utils
>
> The source builds the following binary packages:
>
> qt5ct - Qt5 Configuration Utility
>
> To access further information about this package, please visit the following
> URL:
>
> https://mentors.debian.net/package/qt5ct/
>
> Alternatively, you can download the package with 'dget' using this command:
>
> dget -xhttps://mentors.debian.net/debian/pool/main/q/qt5ct/qt5ct_1.8-1.dsc
>
> Changes since the last upload:
>
> qt5ct (1.8-1) unstable; urgency=medium
> .
> * New upstream release.
> * Remove patches included upstream.
> * Bump Standards-Version to 4.6.2, no changes needed.
> * Update d/copyright.
> * Add d/clean for fix fails to build source after successful build.
> (Closes: #1045559)
> * d/control: Remove build depends on obsolete package.
>
> Regards,
--
Soren Stoutner
Mateusz Łukasik
Fixed in last upload.
Soren Stoutner
When compiling locally on my system, the current version of lintian (2.117.0)
found the following problems. These are not displayed on mentors.debian.net,
leading me to believe they were recently added checks.
W: qt5ct: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-gnu/
libqt5ct-common.so.1.8 [usr/lib/x86_64-linux-gnu/libqt5ct-common.so]
N:
N: Although this package is not a "-dev" package, it installs a
N: "libsomething.so" symbolic link referencing the corresponding shared
N: library. When the link doesn't include the version number, it is used by
N: the linker when other programs are built against this shared library.
N:
N: Shared libraries are supposed to place such symbolic links in their
N: respective "-dev" packages, so it is a bug to include it with the main
N: library package.
N:
N: However, if this is a small package which includes the runtime and the
N: development libraries, this is not a bug. In the latter case, please
N: override this warning.
N:
N: Please refer to Development files (Section 8.4) in the Debian Policy
N: Manual for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: libraries/shared/links
N: Renamed from: non-dev-pkg-with-shlib-symlink
N:
N:
W: qt5ct: package-name-doesnt-match-sonames libqt5ct-common1.8
N:
N: The package name of a library package should usually reflect the soname of
N: the included library. The package name can determined from the library
N: file name with the following code snippet:
N:
N: $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/
^[[:space:]]*SONAME[[:space:]]*//p' | \
N: sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/'
N:
N: Visibility: warning
N: Show-Always: no
N: Check: libraries/shared/soname
N:
N:
I: qt5ct: no-symbols-control-file usr/lib/x86_64-linux-gnu/libqt5ct-common.so.
1.8
N:
N: Although the package includes a shared library, the package does not have
N: a symbols control file.
N:
N: dpkg can use symbols files in order to generate more accurate library
N: dependencies for applications, based on the symbols from the library that
N: are actually used by the application.
N:
N: Please refer to the dpkg-gensymbols(1) manual page and
N: https://wiki.debian.org/UsingSymbolsFiles for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/shlibs
As noted in the text of the checks, there are scenarios where these do not
apply (like small packages that include the runtime and the development files),
which appears to be the case with qt5ct. Can you please help me to understand
why qt5ct is including this shared library, if there are any other packages in
Debian that are building against this library, and if you feel that any of the
lintian checks above apply? If you feel they don’t apply I would recommend
you add lintian overrides and I will be happy to upload your package.
Soren
--
Soren Stoutner
so...@debian.org