RFS: sslh (updated package)
Guillaume Delacour
I am looking for a sponsor for the new version 1.7a-3
of my package "sslh".
It builds these binary packages:
sslh - ssl/ssh multiplexer
The package appears to be lintian clean.
The upload would fix these bugs: 598591, 600181, 603608 and piuparts uninstallation issues.
These fixes are non critical for squeeze freeze as they concern 1.7a version
that support both standalone and inetd mode.
The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/s/sslh
- Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/s/sslh/sslh_1.7a-3.dsc
I would be glad if someone uploaded this package for me, thanks in advance.
Kind regards
Guillaume Delacour
Paul Tagliamonte
> dget http://mentors.debian.net/debian/pool/main/s/sslh/sslh_1.7a-3.dsc
>
Howdy,
I'm not a DD, and I can't upload, but here are some notes ( mostly nit-picks )
Might want to consider using DEP5 and DEP3
You should consider breaking up the Depends in the control to newline
after 80 chars
One lintian issue on the deb:
P: sslh: no-upstream-changelog
I'm not sure if this is just because I compiled it on Ubuntu, or if
it's actually an issue. I'll dig into it later if no one responds
telling me I'm wrong ( a bit short on time right now )
I get why you do it, but this is interesting in init :)
# Do NOT "set -e"
You can use a patch to put the file where it should be ( and not keep
it in the debdir ).
There is a lot of odd stuff going on, but it looks OK at first glance.
Like I said, I'll look more at it later unless someone else gets there
first :)
Cheers!
Paul
--
All programmers are playwrights, and all computers are lousy actors.
#define sizeof(x) rand()
:wq
--
To UNSUBSCRIBE, email to debian-ment...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org
Archive: http://lists.debian.org/AANLkTim+jt6mhCVxcc2PrN+RFrU9=9B+32MQ...@mail.gmail.com
chrysn
> The upload would fix these bugs: 598591, 600181, 603608 and piuparts uninstallation issues.
>
i can't upload it for you, but i've had a look at it.
the changes are minimal, match the description, it builds and the
translation works -- everything seems to be ok.
regards
chrysn
--
To use raw power is to make yourself infinitely vulnerable to greater powers.
-- Bene Gesserit axiom
Wesley J. Landaker
> Dear mentors,
>
> I am looking for a sponsor for the new version 1.7a-3
> of my package "sslh".
I will take care of this. Thank you for your work on this package!
--
To UNSUBSCRIBE, email to debian-ment...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org
Guillaume Delacour
> 2010/12/13 Guillaume Delacour <g...@iroqwa.org>:
> > dget http://mentors.debian.net/debian/pool/main/s/sslh/sslh_1.7a-3.dsc
> >
>
> Howdy,
>
> I'm not a DD, and I can't upload, but here are some notes ( mostly nit-picks )
And this is also a good way to help me.
>
> Might want to consider using DEP5 and DEP3
Yes, i have to consider these and changes my packages. Sslh should be
migrated in the next upstream release.
>
> You should consider breaking up the Depends in the control to newline
> after 80 chars
It's right too. I've modified that for future release of the package.
>
> One lintian issue on the deb:
>
> P: sslh: no-upstream-changelog
>
> I'm not sure if this is just because I compiled it on Ubuntu, or if
> it's actually an issue. I'll dig into it later if no one responds
> telling me I'm wrong ( a bit short on time right now )
$ lintian -IE --pedantic sslh_1.7a-3.dsc sslh_1.7a-3_amd64.changes
$ echo $?
$
Reports no problem or pedantic.
http://packages.debian.org/sid/i386/sslh/filelist confirm that the
upstream changelog is included in the -3 (and all previous releases).
>
> I get why you do it, but this is interesting in init :)
>
> # Do NOT "set -e"
>
> You can use a patch to put the file where it should be ( and not keep
> it in the debdir ).
I don't really understand this remark, debian/init is installed by
dh_installinit, whis is why i just put the initscript in debian/.
>
> There is a lot of odd stuff going on, but it looks OK at first glance.
> Like I said, I'll look more at it later unless someone else gets there
> first :)
Thanks, please note that the package have been uploaded a few hours ago
by wjl, so changes and remarks will be included in next release of the
packagE.
Guillaume Delacour
> On Mon, Dec 13, 2010 at 11:00:02PM +0100, Guillaume Delacour wrote:
> > The upload would fix these bugs: 598591, 600181, 603608 and piuparts uninstallation issues.
> >
> > I would be glad if someone uploaded this package for me, thanks in advance.
>
> i can't upload it for you, but i've had a look at it.
>
> the changes are minimal, match the description, it builds and the
> translation works -- everything seems to be ok.
Thanks for your review, the package have been uploaded.
>
> regards
> chrysn
>