info
Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#1017596: openrct2: FTBFS with warnings as errors
0 views
Skip to first unread message
Timo Röhling
Aug 18, 2022, 4:10:04 AM8/18/22
to
Source: openrct2
Version: 0.4.1+ds-1
Severity: serious
Tags: ftbfs
Dear maintainer,
while test building for the transition of benchmark, I noticed that
your package fails to build, presumably because GCC-12 added new
warnings.
Relevant excerpt from the build log:
In file included from /usr/include/c++/12/ios:43,
from /usr/include/c++/12/istream:38,
from /usr/include/c++/12/fstream:38,
from /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:11:
In member function 'std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::egptr() const [with _CharT = char; _Traits = std::char_traits<char>]',
inlined from 'std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/streambuf:324:49,
inlined from 'std::istreambuf_iterator<_CharT, _Traits>& std::istreambuf_iterator<_CharT, _Traits>::operator++() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/bits/streambuf_iterator.h:172:17,
inlined from 'void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_construct(_InIterator, _InIterator, std::input_iterator_tag) [with _InIterator = std::istreambuf_iterator<char, std::char_traits<char> >; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.tcc:178:6,
inlined from 'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::basic_string(_InputIterator, _InputIterator, const _Alloc&) [with _InputIterator = std::istreambuf_iterator<char, std::char_traits<char> >; <template-parameter-2-2> = void; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.h:756:16,
inlined from 'const std::string ChangelogWindow::GetChangelogText()' at /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:75:98:
/usr/include/c++/12/streambuf:493:30: error: potential null pointer dereference [-Werror=null-dereference]
493 | egptr() const { return _M_in_end; }
| ^~~~~~~~~
In member function 'std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::gptr() const [with _CharT = char; _Traits = std::char_traits<char>]',
inlined from 'std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/streambuf:324:33,
inlined from 'std::istreambuf_iterator<_CharT, _Traits>& std::istreambuf_iterator<_CharT, _Traits>::operator++() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/bits/streambuf_iterator.h:172:17,
inlined from 'void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_construct(_InIterator, _InIterator, std::input_iterator_tag) [with _InIterator = std::istreambuf_iterator<char, std::char_traits<char> >; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.tcc:178:6,
inlined from 'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::basic_string(_InputIterator, _InputIterator, const _Alloc&) [with _InputIterator = std::istreambuf_iterator<char, std::char_traits<char> >; <template-parameter-2-2> = void; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.h:756:16,
inlined from 'const std::string ChangelogWindow::GetChangelogText()' at /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:75:98:
/usr/include/c++/12/streambuf:490:30: error: potential null pointer dereference [-Werror=null-dereference]
490 | gptr() const { return _M_in_cur; }
| ^~~~~~~~~
In member function 'std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::gptr() const [with _CharT = char; _Traits = std::char_traits<char>]',
inlined from 'std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/streambuf:324:33,
inlined from 'std::istreambuf_iterator<_CharT, _Traits>& std::istreambuf_iterator<_CharT, _Traits>::operator++() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/bits/streambuf_iterator.h:172:17,
inlined from 'void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_construct(_InIterator, _InIterator, std::input_iterator_tag) [with _InIterator = std::istreambuf_iterator<char, std::char_traits<char> >; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.tcc:205:6,
inlined from 'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::basic_string(_InputIterator, _InputIterator, const _Alloc&) [with _InputIterator = std::istreambuf_iterator<char, std::char_traits<char> >; <template-parameter-2-2> = void; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.h:756:16,
inlined from 'const std::string ChangelogWindow::GetChangelogText()' at /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:75:98:
/usr/include/c++/12/streambuf:490:30: error: potential null pointer dereference [-Werror=null-dereference]
490 | gptr() const { return _M_in_cur; }
| ^~~~~~~~~
In member function 'std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::egptr() const [with _CharT = char; _Traits = std::char_traits<char>]',
inlined from 'std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/streambuf:324:49,
inlined from 'std::istreambuf_iterator<_CharT, _Traits>& std::istreambuf_iterator<_CharT, _Traits>::operator++() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/bits/streambuf_iterator.h:172:17,
inlined from 'void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_construct(_InIterator, _InIterator, std::input_iterator_tag) [with _InIterator = std::istreambuf_iterator<char, std::char_traits<char> >; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.tcc:205:6,
inlined from 'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::basic_string(_InputIterator, _InputIterator, const _Alloc&) [with _InputIterator = std::istreambuf_iterator<char, std::char_traits<char> >; <template-parameter-2-2> = void; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.h:756:16,
inlined from 'const std::string ChangelogWindow::GetChangelogText()' at /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:75:98:
/usr/include/c++/12/streambuf:493:30: error: potential null pointer dereference [-Werror=null-dereference]
493 | egptr() const { return _M_in_end; }
| ^~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [CMakeFiles/openrct2.dir/build.make:807: CMakeFiles/openrct2.dir/src/openrct2-ui/windows/Changelog.cpp.o] Error 1
Cheers
Timo
--
⢀⣴⠾⠻⢶⣦⠀ ╭────────────────────────────────────────────────────╮
⣾⠁⢠⠒⠀⣿⡁ │ Timo Röhling │
⢿⡄⠘⠷⠚⠋⠀ │ 9B03 EBB9 8300 DF97 C2B1 23BF CC8C 6BDD 1403 F4CA │
⠈⠳⣄⠀⠀⠀⠀ ╰────────────────────────────────────────────────────╯
Version: 0.4.1+ds-1
Severity: serious
Tags: ftbfs
Dear maintainer,
while test building for the transition of benchmark, I noticed that
your package fails to build, presumably because GCC-12 added new
warnings.
Relevant excerpt from the build log:
In file included from /usr/include/c++/12/ios:43,
from /usr/include/c++/12/istream:38,
from /usr/include/c++/12/fstream:38,
from /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:11:
In member function 'std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::egptr() const [with _CharT = char; _Traits = std::char_traits<char>]',
inlined from 'std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/streambuf:324:49,
inlined from 'std::istreambuf_iterator<_CharT, _Traits>& std::istreambuf_iterator<_CharT, _Traits>::operator++() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/bits/streambuf_iterator.h:172:17,
inlined from 'void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_construct(_InIterator, _InIterator, std::input_iterator_tag) [with _InIterator = std::istreambuf_iterator<char, std::char_traits<char> >; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.tcc:178:6,
inlined from 'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::basic_string(_InputIterator, _InputIterator, const _Alloc&) [with _InputIterator = std::istreambuf_iterator<char, std::char_traits<char> >; <template-parameter-2-2> = void; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.h:756:16,
inlined from 'const std::string ChangelogWindow::GetChangelogText()' at /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:75:98:
/usr/include/c++/12/streambuf:493:30: error: potential null pointer dereference [-Werror=null-dereference]
493 | egptr() const { return _M_in_end; }
| ^~~~~~~~~
In member function 'std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::gptr() const [with _CharT = char; _Traits = std::char_traits<char>]',
inlined from 'std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/streambuf:324:33,
inlined from 'std::istreambuf_iterator<_CharT, _Traits>& std::istreambuf_iterator<_CharT, _Traits>::operator++() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/bits/streambuf_iterator.h:172:17,
inlined from 'void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_construct(_InIterator, _InIterator, std::input_iterator_tag) [with _InIterator = std::istreambuf_iterator<char, std::char_traits<char> >; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.tcc:178:6,
inlined from 'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::basic_string(_InputIterator, _InputIterator, const _Alloc&) [with _InputIterator = std::istreambuf_iterator<char, std::char_traits<char> >; <template-parameter-2-2> = void; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.h:756:16,
inlined from 'const std::string ChangelogWindow::GetChangelogText()' at /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:75:98:
/usr/include/c++/12/streambuf:490:30: error: potential null pointer dereference [-Werror=null-dereference]
490 | gptr() const { return _M_in_cur; }
| ^~~~~~~~~
In member function 'std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::gptr() const [with _CharT = char; _Traits = std::char_traits<char>]',
inlined from 'std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/streambuf:324:33,
inlined from 'std::istreambuf_iterator<_CharT, _Traits>& std::istreambuf_iterator<_CharT, _Traits>::operator++() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/bits/streambuf_iterator.h:172:17,
inlined from 'void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_construct(_InIterator, _InIterator, std::input_iterator_tag) [with _InIterator = std::istreambuf_iterator<char, std::char_traits<char> >; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.tcc:205:6,
inlined from 'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::basic_string(_InputIterator, _InputIterator, const _Alloc&) [with _InputIterator = std::istreambuf_iterator<char, std::char_traits<char> >; <template-parameter-2-2> = void; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.h:756:16,
inlined from 'const std::string ChangelogWindow::GetChangelogText()' at /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:75:98:
/usr/include/c++/12/streambuf:490:30: error: potential null pointer dereference [-Werror=null-dereference]
490 | gptr() const { return _M_in_cur; }
| ^~~~~~~~~
In member function 'std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::egptr() const [with _CharT = char; _Traits = std::char_traits<char>]',
inlined from 'std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/streambuf:324:49,
inlined from 'std::istreambuf_iterator<_CharT, _Traits>& std::istreambuf_iterator<_CharT, _Traits>::operator++() [with _CharT = char; _Traits = std::char_traits<char>]' at /usr/include/c++/12/bits/streambuf_iterator.h:172:17,
inlined from 'void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_construct(_InIterator, _InIterator, std::input_iterator_tag) [with _InIterator = std::istreambuf_iterator<char, std::char_traits<char> >; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.tcc:205:6,
inlined from 'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::basic_string(_InputIterator, _InputIterator, const _Alloc&) [with _InputIterator = std::istreambuf_iterator<char, std::char_traits<char> >; <template-parameter-2-2> = void; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]' at /usr/include/c++/12/bits/basic_string.h:756:16,
inlined from 'const std::string ChangelogWindow::GetChangelogText()' at /build/openrct2-0.4.1+ds/src/openrct2-ui/windows/Changelog.cpp:75:98:
/usr/include/c++/12/streambuf:493:30: error: potential null pointer dereference [-Werror=null-dereference]
493 | egptr() const { return _M_in_end; }
| ^~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [CMakeFiles/openrct2.dir/build.make:807: CMakeFiles/openrct2.dir/src/openrct2-ui/windows/Changelog.cpp.o] Error 1
Cheers
Timo
--
⢀⣴⠾⠻⢶⣦⠀ ╭────────────────────────────────────────────────────╮
⣾⠁⢠⠒⠀⣿⡁ │ Timo Röhling │
⢿⡄⠘⠷⠚⠋⠀ │ 9B03 EBB9 8300 DF97 C2B1 23BF CC8C 6BDD 1403 F4CA │
⠈⠳⣄⠀⠀⠀⠀ ╰────────────────────────────────────────────────────╯
Mathias Gibbens
Aug 18, 2022, 6:50:03 PM8/18/22
to
Control: tags -1 + confirmed
It looks like this is triggering a bug in g++ 12 that's been reported
upstream with a simple test case:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105580. For now, I'm
inclined to suppress -Wnull-dereference for the affected source file,
since I know that there is in fact not a null dereference occurring in
the code.
Mathias
It looks like this is triggering a bug in g++ 12 that's been reported
upstream with a simple test case:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105580. For now, I'm
inclined to suppress -Wnull-dereference for the affected source file,
since I know that there is in fact not a null dereference occurring in
the code.
Mathias
Debian Bug Tracking System
Aug 18, 2022, 6:50:03 PM8/18/22
to
Processing control commands:
> tags -1 + confirmed
Bug #1017596 [src:openrct2] openrct2: FTBFS with warnings as errors
Added tag(s) confirmed.
--
1017596: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017596
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
> tags -1 + confirmed
Bug #1017596 [src:openrct2] openrct2: FTBFS with warnings as errors
Added tag(s) confirmed.
--
1017596: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017596
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Debian Bug Tracking System
Aug 25, 2022, 6:10:04 PM8/25/22
to
Your message dated Thu, 25 Aug 2022 22:05:00 +0000
with message-id <E1oRKyC-...@fasolo.debian.org>
and subject line Bug#1017596: fixed in openrct2 0.4.1+ds-2
has caused the Debian Bug report #1017596,
regarding openrct2: FTBFS with warnings as errors
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
with message-id <E1oRKyC-...@fasolo.debian.org>
and subject line Bug#1017596: fixed in openrct2 0.4.1+ds-2
has caused the Debian Bug report #1017596,
regarding openrct2: FTBFS with warnings as errors
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
0 new messages