Bug#1060898: apfs-dkms: fails to build module: super.c:17:10: fatal error: version.h: No such file or directory

[Gürkan Myczko]

Hi Andreas,

> attached you can find an overhaul of the package installation that also
> fixes the missing version.h
>
> Having the Debian revision included in the dkms module version is very
> unusual, now this only uses the upstream version.

Looks good except it didn't install/build for me, maybe I did something
wrong...

> The Vcs-* URLs in the package point to an empty repository ...
> otherwise
> you could have gotten a MR with a sequence of commits.

So sorry, moved to bananas team, but never filled it, now it's there and
ready.
Feel free to go ahead with a team upload...

Best,
Alex

> Andreas

[Andreas Beckmann]

On 19/02/2024 19.34, Gürkan Myczko wrote:
> So sorry, moved to bananas team, but never filled it, now it's there and
> ready.
> Feel free to go ahead with a team upload...

Done ;-)

I've added two more changes to fix/skip building the module for older
kernels, maybe these patches should be sent upstream.

* Fix module build for Linux 4.18.13..4.19~ since discard_new_inode()
was backported.
* Set BUILD_EXCLUSIVE_KERNEL_MIN="4.13" for kmemdup_nul() usage.

You can find the updated master branch and a signed tag in
https://salsa.debian.org/anbe/linux-apfs-rw.git

(Not creating a merge request since AFAIK that cannot transfer the tag.)

I'd recommend enabling the salsa pipeline for the package.
In case you aren't used to that:
In the project page in salsa
under Settings -> CI/CD -> General pipelines
set "CI/CD configuration file" to
recipes/debian.yml@salsa-ci-team/pipeline
(i.e. it fetches the pipeline definitions from another repository)
and salsa will automatically build and test the package the next time
you push the repository with results similar to
https://salsa.debian.org/anbe/linux-apfs-rw/-/pipelines/642925

Andreas

PS: I do have an amd64 chroot with most Debian kernel header packages
going back to 2.6.32 installed that I use for testing dkms and dkms
modules to the extreme ;-)