Bug#993806: kodi: No audio on DVD playback, AC3 Support

[Aaron]

Package: kodi
Version: 2:19.1+dfsg2-2
Severity: important
X-Debbugs-Cc: ukbe...@protonmail.com

Dear Maintainer,


1. Installed libdvd-pkg and ran sudo dpkg-reconfigure libdvd-pkg.
2. Mounted DVD in KDE and open DVD in kodi.
3. Noticed no audio is playing.
4. Press "o" during playback and see that Audio stream is unknown. (AC3 decoded)


-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-8-amd64 (SMP w/4 CPU threads)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages kodi depends on:
ii kodi-bin 2:19.1+dfsg2-2
ii kodi-data 2:19.1+dfsg2-2

Versions of packages kodi recommends:
ii kodi-repository-kodi [kodi-repository] 2:19.1+dfsg2-2
ii kodi-visualization-spectrum 19.0.0+ds1-1

kodi suggests no packages.

-- no debconf information

[Aaron]

I notice -DENABLE_INTERNAL_FFMPEG=OFF \ in rules.

Would switching to -DENABLE_INTERNAL_FFMPEG=ON fix this?

Arch has this flag on and has working audio for DVDs.

Aaron.

Sent with ProtonMail Secure Email.

[Mattia Rizzolo]

On Mon, Sep 06, 2021 at 07:13:31PM +0000, Aaron wrote:
> I notice -DENABLE_INTERNAL_FFMPEG=OFF \ in rules.
> Would switching to -DENABLE_INTERNAL_FFMPEG=ON fix this?

Regardless of whether turning that switch on would fix the bug, that's
not considered as compliant in Debian, where we strive *very* hard to
avoid using internal copies of shared libraries.

--
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
More about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-

[Markus Koller]

This is probably related to the ffmpeg 4.4 update, which in my case
broke AC3 transcoding for AAC audio. Downgrading to 4.3 fixed it for
now.

Kodi master has some changes to fix this, but 19.1 doesn't include
them yet: https://github.com/xbmc/xbmc/pull/19558

Could this be added as a patch in Debian?

Some related discussions:
- https://forum.kodi.tv/showthread.php?tid=362843
- https://bugzilla.rpmfusion.org/show_bug.cgi?id=6000
- https://www.deb-multimedia.org/lurker/message/20210715.125358.efbe51b3.en.html

Thanks,
Markus

[Torsten Crass]

Hi there,

is this related to Kodi not finding *any* audio streams on DVDs (at
least not on the few I tried today after quite a long break), as
described here: https://forum.kodi.tv/showthread.php?tid=359403?

> Yes, it is possible to add that patch for bookworm/sid.

Any chance this gets added also in bullseye any time soon?

I daresay that DVD playback is a core function of any media player
software, and jessie's Kodi already had quite some issues in that
respect. I'd really appreciate not to be forced again to fall back to
some third-party repos to keep our Debian-based HTPC running -- family's
already breathing down my neck... ;)

Cheers --

Torsten

[Torsten Crass]

Hi Vasyl,

> If ffmpeg downgrade solves the issue for you, unlikely it is a Kodi problem.

just realized that my ffmpeg is still at 4.3, as provided by bullseye --
so 4.4 seems not to be the issue here.

Perhaps I should open an entirely new bug report for the "Kodi not
detecting any audio streams on DVD playback" issue?

Cheers --

Torsten

[Torsten Crass]

Hi Vasyl,

> Can you please file an issue on https://github.com/xbmc/xbmc/issues
> <https://github.com/xbmc/xbmc/issues> and attach Kodi debug log with
> FFmpeg debug category enabled?

done: https://github.com/xbmc/xbmc/issues/20537

> Our members will check it and try providing a fix.

Thanks for all your efforts!

Cheers --

Torsten

[Torsten Crass]

Happy new year, everyone!

I was just wondering if there's any progress regarding DVD audio
playback on Debian's Kodi version?

Cheers --

Torsten

[Torsten Crass]

> I have nearly completed the recovery from COVID

Oh my goodness! All the best for your recovery! Sincerely hope you won't
experience long COVID syndrome! So...

> and will try solving the DVD issue among the others.

...take it slowly, will you?

Cheers --

Torsten

--
------------------------------------------------------------
Dr. rer. nat. Torsten Crass
Biochemiker, Bioinformatiker,
Software-Entwickler
https://www.aldebaran.de
https://www.tcits.de

Breite Lade 20
31275 Lehrte
Tel. 05132/8219177
https://www.tcrass.de

[Alban Browaeys]

On Wed, 8 Sep 2021 15:30:46 +0200 Markus Koller <markus...@gmx.ch>
wrote:

> This is probably related to the ffmpeg 4.4 update, which in my case
> broke AC3 transcoding for AAC audio. Downgrading to 4.3 fixed it for
> now.

How did you do AC3 to AAC transcoding (playing DVD with kodi 19?).

Sadly you did not provide the ffmpeg debian version you reverted to.
Because I with current bullseye ffmpeg 7:4.3.4-0+deb11u1 dvd playback
does not work in debian kodi 19 2:19.4+dfsg2-2~bpo11+1.

From https://forum.kodi.tv/showthread.php?tid=359403 it seems DVD audio
debian/ubuntu in kodi has been borken since 18 Leia (or maybe it was an
ffmpeg upgrade at around that time).

Mind that upstream kodi ships ffmpeg 4.3.2 so maybe ffmpeg version
above that one has a regression (since fixed in ffmpeg 5.1 because
debian kodi 20 with debian ffmpeg 5.1 has DVD audio working).
So maybe it was this debian ffmpeg 4.3.2 that you reverted to back
then, hard to tell.

What would help is knowing if buster with kodi 19 from buster-backports
also suffers the missing audio streams in DVD playback.
Because the streams are not only not playbacked but even not detected
(the audio settings when a dvd is playing back has no stream).

>
> Kodi master has some changes to fix this, but 19.1 doesn't include
> them yet: https://github.com/xbmc/xbmc/pull/19558
>
> Could this be added as a patch in Debian?

I made a quick port of this patchset but saw no improvement. But as I
do not know your use case maybe it would help with yours.
I will not send the patchset without an even very rough test case to
show it has an effect (this is ment for stable as testing already ships
kodi 20 with ffmpeg 5.1 which already has this patchset).
Maybe from https://forum.kodi.tv/showthread.php?tid=362843 it means
playing a file with AC3 (E-AC3 track ?) in it with kodi setting "AC3 /
DTS passthrough enabled" with pulseaudio as a backend (maybe pipewire
supports passwthrough nowadays, hard to tell).
I only have a stereo setup, I do not know yet if I am able to test.

I even doubt this patchset could get into stable as it is not a
security issue, merely a regression bug.


Mind that ffmpeg 4.4 is not available in a debian release anymore.
Testing ships ffmpeg 5.1.

> Some related discussions:
> - https://forum.kodi.tv/showthread.php?tid=362843
> - https://bugzilla.rpmfusion.org/show_bug.cgi?id=6000
> -
https://www.deb-multimedia.org/lurker/message/20210715.125358.efbe51b3.en.html
>
> Thanks,
> Markus
>

So thre may be two bugs, the bug the initial report reported here (that
kodi 19 has no audio stream, and the one that on a plain file with AC3
audio the playback is broken. We might need both fixed to have DVD
audio playback.
But this bug report one is firstly about the dvd audio no stream.



Kind regards,
Alban

[Markus Koller]

Hey Alban,

I ended up switching to the Flatpak version of Kodi to avoid these issues, so unfortunately I can't easily test (especially since I'm also using sid, which I see is on an alpha version of Kodi 20 now).

> How did you do AC3 to AAC transcoding (playing DVD with kodi 19?).

It was the other way around, transcoding from AAC to AC3.
You can achieve that by disabling AAC passthrough for Pulseaudio via pavucontrol, and enabling the AC3 transcoding setting in Kodi.

IIRC it only affected source files with AAC tracks, normal AC3 passthrough still worked.

> Mind that upstream kodi ships ffmpeg 4.3.2 so maybe ffmpeg version
> above that one has a regression (since fixed in ffmpeg 5.1 because
> debian kodi 20 with debian ffmpeg 5.1 has DVD audio working).
> So maybe it was this debian ffmpeg 4.3.2 that you reverted to back
> then, hard to tell.

I checked my dpkg logs but they don't go back far enough :(

FWIW the Flatpak version of Kodi 19.4-Matrix seems to ship with ffmpeg 4.3.4.

> (maybe pipewire supports passwthrough nowadays, hard to tell)

It actually does! But I found it to be buggy (especially with E-AC3 and DTS), so I'm staying on Pulseaudio for now.

Greetings,

Markus

[Alban Browaeys]

package kodi
clone 993806 -1
submitter -1 Markus Koller <markus...@gmx.ch>
retitle -1 kodi: no audio when AAC to AC3 transcoding
thanks

I clone the bug report to account for the fact the AAC to AC3
transcoding is a recent issue while the DVD audio missing is an older
one on Debian. So different bugs.




On Mon, 26 Sep 2022 22:48:36 +0200 Markus Koller <markus...@gmx.ch>
wrote:

[Alban Browaeys]

Summarizing the AAC to AC3 issue with stable Debian.


https://bugzilla.rpmfusion.org/show_bug.cgi?id=6000
tells that inital ffmpeg 4.4 support has to be added but is not enough.

Ine has to also add https://github.com/xbmc/xbmc/pull/20678 ffmpeg:
Set audio channel count on AVFrame #20678, kodi patch for to fix AAC to
AC3 transcoding.

I admit I am not sure I can reproduce with my setup (pipewire and only
stereo devices) to try if it is enough (or even not already fixed in
bullseye-backports).


I tried but am unable to find how to "disabling AAC passthrough for
Pulseaudio via pavucontrol" and "enabling the AC3 transcoding setting
in Kodi". Could you be more specific about the steps?

Cheers,
Alban


On Mon, 26 Sep 2022 22:48:36 +0200 Markus Koller <markus...@gmx.ch>
wrote:

[Alban Browaeys]

Summarizing the AAC to AC3 issue with stable Debian.


https://bugzilla.rpmfusion.org/show_bug.cgi?id=6000
tells that inital ffmpeg 4.4 support has to be added but is not enough.

Ine has to also add https://github.com/xbmc/xbmc/pull/20678  ffmpeg:
Set audio channel count on AVFrame #20678, kodi patch for to fix AAC to
AC3 transcoding.

I admit I am not sure I can reproduce with my setup (pipewire and only
stereo devices) to try if it is enough (or even not already fixed in
bullseye-backports).


I tried but am unable to find how to "disabling AAC passthrough for
Pulseaudio via pavucontrol" and "enabling the AC3 transcoding setting
in Kodi". Could you be more specific about the steps?

Cheers,
Alban

On Mon, 26 Sep 2022 22:48:36 +0200 Markus Koller <markus...@gmx.ch>
wrote:

[Alban Browaeys]

The upstream bug report log (before it was fixed with previously
mentionned pull request) https://github.com/xbmc/xbmc/issues/20398 AC3
transcoding fails on Kodi 20


Cheers,
Alban

[Alban Browaeys]

package kodi
fixed 1029663 2:20.0+dfsg-1
thanks

Please close this bug report per ffmpeg 4.4 is not in any Debian
release and kodi 19 which is in bullseye does not have this bug with
buslleye ffmpeg 4.3.

I mark this bug as fixed in kodi 20 as the commits to fix this bug with
ffmpeg 4.4 are in kodi 20. But even kodi 19.1 and kodi 19.4 are not
affected anymore since ffmpeg 5 has different packages then ffmpeg 4 in
Debian.

Cheers,
Alban

[Alban Browaeys]

Summarizing the AAC to AC3 issue with stable Debian.


https://bugzilla.rpmfusion.org/show_bug.cgi?id=6000
tells that inital ffmpeg 4.4 support has to be added but is not enough.

Ine has to also add https://github.com/xbmc/xbmc/pull/20678  ffmpeg:
Set audio channel count on AVFrame #20678, kodi patch for to fix AAC to
AC3 transcoding.

I admit I am not sure I can reproduce with my setup (pipewire and only
stereo devices) to try if it is enough (or even not already fixed in
bullseye-backports).


I tried but am unable to find how to "disabling AAC passthrough for
Pulseaudio via pavucontrol" and "enabling the AC3 transcoding setting
in Kodi". Could you be more specific about the steps?

Cheers,
Alban

On Mon, 26 Sep 2022 22:48:36 +0200 Markus Koller <markus...@gmx.ch>
wrote: