Bug#909142: wicd-curses: Right-arrow on first wlan errors wicd-curses.py

[Greg Masters]

Package: wicd-curses
Version: 1.7.4+tb2-6
Severity: important

Dear Maintainer,

I am working with the newest version of wicd-curses installed from .deb
manually using dpkg. I installed wicd_1.7.4+tb2-6all.deb, and wicd-curses,
python-wicd, wicd-daemon all of the same version number. The latest are
not in the repos. They supposedly fixed similar errors as in debian
bug 816597. This errors flag lines 97, 1149, 1162, 1040 in
/usr/share/wicd/wicd-curses-py.
And file /usr/share/wicd/curses/netentry_curses.py, line 503 and 544.

Last line after crash is ValueError: dbus.Boolean(True) is not in list

On invoking wicd-curses, any attempt to right-arrow on the FIRST
LISTED wireless net will crash. If the highlight bar is moved (down
arrow) to the second or third wireless net, then right-arrow brings
up the config screen as expected.

Request: Fix the right-arrow behavior to be consisitent.

Thank you

-- System Information:
Debian Release: 9.5
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: arm64 (aarch64)
Foreign Architectures: armhf

Kernel: Linux 4.14.65-sunxi64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages wicd-curses depends on:
ii python 2.7.13-2
ii python-urwid 1.3.1-2+b1
ii wicd-daemon 1.7.4+tb2-6

Versions of packages wicd-curses recommends:
ii sudo 1.8.19p1-2.1

wicd-curses suggests no packages.

Versions of packages wicd depends on:
ii wicd-daemon 1.7.4+tb2-6

Versions of packages wicd-cli depends on:
ii python 2.7.13-2
ii wicd-daemon 1.7.4+tb2-6

Versions of packages wicd-cli recommends:
ii sudo 1.8.19p1-2.1

Versions of packages wicd-gtk depends on:
ii python 2.7.13-2
pn python-glade2 <none>
pn python-gtk2 <none>
ii wicd-daemon 1.7.4+tb2-6

Versions of packages wicd-gtk recommends:
ii policykit-1 0.105-18
pn python-notify <none>

Versions of packages wicd-daemon depends on:
ii adduser 3.115
ii dbus 1.10.26-0+deb9u1
ii debconf 1.5.61
ii iputils-ping 3:20161105-1
ii isc-dhcp-client 4.3.5-3+deb9u1
ii lsb-base 9.20161125
ii psmisc 22.21-2.1+b2
ii python 2.7.13-2
ii python-dbus 1.2.4-1+b1
ii python-gobject-2 2.28.6-13
ii python-wicd 1.7.4+tb2-6
ii wireless-tools 30~pre9-12+b1
ii wpasupplicant 2:2.4-1+deb9u1

Versions of packages wicd-daemon recommends:
ii rfkill 0.5-1+b1

Versions of packages wicd-daemon suggests:
pn pm-utils <none>

Versions of packages python-wicd depends on:
ii net-tools 1.60+git20161116.90da8a0-1
ii python 2.7.13-2

Versions of packages python-wicd suggests:
ii ethtool 1:4.8-1+b1
ii iproute2 4.9.0-1+deb9u1

-- debconf information:
* wicd/users:

[Axel Beckert]

Control: tag -1 + moreinfo

Hi Greg,

Greg Masters wrote:
> Version: 1.7.4+tb2-6

JFTR: That's the version currently in unstable.

> I am working with the newest version of wicd-curses installed from .deb
> manually using dpkg. I installed wicd_1.7.4+tb2-6all.deb, and wicd-curses,
> python-wicd, wicd-daemon all of the same version number.

According to the System Information you are working on Debian Stretch.

That combination is not really supported.

> The latest are not in the repos.

They are in the unstable and testing repos.

> They supposedly fixed similar errors as in debian
> bug 816597.

Yes. That bug report was a duplicate of #814090.

> This errors flag lines 97, 1149, 1162, 1040 in
> /usr/share/wicd/wicd-curses-py.
> And file /usr/share/wicd/curses/netentry_curses.py, line 503 and 544.

Please post the full backtrace you're getting. (At least if I can't
reproduce this quickly.)

> Last line after crash is ValueError: dbus.Boolean(True) is not in list
>
> On invoking wicd-curses, any attempt to right-arrow on the FIRST
> LISTED wireless net will crash.

Do you have "always show wired network" on or off?

I usually have it on, so that case might have slipped through since it
might only happen if that setting is set to "off".

> If the highlight bar is moved (down arrow) to the second or third
> wireless net, then right-arrow brings up the config screen as
> expected.

Ok, will check if I can reproduce this issue on Debian Unstable, too.

Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE

[Greg Masters]

I have to revise this a little. It appears my report about the bug in
relation to the first wireless net was wrong. It happens when
right-arrow any net **with** a changed config, like the addition of a
wpa passphrase. In my last post the net with the changed config file
contained the passphrase. BTW i deleted all configs (*.conf) in
/etc/wicd and started over, with no change.

The (P) prefs option to always show wirred nets is in unselected.

Here is the trace as requested:

Traceback (most recent call last):
File "/usr/share/wicd/curses/wicd-curses.py", line 1149, in call_update_ui
self.update_ui(True)
File "/usr/share/wicd/curses/wicd-curses.py", line 97, in wrapper
return func(*args, **kargs)
File "/usr/share/wicd/curses/wicd-curses.py", line 1162, in update_ui
self.handle_keys(input_data)
File "/usr/share/wicd/curses/wicd-curses.py", line 1040, in handle_keys
self.diag = WirelessSettingsDialog(pos, self.frame)
File "/usr/share/wicd/curses/netentry_curses.py", line 503, in __init__
self.set_values()
File "/usr/share/wicd/curses/netentry_curses.py", line 544, in set_values
wireless.GetWirelessProperty(networkID, 'bitrate')

ValueError: dbus.Boolean(True) is not in list

root@orangepizeroplus:~#

[Axel Beckert]

Control: tag -1 - moreinfo

Hi Greg,

Greg Masters wrote:

> I have to revise this a little. It appears my report about the bug in
> relation to the first wireless net was wrong. It happens when
> right-arrow any net **with** a changed config, like the addition of a
> wpa passphrase. In my last post the net with the changed config file
> contained the passphrase. BTW i deleted all configs (*.conf) in
> /etc/wicd and started over, with no change.
>
> The (P) prefs option to always show wirred nets is in unselected.
>
> Here is the trace as requested:

Thanks for the additional details!

[Greg Masters]

Hello, I forgot to say thank you. Your fast response was unexpected!

To add: ipv6 is disabled (sysctl)
and network-manager is disabled as a service (systemd) and is not running

If that makes any difference

[Harald Geyer]

Package: wicd-curses
Version: 1.7.4+tb2-6
Followup-For: Bug #909142

Dear Maintainer,

I ran into this issue too. (The same backtrace)

I'm not sure at which exact step caused the problem, but what I did
was:
1) Try to connect to an encrypted (WPA2) network - the only network
listed, ie the first one
2) Notice that wicd doesn't prompt me for the passphrase.
3) Entering the config screen with right arrow and setting the
passphrase
4) Trying to connect again
5) Turning the maschine off (got distracted)
6) Realize that I actually used the wrong passphrase
7) Turning the maschine on again
8) start wicd-curses
9) Trying to enter the setting screen again -> crash

In this state the crash was reproducible across reboots whenever I
tried
to enter the setting screen.

To fix this issue (for now) I did:
sudo service wicd stop
sudo rm /etc/wicd/wireless-settings.conf
sudo rm /var/lib/wicd/configurations/${offending network}
sudo service wicd start

It now works for me. Since the configuration files belong to the daemon
rather then the UI my best guess is that misconfiguration of encrypted
networks puts the daemon into some odd state where it sends garbage to
the UI, which the UI can't handle.

HTH,
Harald

-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: arm64 (aarch64)

Kernel: Linux 4.18.0-3-arm64 (SMP w/4 CPU cores)
Locale: LANG=de_AT.UTF-8, LC_CTYPE=de_AT.UTF-8 (charmap=UTF-8),
LANGUAGE=de_AT.UTF-8 (charmap=UTF-8)

Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

LSM: AppArmor: enabled

Versions of packages wicd-curses depends on:

ii python 2.7.15-3
ii python-urwid 2.0.1-2+b1

ii wicd-daemon 1.7.4+tb2-6

Versions of packages wicd-curses recommends:

ii sudo 1.8.26-2

wicd-curses suggests no packages.

Versions of packages wicd-daemon depends on:

ii adduser 3.118
ii dbus 1.12.10-1
ii debconf 1.5.69
ii iputils-ping 3:20180629-2
ii isc-dhcp-client 4.3.5-4+b1
ii lsb-base 10.2018112800
ii psmisc 23.2-1
ii python 2.7.15-3
ii python-dbus 1.2.8-2+b1
ii python-gobject-2 2.28.6-13+b1
ii python-wicd 1.7.4+tb2-6
ii udhcpc 1:1.27.2-3
ii wireless-tools 30~pre9-13
ii wpasupplicant 2:2.6-18

Versions of packages wicd-daemon recommends:

ii rfkill 2.32.1-0.1

Versions of packages wicd-daemon suggests:
pn pm-utils <none>

Versions of packages python-wicd depends on:

ii net-tools 1.60+git20180626.aebd88e-1
ii python 2.7.15-3

Versions of packages python-wicd suggests:

pn ethtool <none>
ii iproute2 4.18.0-2

-- debconf information:
* wicd/users: harald, olimex


--
If you want to support my work:
see http://friends.ccbib.org/harald/supporting/
or donate via peercoin to P98LRdhit3gZbHDBe7ta5jtXrMJUms4p7w
or CLAM xASPBtezLNqj4cUe8MT5nZjthRSEjrRQXN

[Sebastian Rasmussen]

Hi!

After some debugging and searching I ended up seeing
https://bugs.launchpad.net/wicd/+bug/1432423
where a proposed fix was provided as shown below.

I tested this patch and this fixed the issue for me.
If possible please apply this and pass it on to upstream
to be included in future releases. :)

/ Sebastian

--- netentry_curses.py 2019-07-22 13:59:13.750447860 +0200
+++ /tmp/netentry_curses.py 2015-04-14 17:49:43.000000000 +0200
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/python2
"""
netentry_curses -- everyone's favorite networks settings dialogs... in text
form!
@@ -538,12 +538,16 @@ class WirelessSettingsDialog(AdvancedSet
self.bitrates = wireless.GetAvailableBitrates()
self.bitrates.append('auto')
self.bitrate_combo.set_list(self.bitrates)
- if wireless.GetWirelessProperty(networkID, 'bitrate'):
+
+ # bitrate property is sometimes None
+ chosen_bitrate = wireless.GetWirelessProperty(networkID, 'bitrate')
+ if chosen_bitrate not in self.bitrates:
+ chosen_bitrate = 'auto'
+
self.bitrate_combo.set_focus(
- self.bitrates.index(
- wireless.GetWirelessProperty(networkID, 'bitrate')
- )
+ self.bitrates.index(chosen_bitrate)
)
+
self.allow_lower_bitrates_chkbox.set_state(
to_bool(self.format_entry(networkID, 'allow_lower_bitrates'))
)