Bug#994873: libdrm-dev: mssing dependency on valgrind

[Norbert Preining]

Package: libdrm-dev
Version: 2.4.107-3
Severity: important

Hi

it seems a recent update to libdrm-dev added
Requires.private: valgrind
to the libdrm.pc file, without adding valgrind to the dependencies of
libdrm-dev.

Thus, installing libdrm-dev does not result in it being recognized by
pkg-config due to missing valgrind on autobuilders.

Thanks

Norbert



-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.13.19+futex+ (SMP w/8 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libdrm-dev depends on:
ii libdrm-amdgpu1 2.4.107-3
ii libdrm-intel1 2.4.107-3
ii libdrm-nouveau2 2.4.107-3
ii libdrm-radeon1 2.4.107-3
ii libdrm2 2.4.107-3

libdrm-dev recommends no packages.

libdrm-dev suggests no packages.

-- no debconf information

[Aurelien Jarno]

Hi,

On 2021-09-23 02:48, Debian FTP Masters wrote:
> Source: libdrm
> Source-Version: 2.4.107-5
> Done: Timo Aaltonen <tjaa...@debian.org>
>
> We believe that the bug you reported is fixed in the latest version of
> libdrm, which is due to be installed in the Debian FTP archive.
>
> A summary of the changes between this version and the previous one is
> attached.
>
> Thank you for reporting the bug, which will now be closed. If you
> have further comments please address them to 994...@bugs.debian.org,
> and the maintainer will reopen the bug report if appropriate.
>
> Debian distribution maintenance software
> pp.
> Timo Aaltonen <tjaa...@debian.org> (supplier of updated libdrm package)
>
> (This message was generated automatically at their request; if you
> believe that there is a problem with it please contact the archive
> administrators by mailing ftpm...@ftp-master.debian.org)
>
>
> We believe that the bug you reported is fixed in the latest version of
> libdrm, which is due to be installed in the Debian FTP archive.
>
> A summary of the changes between this version and the previous one is
> attached.
>
> Thank you for reporting the bug, which will now be closed. If you
> have further comments please address them to 994...@bugs.debian.org,
> and the maintainer will reopen the bug report if appropriate.
>
> Debian distribution maintenance software
> pp.
> Timo Aaltonen <tjaa...@debian.org> (supplier of updated libdrm package)
>
> (This message was generated automatically at their request; if you
> believe that there is a problem with it please contact the archive
> administrators by mailing ftpm...@ftp-master.debian.org)
>
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Format: 1.8
> Date: Thu, 23 Sep 2021 05:26:53 +0300
> Source: libdrm
> Built-For-Profiles: noudeb
> Architecture: source
> Version: 2.4.107-5
> Distribution: unstable
> Urgency: medium
> Maintainer: Debian X Strike Force <debi...@lists.debian.org>
> Changed-By: Timo Aaltonen <tjaa...@debian.org>
> Closes: 994873
> Changes:
> libdrm (2.4.107-5) unstable; urgency=medium
> .
> * control: Add valgrind to libdrm-dev Depends. (Closes: #994873)

This doesn't look correct. valgrind is not available on all
architectures, and especially armel for the release architectures.

You need to use the same architecture list for valgrind in both the
Build-Depends and the Depends lines.

Regards,
Aurelien

--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aure...@aurel32.net http://www.aurel32.net

[Andre Heider]

This is not multiarch compatible, libdrm-dev can't be coinstalled with
libdrm-dev:i386 now.

[Andre Heider]

I did some more digging and it looks like valgrind can just be disabled:
https://salsa.debian.org/xorg-team/lib/libdrm/-/blob/debian-unstable/meson.build#L256

And AFAICT it's only used for debugging purposes ("ioctl annotations"),
on intel and freedreno:
$ git grep HAVE_VALGRIND
freedreno/freedreno_priv.h:#if HAVE_VALGRIND
intel/intel_bufmgr_gem.c:#if HAVE_VALGRIND
intel/intel_bufmgr_gem.c:#if HAVE_VALGRIND
intel/intel_bufmgr_gem.c:#if HAVE_VALGRIND

For comparison:

arch disables it:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=libdrm-git#n43

suse too (if I read that "%if 0%{?with_valgrind_support:1}" correctly):
https://build.opensuse.org/package/view_file/openSUSE:Factory/libdrm/libdrm.spec?expand=1

fedora enables it on supported arch (but has a valgrind-devel package)
https://src.fedoraproject.org/rpms/libdrm/blob/rawhide/f/libdrm.spec

I propose to:
- disable valgrind for now
- reenable it once there's a multiarch compatible valgrind-devel package
See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=731228