Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Bug#636323: notification-daemon: crashes on wrong type of 'transient' hint

1 view
Skip to first unread message

ano...@users.sourceforge.net

unread,
Sep 20, 2011, 11:00:02 AM9/20/11
to
found 636323 0.7.2-1
tags 636323 patch
thanks

This patch against 0.7.2-1 seems to fix the problem. What it does is
check the type of the incoming hint and use the appropriate
g_variant_get_* function.

It also applies the same fix for the "resident" and "action-icons"
hints.
avoid_crash_for_boolean_hints.patch

Thomas Schwinge

unread,
Dec 6, 2011, 9:50:02 AM12/6/11
to
Hi!

On Tue, 20 Sep 2011 10:50:06 -0400, ano...@users.sourceforge.net wrote:
> This patch against 0.7.2-1 seems to fix the problem.

I'm confirming the original issue, and that this patch does fix it. (I
did not verify the patch any other than blindly applying it and
rebuilding notification-daemon 0.7.3-1.)


Grüße,
Thomas

Michael Biebl

unread,
Dec 9, 2011, 12:10:03 PM12/9/11
to
Hi,
Thanks for the patch.
I guess it makes some sense to treat values != 0 as true, while skipping
double values (ie. treat them as FALSE).

I'm not sure, if we have all those different variants for int values (in
my tests I always received int32), but it certainly doesn't hurt to test
against all of them.

Lastly, as I wanted to add proper credits to the patch header and the
debian changelog, I wanted to ask if this patch is by you and if I
should add your real name (google turns up Brad Jorsch for this email
address).


Cheers,
Michael




--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

signature.asc
0 new messages