Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#654593: nginx-extras: Please add upload module
3 views
Skip to first unread message
Antti Kaihola
Jan 4, 2012, 9:40:01 AM1/4/12
to
Package: nginx-extras
Version: 1.0.5-1
Severity: wishlist
The upload and uploadprogress modules were previously requested for addition
into nginx-extras in bug #618306. The uploadprogress module was added in
version 1.0.1-1 and the bug was closed, but the request for the upload module
was not addressed.
The upload module lives at http://www.grid.net.ru/nginx/upload.en.html
and its repository is at https://github.com/vkholodkov/nginx-upload-
module/tree/2.2
The upload module is useful for dynamic sites. It handles the file transfer
completely in Nginx before passing the temporary file path to the site backend
(e.g. Rails or Django) in a POST request. This is efficient compared to keeping
a scripting language process busy receiving blocks of a large upload.
-- System Information:
Debian Release: wheezy/sid
APT prefers oneiric-updates
APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 'oneiric')
Architecture: i386 (i686)
Kernel: Linux 3.0.0-12-generic (SMP w/2 CPU cores)
Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages nginx-extras depends on:
ii libc6 2.13-20ubuntu5 Embedded GNU C Library: Shared lib
ii libgd2-xpm 2.0.36~rc1~dfsg-5.1ubuntu1 GD Graphics Library version 2
ii libgeoip1 1.4.8+dfsg-1ubuntu1 non-DNS IP-to-country resolver lib
ii liblua5.1-0 5.1.4-10 Shared library for the Lua interpr
ii libmhash2 0.9.9.9-1 Library for cryptographic hashing
ii libpcre3 8.12-3ubuntu2 Perl 5 Compatible Regular Expressi
ii libperl5.12 5.12.4-4 shared Perl library
ii libssl1.0.0 1.0.0e-2ubuntu4 SSL shared libraries
ii libxml2 2.7.8.dfsg-4 GNOME XML library
ii libxslt1.1 1.1.26-7 XSLT 1.0 processing library - runt
ii nginx-common 1.0.5-1 small, but very powerful and effic
ii perl 5.12.4-4 Larry Wall's Practical Extraction
ii perl-base [pe 5.12.4-4 minimal Perl system
ii zlib1g 1:1.2.3.4.dfsg-3ubuntu3 compression library - runtime
nginx-extras recommends no packages.
nginx-extras suggests no packages.
-- no debconf information
--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org
Version: 1.0.5-1
Severity: wishlist
The upload and uploadprogress modules were previously requested for addition
into nginx-extras in bug #618306. The uploadprogress module was added in
version 1.0.1-1 and the bug was closed, but the request for the upload module
was not addressed.
The upload module lives at http://www.grid.net.ru/nginx/upload.en.html
and its repository is at https://github.com/vkholodkov/nginx-upload-
module/tree/2.2
The upload module is useful for dynamic sites. It handles the file transfer
completely in Nginx before passing the temporary file path to the site backend
(e.g. Rails or Django) in a POST request. This is efficient compared to keeping
a scripting language process busy receiving blocks of a large upload.
-- System Information:
Debian Release: wheezy/sid
APT prefers oneiric-updates
APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 'oneiric')
Architecture: i386 (i686)
Kernel: Linux 3.0.0-12-generic (SMP w/2 CPU cores)
Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages nginx-extras depends on:
ii libc6 2.13-20ubuntu5 Embedded GNU C Library: Shared lib
ii libgd2-xpm 2.0.36~rc1~dfsg-5.1ubuntu1 GD Graphics Library version 2
ii libgeoip1 1.4.8+dfsg-1ubuntu1 non-DNS IP-to-country resolver lib
ii liblua5.1-0 5.1.4-10 Shared library for the Lua interpr
ii libmhash2 0.9.9.9-1 Library for cryptographic hashing
ii libpcre3 8.12-3ubuntu2 Perl 5 Compatible Regular Expressi
ii libperl5.12 5.12.4-4 shared Perl library
ii libssl1.0.0 1.0.0e-2ubuntu4 SSL shared libraries
ii libxml2 2.7.8.dfsg-4 GNOME XML library
ii libxslt1.1 1.1.26-7 XSLT 1.0 processing library - runt
ii nginx-common 1.0.5-1 small, but very powerful and effic
ii perl 5.12.4-4 Larry Wall's Practical Extraction
ii perl-base [pe 5.12.4-4 minimal Perl system
ii zlib1g 1:1.2.3.4.dfsg-3ubuntu3 compression library - runtime
nginx-extras recommends no packages.
nginx-extras suggests no packages.
-- no debconf information
--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org
Cyril LAVIER
Jan 4, 2012, 10:00:03 AM1/4/12
to
Hi Anti.
Thanks for submitting this bug.
As far as I understand, the demand for the upload module in the bug
#618306 was not clearly written, and I think Michael Lustfield didn't
see this request (me neither, I had to read the bug 2-3 times to finally
understand there was 2 modules requested).
So, as it's an external module (and it causes extra work for
maintainers to keep the module up to date), could tell us why you think
this module need inclusion in the debian packaging of Nginx ?
Thanks.
--
Cyril "Davromaniak" Lavier
Thanks for submitting this bug.
As far as I understand, the demand for the upload module in the bug
#618306 was not clearly written, and I think Michael Lustfield didn't
see this request (me neither, I had to read the bug 2-3 times to finally
understand there was 2 modules requested).
So, as it's an external module (and it causes extra work for
maintainers to keep the module up to date), could tell us why you think
this module need inclusion in the debian packaging of Nginx ?
Thanks.
--
Cyril "Davromaniak" Lavier
Kartik Mistry
Jan 4, 2012, 10:40:01 AM1/4/12
to
On Wed, Jan 4, 2012 at 8:13 PM, Cyril LAVIER
<cyril....@davromaniak.eu> wrote:
> As far as I understand, the demand for the upload module in the bug #618306
> was not clearly written, and I think Michael Lustfield didn't see this
> request (me neither, I had to read the bug 2-3 times to finally understand
> there was 2 modules requested).
>
> So, as it's an external module (and it causes extra work for maintainers to
> keep the module up to date), could tell us why you think this module need
> inclusion in the debian packaging of Nginx ?
nginx-extras already has upload progress module :)
<cyril....@davromaniak.eu> wrote:
> As far as I understand, the demand for the upload module in the bug #618306
> was not clearly written, and I think Michael Lustfield didn't see this
> request (me neither, I had to read the bug 2-3 times to finally understand
> there was 2 modules requested).
>
> So, as it's an external module (and it causes extra work for maintainers to
> keep the module up to date), could tell us why you think this module need
> inclusion in the debian packaging of Nginx ?
--
Kartik Mistry | IRC: kart_
{0x1f1f, kartikm}.wordpress.com
Cyril LAVIER
Jan 4, 2012, 10:50:02 AM1/4/12
to
On Wed, 4 Jan 2012 21:05:08 +0530, Kartik Mistry wrote:
> On Wed, Jan 4, 2012 at 8:13 PM, Cyril LAVIER
> <cyril....@davromaniak.eu> wrote:
>> As far as I understand, the demand for the upload module in the bug
>> #618306
>> was not clearly written, and I think Michael Lustfield didn't see
>> this
>> request (me neither, I had to read the bug 2-3 times to finally
>> understand
>> there was 2 modules requested).
>>
>> So, as it's an external module (and it causes extra work for
>> maintainers to
>> keep the module up to date), could tell us why you think this module
>> need
>> inclusion in the debian packaging of Nginx ?
>
> nginx-extras already has upload progress module :)
Yes.
> On Wed, Jan 4, 2012 at 8:13 PM, Cyril LAVIER
> <cyril....@davromaniak.eu> wrote:
>> As far as I understand, the demand for the upload module in the bug
>> #618306
>> was not clearly written, and I think Michael Lustfield didn't see
>> this
>> request (me neither, I had to read the bug 2-3 times to finally
>> understand
>> there was 2 modules requested).
>>
>> So, as it's an external module (and it causes extra work for
>> maintainers to
>> keep the module up to date), could tell us why you think this module
>> need
>> inclusion in the debian packaging of Nginx ?
>
> nginx-extras already has upload progress module :)
I had the same thought at first sight, but there's an other module
called "upload", which is the one requested here.
:)
--
Cyril "Davromaniak" Lavier
Kartik Mistry
Jan 4, 2012, 11:50:02 AM1/4/12
to
On Wed, Jan 4, 2012 at 9:08 PM, Cyril LAVIER
<cyril....@davromaniak.eu> wrote:
> I had the same thought at first sight, but there's an other module called
> "upload", which is the one requested here.
Ok. adding it with next commit.
<cyril....@davromaniak.eu> wrote:
> I had the same thought at first sight, but there's an other module called
> "upload", which is the one requested here.
Kartik Mistry
Jan 4, 2012, 12:20:03 PM1/4/12
to
On Wed, Jan 4, 2012 at 10:15 PM, Kartik Mistry <kartik...@gmail.com> wrote:
> On Wed, Jan 4, 2012 at 9:08 PM, Cyril LAVIER
> <cyril....@davromaniak.eu> wrote:
>> I had the same thought at first sight, but there's an other module called
>> "upload", which is the one requested here.
>
> Ok. adding it with next commit.
But: https://github.com/vkholodkov/nginx-upload-module/issues/26#issuecomment-3357444
> On Wed, Jan 4, 2012 at 9:08 PM, Cyril LAVIER
> <cyril....@davromaniak.eu> wrote:
>> I had the same thought at first sight, but there's an other module called
>> "upload", which is the one requested here.
>
> Ok. adding it with next commit.
so, holding off upload until upstream resolves issue.
Antti Kaihola
Jan 4, 2012, 1:30:02 PM1/4/12
to
2012/1/4 Kartik Mistry <kartik...@gmail.com>
> Ok. adding it with next commit.But: https://github.com/vkholodkov/nginx-upload-module/issues/26#issuecomment-3357444
so, holding off upload until upstream resolves issue.
Makes sense. On the surface it looks like a simple issue. Let's hope nothing nasty is hiding behind it :)
Despite their similar names, the upload and uploadprogress modules serve indeed very different purposes. Uploadprogress is for tracking conventional uploads with AJAX polling, whereas the upload module handles the entire file transfer procedure before handing the resulting uploaded file to the web application.
Thanks for accepting this proposal!
Cyril Lavier
Jan 30, 2012, 4:30:03 PM1/30/12
to
Good evening.
Apparently, upstream was doing nothing.
But I decided to go on and apply the fix I proposed. Maybe this will motivate him to apply a fix in the GIT repo.
I also took this decision because I tested the module over the last 2 weeks (with nginx 1.1.13) on an internal service in my company, no issues were reported by users, and nothing bad in the log files, so I consider the build issue was minor, and thus not affecting the overall functioning of the module.
I also answered in the issue on github.
Apparently, upstream was doing nothing.
But I decided to go on and apply the fix I proposed. Maybe this will motivate him to apply a fix in the GIT repo.
I also took this decision because I tested the module over the last 2 weeks (with nginx 1.1.13) on an internal service in my company, no issues were reported by users, and nothing bad in the log files, so I consider the build issue was minor, and thus not affecting the overall functioning of the module.
I also answered in the issue on github.
0 new messages