Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Bug#1049950: dh-python: Pybuild runs tests with tox but fails to clean up

9 views
Skip to first unread message

Arto Jantunen

unread,
Aug 17, 2023, 5:40:05 AM8/17/23
to
Package: dh-python
Version: 6.20230813
Severity: normal
Control: block 1045322 by -1

Pybuild uses tox to run the upstream test suite of the package, but
fails to clean up the created .tox directory during debian/rules clean.

--
Arto Jantunen

Stefano Rivera

unread,
Aug 25, 2023, 5:00:05 PM8/25/23
to
Control: tag -1 + moreinfo

Hi Arto (2023.08.17_11:33:51_+0200)
> Pybuild uses tox to run the upstream test suite of the package, but
> fails to clean up the created .tox directory during debian/rules clean.

It has code to do this, can you point to an example of it not happening?

https://salsa.debian.org/python-team/tools/dh-python/-/blob/a5068b6de912dee00415e3ed8af13b75ef29994c/dhpython/build/base.py#L164-172

Stefano

--
Stefano Rivera
http://tumbleweed.org.za/
+1 415 683 3272

Arto Jantunen

unread,
Aug 26, 2023, 1:30:05 AM8/26/23
to
Stefano Rivera <stef...@debian.org> writes:

> Control: tag -1 + moreinfo
>
> Hi Arto (2023.08.17_11:33:51_+0200)
>> Pybuild uses tox to run the upstream test suite of the package, but
>> fails to clean up the created .tox directory during debian/rules clean.
>
> It has code to do this, can you point to an example of it not happening?
>
> https://salsa.debian.org/python-team/tools/dh-python/-/blob/a5068b6de912dee00415e3ed8af13b75ef29994c/dhpython/build/base.py#L164-172

Bug #1045322 was filed against pytrainer, and I read the log there as
"tox directory not cleaned up". The bug is marked blocked by this bug.

Pytrainer has an essentially empty debian/rules so my immediate thought
was that the tools used (dh_python3 + pybuild) are the source of the
problem.

--
Arto Jantunen

Stefano Rivera

unread,
Aug 27, 2023, 7:00:07 AM8/27/23
to
Control: tag -1 -moreinfo

Hi Arto (2023.08.26_06:24:29_+0100)
> > It has code to do this, can you point to an example of it not happening?
> >
> > https://salsa.debian.org/python-team/tools/dh-python/-/blob/a5068b6de912dee00415e3ed8af13b75ef29994c/dhpython/build/base.py#L164-172

Aha, I figured out the obvious:

The logic that automatically configures which test runner is in use is
only run for the test step, not the clean step.
0 new messages