Bug#1004629: motion: FTBFS with ffmpeg 5.0

[Sebastian Ramacher]

Source: motion
Version: 4.3.2-1
Severity: important
X-Debbugs-Cc: sram...@debian.org
Tags: sid bookworm ftbfs
Usertags: ffmpeg5.0

motion FTBFS with ffmpeg 5.0 (available in experimental):
| gcc -DHAVE_CONFIG_H -I. -I.. -Dsysconfdir=\"/etc/motion\" -DLOCALEDIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -D_THREAD_SAFE -I/usr/include/p11-kit-1 -I/usr/include/x86_64-linux-gnu -I/usr/include/mariadb/ -I/usr/include/mariadb/ -I/usr/include/postgresql -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o webu_text.o webu_text.c
| ffmpeg.c: In function ‘ffmpeg_get_oformat’:
| ffmpeg.c:343:67: error: assignment of member ‘video_codec’ in read-only object
| 343 | if (ffmpeg->oc->oformat) ffmpeg->oc->oformat->video_codec = MY_CODEC_ID_MPEG2VIDEO;
| | ^
| ffmpeg.c:365:67: error: assignment of member ‘video_codec’ in read-only object
| 365 | if (ffmpeg->oc->oformat) ffmpeg->oc->oformat->video_codec = MY_CODEC_ID_MSMPEG4V2;
| | ^
| ffmpeg.c:376:67: error: assignment of member ‘video_codec’ in read-only object
| 376 | if (ffmpeg->oc->oformat) ffmpeg->oc->oformat->video_codec = MY_CODEC_ID_FLV1;
| | ^
| ffmpeg.c:382:67: error: assignment of member ‘video_codec’ in read-only object
| 382 | if (ffmpeg->oc->oformat) ffmpeg->oc->oformat->video_codec = MY_CODEC_ID_FFV1;
| | ^
| ffmpeg.c:393:67: error: assignment of member ‘video_codec’ in read-only object
| 393 | if (ffmpeg->oc->oformat) ffmpeg->oc->oformat->video_codec = MY_CODEC_ID_H264;
| | ^
| ffmpeg.c:399:67: error: assignment of member ‘video_codec’ in read-only object
| 399 | if (ffmpeg->oc->oformat) ffmpeg->oc->oformat->video_codec = MY_CODEC_ID_H264;
| | ^
| ffmpeg.c:405:67: error: assignment of member ‘video_codec’ in read-only object
| 405 | if (ffmpeg->oc->oformat) ffmpeg->oc->oformat->video_codec = MY_CODEC_ID_HEVC;
| | ^
| ffmpeg.c: In function ‘ffmpeg_set_codec_preferred’:
| ffmpeg.c:722:27: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
| 722 | ffmpeg->codec = avcodec_find_encoder_by_name(&ffmpeg->codec_name[codec_name_len+1]);
| | ^
| ffmpeg.c:724:54: error: assignment of member ‘video_codec’ in read-only object
| 724 | ffmpeg->oc->oformat->video_codec = ffmpeg->codec->id;
| | ^
| ffmpeg.c:733:23: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
| 733 | ffmpeg->codec = avcodec_find_encoder(ffmpeg->oc->oformat->video_codec);
| | ^
| ffmpeg.c: In function ‘ffmpeg_flush_codec’:
| ffmpeg.c:1089:13: warning: ‘av_init_packet’ is deprecated [-Wdeprecated-declarations]
| 1089 | av_init_packet(&ffmpeg->pkt);
| | ^~~~~~~~~~~~~~
| In file included from /usr/include/x86_64-linux-gnu/libavcodec/avcodec.h:45,
| from netcam_rtsp.h:21,
| from motion.h:66,
| from ffmpeg.c:25:
| /usr/include/x86_64-linux-gnu/libavcodec/packet.h:506:6: note: declared here
| 506 | void av_init_packet(AVPacket *pkt);
| | ^~~~~~~~~~~~~~
| ffmpeg.c: In function ‘ffmpeg_put_frame’:
| ffmpeg.c:1132:5: warning: ‘av_init_packet’ is deprecated [-Wdeprecated-declarations]
| 1132 | av_init_packet(&ffmpeg->pkt);
| | ^~~~~~~~~~~~~~
| In file included from /usr/include/x86_64-linux-gnu/libavcodec/avcodec.h:45,
| from netcam_rtsp.h:21,
| from motion.h:66,
| from ffmpeg.c:25:
| /usr/include/x86_64-linux-gnu/libavcodec/packet.h:506:6: note: declared here
| 506 | void av_init_packet(AVPacket *pkt);
| | ^~~~~~~~~~~~~~
| ffmpeg.c: In function ‘ffmpeg_passthru_write’:
| ffmpeg.c:1184:5: warning: ‘av_init_packet’ is deprecated [-Wdeprecated-declarations]
| 1184 | av_init_packet(&ffmpeg->pkt);
| | ^~~~~~~~~~~~~~
| In file included from /usr/include/x86_64-linux-gnu/libavcodec/avcodec.h:45,
| from netcam_rtsp.h:21,
| from motion.h:66,
| from ffmpeg.c:25:
| /usr/include/x86_64-linux-gnu/libavcodec/packet.h:506:6: note: declared here
| 506 | void av_init_packet(AVPacket *pkt);
| | ^~~~~~~~~~~~~~
| ffmpeg.c: In function ‘ffmpeg_passthru_codec’:
| ffmpeg.c:1323:42: error: assignment of member ‘video_codec’ in read-only object
| 1323 | ffmpeg->oc->oformat->video_codec = stream_in->codecpar->codec_id;
| | ^
| make[3]: *** [Makefile:477: ffmpeg.o] Error 1
| make[3]: *** Waiting for unfinished jobs....

Cheers
--
Sebastian Ramacher

[Dan Bungert]

Dear Maintainer,

I backported the work merged upstream around ffmpeg 5. Please see attached.
This was sufficient to address the FTBFS both for Sid and Ubuntu Kinetic.

-Dan

[MichaIng]

The issue has been solved upstream with motion 4.5 (probably 4.4
already). Since unstable still serves motion 4.3.2, I hope unstable and
then testing can be migrated to the latest motion release.

Bookworm first freeze starts in January, and it would be a pity to have
motion not included with next Debian release.

Since upstream developers provide own Debian packages, I can tell that
it worked well on Bookworm (with the upstream package for Bullseye),
until ffmpeg libraries got updated (dependency issue). If it helps to
get things forward, I can further test with compiling it on Bookworm
against latest ffmpeg libs on x86_64, arm64 and armhf.

Best regards,

Micha