Bug#1012616: xtrx-dkms: DKMS build fails with implicit declaration of functions
Kyle Robbertze
Version: 0.0.1+git20190320.5ae3a3e-3
Severity: important
Dear Maintainer,
Upgrading xtrx-dkms to 0.0.1+git20190320.5ae3a3e-3 fails to build due to
the following make error:
cat /var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build/make.log 100
DKMS make.log for xtrx-0.0.1+git20190320.5ae3a3e-3 for kernel 5.18.0-1-amd64 (x86_64)
Fri 10 Jun 2022 13:06:11 SAST
make: Entering directory '/usr/src/linux-headers-5.18.0-1-amd64'
CC [M] /var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build/xtrx.o
/var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build/xtrx.c: In function ‘xtrx_allocdma’:
/var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build/xtrx.c:624:33: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
624 | pbufs[i].virt = pci_alloc_consistent(d->pdev, buflen, &pbufs[i].phys);
| ^~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build/xtrx.c:624:31: warning: assignment to ‘void *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
624 | pbufs[i].virt = pci_alloc_consistent(d->pdev, buflen, &pbufs[i].phys);
| ^
/var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build/xtrx.c:628:33: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
628 | pci_free_consistent(d->pdev, buflen, pbufs[i].virt, pbufs[i].phys);
| ^~~~~~~~~~~~~~~~~~~
/var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build/xtrx.c: In function ‘xtrx_probe’:
/var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build/xtrx.c:1165:13: error: implicit declaration of function ‘pci_set_consistent_dma_mask’ [-Werror=implicit-function-declaration]
1165 | if (pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32))) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [/usr/src/linux-headers-5.18.0-1-common/scripts/Makefile.build:293: /var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build/xtrx.o] Error 1
make: *** [/usr/src/linux-headers-5.18.0-1-common/Makefile:1858: /var/lib/dkms/xtrx/0.0.1+git20190320.5ae3a3e-3/build] Error 2
make: Leaving directory '/usr/src/linux-headers-5.18.0-1-amd64'
Thanks
Kyle
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64
Kernel: Linux 5.18.0-1-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_ZA.UTF-8, LC_CTYPE=en_ZA.UTF-8 (charmap=UTF-8), LANGUAGE=en_ZA:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages xtrx-dkms depends on:
ii dkms 3.0.3-2
xtrx-dkms recommends no packages.
xtrx-dkms suggests no packages.
-- no debconf information
Witold Baryluk
Version: 0.0.1+git20190320.5ae3a3e-3
Followup-For: Bug #1012616
X-Debbugs-Cc: witold....@gmail.com
I suggest escalating this to serious issue. As is causing live-build
build failures, and kernel upgrade issues interfering with the rest of
the system.
Due to chain of Depends and Recommends, xtrx-dkms is installed, even if
not requested or needed directly by user.
For example installing gnss-sdr, gqrx-sdr, gr-osmosdr would cause
xtrx-dkms to be attempted to be installed in many cases.
I think one of the things (beyond fixing the bug in the xtrx-dkms itself),
is changing Recommends to Suggests in libxtrxll0.
I would even say that using Recommends does not follow the Debian policy.
Other option is to remove xtrx related packages from Debian. Devices are
no longer available for purchase. Website has no updates since 2017,
crowsupply had last update in 2019, and github had last update 3-4 years
ago with various Issues and PR opened but not touched for over a year. So
it looks unmaintained. The developer and company now moved to other
projects (similar to xtrx). The driver is small, and has GPL, but there
was never any attempt to upstream it into mainline Linux, so it was
doomed to be abandoned and rot. popcon shows 142 "votes". But this might
be misleading, as there is no direct way to measure how many people
actually use it. If it is installed, it will be built on kernel upgrade,
so "accessed", doesn't mean it will be loaded and used. popcon graphs
also show sharp drop in last month, where people probably started
realising it breaks the kernel upgrade while doing standard apt upgrade.
Regards,
Witold
-- System Information:
Debian Release: bookworm/sid
APT policy: (500, 'testing-debug'), (500, 'testing')
Foreign Architectures: i386
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash