Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Bug#1015213: make fails to find existing upstream vcs tag

23 views
Skip to first unread message

Ryan Kavanagh

unread,
Jul 17, 2022, 3:30:05 PM7/17/22
to
Package: dh-make-golang
Version: 0.6.0-1+b1
Severity: normal
X-Debbugs-Cc: r...@debian.org

dh-make-golang (or perhaps git-buildpackage) sometimes fails to find
upstream git tags, even though they exist:

$ dh-make-golang make -type l -git_revision v1.0.0 github.com/bradenhilton/mozillainstallhash
2022/07/17 15:11:21 Starting "dh-make-golang v0.6.0 linux/amd64"
2022/07/17 15:11:21 Downloading "github.com/bradenhilton/mozillainstallhash/..."
2022/07/17 15:11:21 Determining upstream version number
2022/07/17 15:11:21 Found latest tag "v1.0.0"
2022/07/17 15:11:21 Latest tag "v1.0.0" matches master
2022/07/17 15:11:21 Package version is "1.0.0"
2022/07/17 15:11:21 Determining dependencies
2022/07/17 15:11:22 Downloading https://github.com/bradenhilton/mozillainstallhash/archive/v1.0.0.tar.gz
2022/07/17 15:11:23 Moving tempfile to "golang-github-bradenhilton-mozillainstallhash_1.0.0.orig.tar.gz"
2022/07/17 15:11:23 Adding remote "origin" with URL "g...@salsa.debian.org:go-team/packages/golang-github-bradenhilton-mozillainstallhash.git"
2022/07/17 15:11:23 Adding remote "github" with URL "https://github.com/bradenhilton/mozillainstallhash"
2022/07/17 15:11:23 Running "git fetch github"
remote: Enumerating objects: 49, done.
remote: Counting objects: 100% (49/49), done.
remote: Compressing objects: 100% (33/33), done.
remote: Total 49 (delta 26), reused 36 (delta 16), pack-reused 0
Unpacking objects: 100% (49/49), 9.71 KiB | 1.94 MiB/s, done.
From https://github.com/bradenhilton/mozillainstallhash
* [new branch] main -> github/main
gbp:error: Import of /tmp/golang-github-bradenhilton-mozillainstallhash_1.0.0.orig.tar.gz failed: Can't find upstream vcs tag at 'v1.0.0'
2022/07/17 15:11:23 Could not create git repository: import-orig: exit status 1

However, if we clone the git repository, we see that the tag exists:

$ git clone https://github.com/bradenhilton/mozillainstallhash ; cd mozillainstallhash
Cloning into 'mozillainstallhash'...
remote: Enumerating objects: 52, done.
remote: Counting objects: 100% (52/52), done.
remote: Compressing objects: 100% (36/36), done.
remote: Total 52 (delta 28), reused 37 (delta 16), pack-reused 0
Receiving objects: 100% (52/52), 10.50 KiB | 10.50 MiB/s, done.
Resolving deltas: 100% (28/28), done.
$ git tag; git reset --hard v1.0.0
v1.0.0
HEAD is now at 1eb17be Update README

[As a separate wishlist, which should get its own bug: it would be
helpful for debugging purposes if dh-make-golang had a flag to keep it
from cleaning up after itself in the event of failure.]

-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.18.0-2-amd64 (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.utf8, LC_CTYPE=en_CA.utf8 (charmap=UTF-8), LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dh-make-golang depends on:
ii git 1:2.36.1-1
ii git-buildpackage 0.9.28
ii golang-any 2:1.18~3
ii libc6 2.33-8
ii pristine-tar 1.49

Versions of packages dh-make-golang recommends:
ii golang-golang-x-tools 1:0.1.11+ds-2
ii opensmtpd [mail-transport-agent] 6.8.0p2-4+b2

dh-make-golang suggests no packages.

-- no debconf information

--
|)|/ Ryan Kavanagh | 4E46 9519 ED67 7734 268F
|\|\ https://rak.ac | BD95 8F7B F8FC 4A11 C97A
signature.asc

David Horn

unread,
May 7, 2023, 5:10:04 PM5/7/23
to
It looks like the issue with v1.0.0 tag here is some sort of github external origin issue.  This seems to be resolved with the  v1.0.1 tag.   If you use a web browser to examine the older v1.0.0 tag, you see a github warning of "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository."  IOW, use v1.0.1 and the previous error is gone.

Example make succeeds:
dh-make-golang make -type l -git_revision v1.0.1 github.com/bradenhilton/mozillainstallhash

Any chance we can move forward with the chezmoi package if this mozilainstallhash dependency can now build successfully ?  I'm willing to help test.

--Thanks!



0 new messages