Bug#932858: smtp.montor: hostname() doesn't accept any arguments

[Allan Wind]

Package: mon
Version: 1.3.3-2
Severity: normal

Dear Maintainer,

smtp.montitor contains two two warnings from Sys::Hostname::hostname in
the Summary and Detail:

Summary: hostname() doesn't accept any arguments. This will become fatal in Perl
5.32 at /usr/lib/mon/mon.d/smtp.monitor line 248.

Detail: hostname() doesn't accept any arguments. This will become fatal
in Perl 5.32 at /usr/lib/mon/mon.d/smtp.monitor line 181.

This is because the function is called as &hostname which implicitly
passed @_ (at call site), i.e. hostname(@_). This defect is easy enough
to fix, namely, change the two lines from:

$OurHostname = &hostname;

to:

$OurHostname = hostname();


/Allan

-- System Information:
Debian Release: 10.0
APT prefers stable
APT policy: (990, 'stable'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-8-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages mon depends on:
ii adduser 3.118
ii libc6 2.28-10
ii libtime-period-perl 1.25-1
ii mon-client 1.2.0-2

Versions of packages mon recommends:
ii bc 1.07.1-2+b1
ii fping 4.2-1
pn libauthen-pam-perl <none>
ii libcgi-pm-perl 4.40-1
pn libcrypt-ssleay-perl <none>
ii libfilesys-df-perl 0.92-6+b4
ii libmail-imapclient-perl 3.42-1
ii libnet-dns-perl 1.19-1
pn libnet-ldap-perl <none>
ii libnet-telnet-perl 3.04-1
ii libproc-processtable-perl 0.56-1
ii libsnmp-perl 5.7.3+dfsg-5
ii libstatistics-descriptive-perl 3.0702-1
pn libtime-parsedate-perl <none>
ii libtimedate-perl 2.3000-2
ii perl-modules-5.24 [libnet-perl] 5.24.1-3+deb9u5
ii swaks 20181104.0-2

Versions of packages mon suggests:
ii mon-contrib 1.0+dfsg-4

-- Configuration Files:
/etc/mon/auth.cf changed [not included]
/etc/mon/mon.cf [Errno 2] No such file or directory: '/etc/mon/mon.cf'

-- no debconf information

[Klaus Rein]

pop3.monitor has the same problem (in line 124)
and the same fix made it work again here.


Klaus.

--
levigo systems gmbh ----------- ein Unternehmen der levigo gruppe
Bebelsbergstraße 31 Telefon: 07031 / 4161-10
D-71088 Holzgerlingen Telefax: 07031 / 4161-11
GF: Oliver Bausch, Vincenzo Biasi http://systems.levigo.de/
Informationen zu Art.13,14 DSGVO: https://datenschutz.levigo.de/
Registergericht: Stuttgart HRB 245180 USt-ID: DE813226078