Bug#886402: needrestart: Shows perl errors (uninitialized value)

[cre]

Package: needrestart
Version: 2.11-4
Severity: normal

Dear Maintainer,

The program seems to run fine, but it prints out these error messages just before the "real" messages:

$ sudo needrestart
[sudo] password for cre:
Use of uninitialized value $testp in stat at /usr/sbin/needrestart line 462, <HMAP> line 1.========== ]
Use of uninitialized value $sdev in right bitshift (>>) at /usr/sbin/needrestart line 463, <HMAP> line 1.
Use of uninitialized value $sdev in right bitshift (>>) at /usr/sbin/needrestart line 463, <HMAP> line 1.
Use of uninitialized value $sdev in bitwise and (&) at /usr/sbin/needrestart line 463, <HMAP> line 1.
Use of uninitialized value $sdev in right bitshift (>>) at /usr/sbin/needrestart line 463, <HMAP> line 1.
Use of uninitialized value $sdev in right bitshift (>>) at /usr/sbin/needrestart line 463, <HMAP> line 1.
Use of uninitialized value $sdev in bitwise and (&) at /usr/sbin/needrestart line 463, <HMAP> line 1.
Use of uninitialized value $sdev in right bitshift (>>) at /usr/sbin/needrestart line 475, <HMAP> line 1.
Use of uninitialized value $sdev in right bitshift (>>) at /usr/sbin/needrestart line 475, <HMAP> line 1.
Use of uninitialized value $sinode in string eq at /usr/sbin/needrestart line 480, <HMAP> line 1.
Scanning processes...
Scanning candidates...
Scanning linux images...
[...cut...]

That seems related to perl.


-- Package-specific info:
needrestart output:
Your outdated processes:
applet.py[1317], at-spi-bus-laun[1251], at-spi2-registr[1258], bash[21570], claws-mail[21747], dbus-daemon[1256, 1174], dconf-service[1342], firefox[21585], gvfsd[1306], keepassxc[21528],
light-locker[1324], panel-2-actions[1302], panel-4-notific[1301], panel-6-systray[1300], panel-7-whisker[1289], panel-12-cpugra[1296], panel-16-fsguar[1299], panel-17-netloa[1298],
panel-19-system[1297], pulseaudio[1318], sh[1166], systemd[1150], terminator[21561], Thunar[1271], VBoxClient[1207, 1232, 1205, 1221, 1219, 1227, 1225, 1233], vlc[21829], Web
Content[21634], xfce4-notifyd[1347], xfce4-panel[1272], xfce4-power-man[1307, 1325], xfce4-session[1250], xfconfd[1262], xfdesktop[1278], xfsettingsd[1274], xfwm4[1270]

checkrestart output:


-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.14.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages needrestart depends on:
ii dpkg 1.19.0.4
ii gettext-base 0.19.8.1-4
ii libintl-perl 1.26-2
ii libmodule-find-perl 0.13-1
ii libmodule-scandeps-perl 1.24-1
ii libproc-processtable-perl 0.53-2+b2
ii libsort-naturally-perl 1.03-1
ii libterm-readkey-perl 2.37-1+b2
ii perl 5.26.1-3
ii xz-utils 5.2.2-1.3

Versions of packages needrestart recommends:
pn libpam-systemd | sysvinit-core <none>

Versions of packages needrestart suggests:
ii libnotify-bin 0.7.7-3

-- Configuration Files:
/etc/needrestart/needrestart.conf changed:
$nrconf{sendnotify} = 0;
$nrconf{restart} = 'a';
$nrconf{ui} = 'NeedRestart::UI::stdio';
$nrconf{blacklist} = [
# ignore sudo (not a daemon)
qr(^/usr/bin/sudo(\.dpkg-new)?$),
# ignore DHCP clients
qr(^/sbin/(dhclient|dhcpcd5|pump|udhcpc)(\.dpkg-new)?$),
# ignore apt-get (Debian Bug#784237)
qr(^/usr/bin/apt-get(\.dpkg-new)?$),
];
$nrconf{override_rc} = {
# DBus
qr(^dbus) => 0,
# display managers
qr(^gdm) => 0,
qr(^kdm) => 0,
qr(^nodm) => 0,
qr(^sddm) => 0,
qr(^wdm) => 0,
qr(^xdm) => 0,
qr(^lightdm) => 0,
qr(^slim) => 0,
qr(^lxdm) => 0,
# networking stuff
qr(^network-manager) => 0,
qr(^NetworkManager) => 0,
qr(^wpa_supplicant) => 0,
qr(^openvpn) => 0,
qr(^quagga) => 0,
qr(^tinc) => 0,
# gettys
qr(^getty@.+\.service) => 0,
# systemd --user
qr(^user@\d+\.service) => 0,
# misc
qr(^zfs-fuse) => 0,
qr(^mythtv-backend) => 0,
qr(^xendomains) => 0,
qr(^lxcfs) => 0,
# workaround for broken systemd-journald
# (see also Debian Bug#771122 & #771254)
qr(^systemd-journald) => 0,
# more systemd stuff
# (see also Debian Bug#784238 & #784437)
qr(^emergency\.service$) => 0,
qr(^rescue\.service$) => 0,
# Do not restart oneshot service apt-daily, unattended-upgrades.service
# and apt-daily-upgrade.service,see #862840
qr(^apt-daily\.service$) => 0,
qr(^apt-daily-upgrade\.service$) => 0,
qr(^unattended-upgrades\.service$) => 0,
# Ignore rc-local.service, see #852864
qr(^rc-local\.service$) => 0,
# don't restart systemd-logind, see #798097
qr(^systemd-logind) => 0,
};
$nrconf{override_cont} = {
};
$nrconf{blacklist_interp} = [
# ignore temporary files
qr(^/tmp/),
qr(^/var/),
qr(^/run/),
];
$nrconf{blacklist_mappings} = [
# special device paths
qr(^/(SYSV00000000$|drm$|dev/)),
# aio(7) mapping
qr(^/\[aio\]),
# Oil Runtime Compiler's JIT files
qr#/orcexec\.[\w\d]+( \(deleted\))?$#,
];
$nrconf{skip_mapfiles} = (-d '/proc/sys/kernel/grsecurity' ? -1 : 0);
if(-d q(/etc/needrestart/conf.d)) {
foreach my $fn (sort </etc/needrestart/conf.d/*.conf>) {
print STDERR "$LOGPREF eval $fn\n" if($nrconf{verbose});
eval do { local(@ARGV, $/) = $fn; <>};
die "Error parsing $fn: $@" if($@);
}
}


-- no debconf information

[cretox]

Setting

$nrconf{skip_mapfiles} = (-d '/proc/sys/kernel/grsecurity' ? -1 : 1);

solves the issue but disables the check?

--
cre

[Thomas Liske]

tags 886402 upstream fixed-upstream
thanks


Hi,

the perl warnings have been already fixed upstream[1].

[1] https://github.com/liske/needrestart/commit/7ab8834b154f7813b0528424d149e0a0aa3f5b88


HTH,
Thomas

--

:: WWW: https://fiasko-nw.net/~thomas/ ::
::: Jabber: xmpp:tho...@jabber.fiasko-nw.net :::
:: flickr: https://www.flickr.com/photos/laugufe/ ::