Bug#822910: mutt-patched: silently dropped the sidebar-dotpathsep patch in favor of sidebar-dotted

Gian Piero Carrubba

unread,

Apr 28, 2016, 4:40:04 PM4/28/16

to

Package: mutt-patched
Version: 1.6.0-1
Severity: normal

Dear Maintainers,

thank you for your work on mutt.

Mutt 1.6.0-1 is using the sidebar-dotted patch that was abandoned in
1.5.22-2 in favor of Gentoo's sidebar-dotpathsep.

I personally prefer the sidebar-dotpathsep patch because:

- has a summary listing # of unread/flagged/total messages instead of only
unread/total
- has configurable mailboxes separator (in my case, the newly reintroduced
patch does not correctly display maildirs containing a dot in the name)

Anyway, if even the reintroduction of the old patch was intentional, please
document it in the NEWS.Debian file, noting that 'sidebar_delim_chars' is
not valid anymore and 'sidebar_shortpath' can be used instead (sort of).

Thank you,
Gian Piero.

-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.5.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages mutt-patched depends on:
ii libassuan0 2.4.2-3
ii libc6 2.22-7
ii libcomerr2 1.43~WIP.2016.03.15-2
ii libgnutls30 3.4.11-4
ii libgpg-error0 1.22-1
ii libgpgme11 1.6.0-3
ii libgssapi-krb5-2 1.13.2+dfsg-5
ii libidn11 1.32-3
ii libk5crypto3 1.13.2+dfsg-5
ii libkrb5-3 1.13.2+dfsg-5
ii libncursesw5 6.0+20160319-1
ii libsasl2-2 2.1.26.dfsg1-15
ii libtinfo5 6.0+20160319-1
ii libtokyocabinet9 1.4.48-10
ii mutt 1.6.0-1

mutt-patched recommends no packages.

mutt-patched suggests no packages.

-- no debconf information

Gian Piero Carrubba

unread,

Apr 28, 2016, 5:30:03 PM4/28/16

to

* [Thu, Apr 28, 2016 at 10:32:17PM +0200] Gian Piero Carrubba:

>I personally prefer the sidebar-dotpathsep patch because:
>
>- has a summary listing # of unread/flagged/total messages instead of only
> unread/total

Please disregard this, it seems I cannot see a number if it's just a few
pixel away from where I suppose it should be.

Ciao,
Gian Piero.

Evgeni Golov

unread,

Apr 29, 2016, 1:40:04 PM4/29/16

to

Hi Gian Piero,

On Thu, Apr 28, 2016 at 10:32:17PM +0200, Gian Piero Carrubba wrote:

> Mutt 1.6.0-1 is using the sidebar-dotted patch that was abandoned in
> 1.5.22-2 in favor of Gentoo's sidebar-dotpathsep.

Partially, it is an upstream feature now.

> I personally prefer the sidebar-dotpathsep patch because:
>
> - has a summary listing # of unread/flagged/total messages instead of only
> unread/total

Flagged should be supported according to docs, I never tried that, though.

> - has configurable mailboxes separator (in my case, the newly reintroduced
> patch does not correctly display maildirs containing a dot in the name)

Did you try setting sidebar_folderindent? That worked fine here with dotted maildirs.

> Anyway, if even the reintroduction of the old patch was intentional, please
> document it in the NEWS.Debian file, noting that 'sidebar_delim_chars' is
> not valid anymore and 'sidebar_shortpath' can be used instead (sort of).

I've added some details in https://anonscm.debian.org/cgit/pkg-mutt/mutt.git/commit/?id=00fe2d19fa615e25e10f9976a937358a42cd1be7
Could you have a look if that makes sense to you?

Greets
Evgeni

Gian Piero Carrubba

unread,

May 1, 2016, 3:30:03 PM5/1/16

to

severity 822910 wishlist
retitle -1 mutt-patched: allow configurable delim_chars in sidebar
thanks

Hi Evgeni,

thank you for your quick response.

* [Fri, Apr 29, 2016 at 07:21:03PM +0200] Evgeni Golov:

>> I personally prefer the sidebar-dotpathsep patch because:
>>
>> - has a summary listing # of unread/flagged/total messages instead of
>> only unread/total
>
>Flagged should be supported according to docs, I never tried that,
>though.

Yeah, sorry I've initially missed it.

>> - has configurable mailboxes separator (in my case, the newly
>> reintroduced patch does not correctly display maildirs containing a
>> dot in the name)
>
>Did you try setting sidebar_folderindent? That worked fine here with
>dotted maildirs.

Yes, this is the pseudo-diff of my config:

- set sidebar_delim_chars = '/'
+ set sidebar_shortpath = yes
+ set sidebar_folderindent = yes

Also, I'm not using dotted maildirs (dir.maildir1, dir.maildir2, ...),
but nested dirs in which the leaf dirs are actually maildirs
(dir/maildir1, dir/maildir2, ...). The name of some dirs contains a dot.

i.e., the following tree (in which ham/spam are actually maildirs):

.Junk/
├── ham
└── spam

is rendered as:

.Junk
Junk/ham
Junk/spam

instead of:

.Junk
ham
spam

More important, the following tree (again, only inner dirs are maildir):

domain.tld/
├── server1
└── server2

is rendered as:

tld
tld/server1
tld/server2

instead of:

domain.tld
server1
server2

In this particular case, I'm "losing" infos about which domain the
server belongs to.

Anyway, while I think my directory tree is legit, I totally understand
if you don't want to support this case.

>> 'sidebar_delim_chars' is
>> not valid anymore and 'sidebar_shortpath' can be used instead (sort of).
>
>I've added some details in https://anonscm.debian.org/cgit/pkg-mutt/mutt.git/commit/?id=00fe2d19fa615e25e10f9976a937358a42cd1be7
>Could you have a look if that makes sense to you?

Seems fine to me (maybe just use sidebar_delim_chars instead of
delim_chars in order to point to the right option). As this is now
documented, I'm downgrading the severity to wishlist.

Thank you,
Gian Piero.

Faidon Liambotis

unread,

May 3, 2016, 8:30:03 AM5/3/16

to

Gian Piero,

On Sun, May 01, 2016 at 09:22:59PM +0200, Gian Piero Carrubba wrote:
> Yes, this is the pseudo-diff of my config:
>
> - set sidebar_delim_chars = '/'
> + set sidebar_shortpath = yes
> + set sidebar_folderindent = yes
>
> Also, I'm not using dotted maildirs (dir.maildir1, dir.maildir2, ...), but
> nested dirs in which the leaf dirs are actually maildirs (dir/maildir1,
> dir/maildir2, ...). The name of some dirs contains a dot.

You might want to have a look at #777127. The patch there unfortunately
replaces the hardcoded "." delimiter with an also hardcoded "/" & "."
giving preference to dot over slash, so it might not work for you (since
I see you use both). Between that patch and sidebar-dotpathsep.patch
from 1.5.24-1, it doesn't look like it'd be very hard to resurrect
sidebar_delim_chars.

Also,
set sidebar_format="%B%* %S%?N?(%N)?%?F?[%F]?"
reverts to the 1.5.24-1 formatting behavior, in case you were missing
it, as I did :)

Best,
Faidon

Faidon Liambotis

unread,

May 3, 2016, 9:00:03 AM5/3/16

to

On Fri, Apr 29, 2016 at 07:21:03PM +0200, Evgeni Golov wrote:
> On Thu, Apr 28, 2016 at 10:32:17PM +0200, Gian Piero Carrubba wrote:
>
> > Mutt 1.6.0-1 is using the sidebar-dotted patch that was abandoned in
> > 1.5.22-2 in favor of Gentoo's sidebar-dotpathsep.
>
> Partially, it is an upstream feature now.

I did some more research -- and found this upstream PR:
https://bitbucket.org/mutt/mutt/pull-requests/1/add-sidebar-panel-to-mutt/

It's based on the latest upstream sidebar release (20151111), but adds
several commits on top, including sidebar_delim_chars and UTF-8 support.
It seems to be more recent (2016-04-04), much more mature than the
original one and has the added plus that restores functionality that was
present in the Debian release of 1.5.24-1 and has since regressed with
the 1.6.0-1.

Evgeni, perhaps this is something that should be considered to be
included instead of the current sidebar patch?

Thanks,
Faidon