Bug#850908: samba: compile in support for GPGME ("password hash gpg key ids" config option)

[Daniel A]

Package: samba
Version: 2:4.5.2+dfsg-2
Severity: wishlist
Tags: patch

Please compile in support for the GPGME in the samba package.
It's related to a new feature of the Samba 4.5 release, configured by the 'password hash gpg key ids' option in the smb.conf.

Without gpgme support 'samba-tool user create' errors out with the following error message if this option is enabled:

>$ samba-tool user create testuser TestPassword1
>You configured 'password hash gpg key ids', but GPGME support is missing. (../source4/dsdb/samdb/ldb_modules/password_hash.c:1546)
>ERROR(ldb): Failed to add user 'testuser': - You configured 'password hash gpg key ids', but GPGME support is missing. (../source4/dsdb/samdb/ldb_modules/password_hash.c:1546)

I've also attached patch for the relevant control files of the package.


-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.4.0-57-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages samba depends on:
ii adduser 3.115
ii dpkg 1.18.18
ii init-system-helpers 1.46
ii libbsd0 0.8.3-1
ii libc6 2.24-8
ii libldb1 2:1.1.27-1
ii libpam-modules 1.1.8-3.4
ii libpam-runtime 1.1.8-3.4
ii libpopt0 1.16-10
ii libpython2.7 2.7.13-1
ii libtalloc2 2.1.8-1
ii libtdb1 1.3.11-2
ii libtevent0 0.9.31-1
ii libwbclient0 2:4.5.2+dfsg-2
ii lsb-base 9.20161125
ii procps 2:3.3.12-3
ii python 2.7.13-1
ii python-dnspython 1.15.0-1
ii python-samba 2:4.5.2+dfsg-2
pn python2.7:any <none>
ii samba-common 2:4.5.2+dfsg-2
ii samba-common-bin 2:4.5.2+dfsg-2
ii samba-libs 2:4.5.2+dfsg-2
ii tdb-tools 1.3.11-2
ii update-inetd 4.43

Versions of packages samba recommends:
ii attr 1:2.4.47-2
ii logrotate 3.8.7-2
ii samba-dsdb-modules 2:4.5.2+dfsg-2
ii samba-vfs-modules 2:4.5.2+dfsg-2

Versions of packages samba suggests:
pn bind9 <none>
pn bind9utils <none>
pn ctdb <none>
pn ldb-tools <none>
pn ntp <none>
pn smbldap-tools <none>
pn ufw <none>
pn winbind <none>

-- no debconf information

[Andrew Bartlett]

On Wed, 2017-01-11 at 04:45 +0000, Daniel A wrote:
> Package: samba
> Version: 2:4.5.2+dfsg-2
> Severity: wishlist
> Tags: patch
>
> Please compile in support for the GPGME in the samba package.
> It's related to a new feature of the Samba 4.5 release, configured by
> the 'password hash gpg key ids' option in the smb.conf.
>
> Without gpgme support 'samba-tool user create' errors out with the
> following error message if this option is enabled:
>
> > $ samba-tool user create testuser TestPassword1
> > You configured 'password hash gpg key ids', but GPGME support is
> > missing. (../source4/dsdb/samdb/ldb_modules/password_hash.c:1546)
> > ERROR(ldb): Failed to add user 'testuser':  - You configured
> > 'password hash gpg key ids', but GPGME support is missing.
> > (../source4/dsdb/samdb/ldb_modules/password_hash.c:1546)
>
> I've also attached patch for the relevant control files of the
> package.

Thanks. I agree we should support the gpgme extension in the Debian
packages.

I'm not actively involved right now, but I hope the patch can be merged
soon, otherwise bug me in a couple of weeks, and I'll page back in my
debian packaging skills ;-)

Andrew Bartlett