Bug#495842: Starting gpsd on hotplug seems broken

[Phil Endecott]

Package: gpsd
Version: 2.37-6
Severity: normal

Please forgive me if I have misunderstood how this is supposed
to work.

I want gpsd to start when I plug in the USB device.

debconf asks me this question:

Start gpsd automatically on boot?

This isn't what I want so I say no. It asks no other questions
and saves this in /etc/default/gpsd:

START_DAEMON="false"
USBAUTO="false"

As expected, /etc/init.d/gpsd looks at this and doesn't start
gpsd at boot.

When I hotplug the device, /lib/udev/gpsd.hotplug.wrapper is
called and does this:

[ "$START_DAEMON" = "true" ] || exit 0

Since START_DAEMON is false, it exits.

So I think there are two problems here. Firstly, if I say "no"
to starting on boot, debconf should ask me about hotplugging and
set USBAUTO based on my answer. Secondly,
/lib/udev/gpsd.hotplug.wrapper should not exit immediately when
START_DAEMON is false (I'm unsure whether the rest of the hotplug
script should or shouldn't run in the case when the daemon was
started at boot).

I have tested this on my system by (a) editting /etc/default/gpsd
to set START_DAEMON=false and USBAUTO=true and (b) reversing the
sense of the test in /lib/udev/gpsd.hotplug.wrapper, and it now
seems to do what I wanted.

Regards, Phil.

--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org

[Bernd Zeimetz]

Hi,

thanks for the report!

> I have tested this on my system by (a) editting /etc/default/gpsd
> to set START_DAEMON=false and USBAUTO=true and (b) reversing the
> sense of the test in /lib/udev/gpsd.hotplug.wrapper, and it now
> seems to do what I wanted.

Indeed that works now - some versions ago hotplugging required a running
gpsd. I'll change this with the next upload.

Best regards,

Bernd

--
Bernd Zeimetz Debian GNU/Linux Developer
GPG Fingerprint: 06C8 C9A2 EAAD E37E 5B2C BE93 067A AD04 C93B FF79

[Jens Thiele]

Any news regarding this one?
Couldn't this be fixed for lenny?

Isn't it just:

--- /lib/udev/gpsd.hotplug.wrapper~ 2009-01-05 00:06:32.000000000 +0100
+++ /lib/udev/gpsd.hotplug.wrapper 2009-01-16 01:40:52.000000000 +0100
@@ -3,7 +3,7 @@

#debian addition:
[ ! -r /etc/default/gpsd ] || . /etc/default/gpsd
-[ "$START_DAEMON" = "true" ] || exit 0
+#[ "$START_DAEMON" = "true" ] || exit 0
[ "$USBAUTO" = "true" ] || exit 0

Greetings,
Jens

[Bernd Zeimetz]

Jens Thiele wrote:
> Any news regarding this one?
> Couldn't this be fixed for lenny?
>
> Isn't it just:
>
> --- /lib/udev/gpsd.hotplug.wrapper~ 2009-01-05 00:06:32.000000000 +0100
> +++ /lib/udev/gpsd.hotplug.wrapper 2009-01-16 01:40:52.000000000 +0100
> @@ -3,7 +3,7 @@
>
> #debian addition:
> [ ! -r /etc/default/gpsd ] || . /etc/default/gpsd
> -[ "$START_DAEMON" = "true" ] || exit 0
> +#[ "$START_DAEMON" = "true" ] || exit 0
> [ "$USBAUTO" = "true" ] || exit 0

no, that's not enough - the debconf questions need to be modified, too.
As it is possible to start the Daemon at boot time and the hotplug script will
tell it to use the additional device, I didn't see a reason why I should
change this during the freeze.
The bug will be addressed with one of the next uploads, which will happen when
upstream releases 2.38. Although I'll upload a svn snapshot to experimental
before probably.

Thanks for the report,

Bernd

--
Bernd Zeimetz Debian GNU/Linux Developer
GPG Fingerprint: 06C8 C9A2 EAAD E37E 5B2C BE93 067A AD04 C93B FF79

--