Bug#1014930: irssi: FTBFS with Perl 5.36: ISO C90 forbids mixed declarations and code

[Niko Tyni]

Source: irssi
Version: 1.4.1-1
Severity: normal
Tags: ftbfs patch fixed-upstream
Forwarded: https://github.com/irssi/irssi/issues/1381
User: debia...@lists.debian.org
Usertags: perl-5.36-transition

Hi,

irssi_1.4.1-1 started building with -Werror=declaration-after-statement,
which broke the build with Perl 5.36 (currently in experimental.)

http://perl.debian.net/rebuild-logs/perl-5.36/irssi_1.4.1-1/irssi_1.4.1-1+b1_amd64-2022-07-11T15:30:44Z.build

FAILED: src/perl/libperl_core.so.p/perl-signals.c.o
cc -Isrc/perl/libperl_core.so.p -I. -I.. -Isrc/perl -I../src/perl -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/local/include -I/usr/lib/x86_64-linux-gnu/perl/5.36/CORE -fdiagnostics-color=always -Wall -Winvalid-pch -O0 -Werror=declaration-after-statement -fno-strict-aliasing -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fPIC -pthread '-DSCRIPTDIR="/usr/share/irssi/scripts"' '-DPERL_USE_LIB=""' -DPERL_STATIC_LIBS=0 -MD -MQ src/perl/libperl_core.so.p/perl-signals.c.o -MF src/perl/libperl_core.so.p/perl-signals.c.o.d -o src/perl/libperl_core.so.p/perl-signals.c.o -c ../src/perl/perl-signals.c
In file included from /usr/lib/x86_64-linux-gnu/perl/5.36/CORE/perl.h:7242,
from ../src/perl/module.h:8,
from ../src/perl/perl-signals.c:23:
/usr/lib/x86_64-linux-gnu/perl/5.36/CORE/inline.h: In function ‘Perl_cop_file_avn’:
/usr/lib/x86_64-linux-gnu/perl/5.36/CORE/inline.h:3489:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
3489 | const char *file = CopFILE(cop);
| ^~~~~
cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.
dh_auto_build: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 ninja -j4 -v returned exit code 1
make: *** [debian/rules:12: binary-arch] Error 25

Dropping C89 support seems to be a conscious choice on the perl side
with 5.36, see

https://github.com/Perl/perl5/issues/19382

https://github.com/Perl/perl5/pull/19384

Reported on the irssi upstream side as

https://github.com/irssi/irssi/issues/1381

and supposedly fixed with

https://github.com/irssi/irssi/pull/1384

though I haven't verified that.

Thanks for your work on Debian,
--
Niko Tyni nt...@debian.org