Bug#1021364: RFS: ghostwriter/2.2.0-1 [RC] -- Distraction-free, themeable Markdown editor

[Sebastien Chavaux]

Package: sponsorship-requests
Severity: important

Dear mentors,

I am looking for a sponsor for my package "ghostwriter":

 * Package name     : ghostwriter
   Version          : 2.2.0-1
   Upstream contact : wereturtle <weretu...@gmail.com>
 * URL              : https://wereturtle.github.io/ghostwriter/
 * License          : Expat, GPL-3.0+, CC-BY-SA-4.0, GPL-3.0, ISC
 * Vcs              : https://salsa.debian.org/seb95-guest/ghostwriter
   Section          : editors

The source builds the following binary packages:

  ghostwriter - Distraction-free, themeable Markdown editor

To access further information about this package, please visit the following URL:

  https://mentors.debian.net/package/ghostwriter/

Alternatively, you can download the package with 'dget' using this command:

  dget -x https://mentors.debian.net/debian/pool/main/g/ghostwriter/ghostwriter_2.2.0-1.dsc

Changes since the last upload:

 ghostwriter (2.2.0-1) unstable; urgency=medium
 .
   * New upstream release.
   * debian/control: set Standards-Version: to 4.6.1
   * debian/control: address correction
   * debian/watch: address correction
   * CVE-2022-24724 (Closes: #1006757)

Regards,

[Nicholas D Steeves]

Sebastien Chavaux <seb95...@gmail.com> writes:

> it's a bit of a mess, I made changes, in debian/copyright, unfortunately it
> makes build errors:
> *** No rule to make target '3rdparty/MathJax/bin/startup.js', needed by
> 'build/release/qrc_resources.cpp'.
> Stop.
> make[1]: *** Waiting for unfinished jobs....
> make[1]: Leaving directory '/build/ghostwriter-2.1.6+dfsg'
> dh_auto_build: error: make -j6 returned exit code 2
> make: *** [debian/rules:6: build] Error 2
> dpkg-buildpackage: error: debian/rules build subprocess returned exit
> status 2
> I: copying local configuration
> E: Failed autobuilding of package
>
>

Isn't libjs-mathjax MathJax2, and doesn't Ghostwriter needs MathJax3,
which is incompatible with MathJax2?

https://github.com/KDE/ghostwriter/blob/master/3rdparty/MathJax/src/package.json

Here is the RFP bug for MathJax3 for anyone who is interested in
packaging this important javascript library:
https://bugs.debian.org/950424

Regards,
Nicholas

[Sebastien Chavaux]

Absolutely, I'm so in my head that I don't see what is the simplest...

[Sebastien Chavaux]

Hello Aurelien :-)

For the integration of Ghostwriter in the scope of the Qt/KDE packaging team, I agree, no worries, I also had the case at openSUSE and I'm looking how I could in the following days, pass all that on to Debian as well.

As for gitlab, I have trouble communicating with it, I can't even do that from my terminal anymore, I have a legal problem, so I do everything from the risky web interface. I more or less gave up on the git business. But I will give you the rights.

I haven't worked with the repository long enough, I work directly from home and a folder. I would like to help in other packages but again I stumble on the use of gitlab.

I'll try to free up time to make the changes but it's not said. I don't have any Debian around right now.

Best regards.

Le mar. 20 déc. 2022 à 13:30, Aurélien COUDERC <li...@coucouf.fr> a écrit :

Le mercredi 12 octobre 2022, 11:41:50 CET Sebastien Chavaux a écrit :
> Absolutely, I'm so in my head that I don't see what is the simplest...

Dear Sebastien,

as Ghostwriter has been onboarded as a KDE Project, I’d like to offer to integrate the package into the perimeter of the Qt/KDE Packaging Team.

We have an « extras » group [0] for packages that are related to KDE but not part of the main KDE Frameworks / Plasma / Gear releases that I think would be suitable.

How we would do this is :
- give me (cou...@debian.org) or one of the team members owner access to your packaging repo so we can move it to the qt-kde-team/extras group
- change the Maintainer field to : Debian KDE Extras Team <pkg-kde...@alioth-lists.debian.net>
- put yourself in the Uploaders field

What you would get :
- you keep your usual access to the repo and can work on the package as you used to
- team members and myself would be considered welcome to contribute to that repository too
- it would gives additional scrutiny to the package that would show on our DDPO dashboard
- you’re welcome to help on other packages of the team :)

Whether you’re interested or not, you’re welcome to hang out on the #debian-qt-kde on Debian’s IRC for help and feedback or upload sponsorship.


To follow up on the RFS discussion:
- MathJax3 is currently not packaged so it’s fine to keep it vendored (3rdparty) for now. We can migrate to the Debian package once it’s available.
- The source-is-missing lintian tags are false positives to me (if lintian still really emits them, I haven’t checked). The folders 3rdparty/{MathJax,react} contain valid, human modifiable source files. Please add a comment in the lintian-overrides file to explain so.
- You should use the Files-Excluded directive in debian/copyright [1] to describe which files should be removed from the upstream source. That should be the debian/ folder + 3rd party libraries already available in Debian.
- I would prefer the +ds suffix instead of +dfsg, +dfsg is more appropriate for cases where we remove upstream sources due to licensing concerns which is not the case here IIUC.
- uscan --download-current-version fails, it should work from a clean clone of the repo (the uupdate is not required unless I’m missing something), and…
- it would be preferable for debian/watch to target the invent.kde.org repo which is now the reference repo, you have examples for GitLab tags here [2].
- In the git packaging repo you have the « source » folder next to the « debian » folder, it should be *inside* it.
- source/options can be removed.
- Remove debian/compat and replace the debhelper (>= 11) build dependency by a debhelper-compat (= 13) build dep.
- Remove debian/git-build-recipe.manifest ? I don’t know what it’s for so it’s probably not useful. :)


Feel free to ping me or the team on IRC about any of the above.


[0] https://salsa.debian.org/qt-kde-team/extras
[1] https://wiki.debian.org/UscanEnhancements
[2] https://wiki.debian.org/debian/watch#Gitlab


Thanks for your response & cheers,
--
Aurélien, on behalf of the Qt/KDE Packaging Team

[Aurélien COUDERC]

Hi Sebastian,

Le mardi 20 décembre 2022, 18:04:50 CET Sebastien Chavaux a écrit :
> Hello Aurelien :-)
>
> For the integration of Ghostwriter in the scope of the Qt/KDE packaging
> team, I agree, no worries, I also had the case at openSUSE and I'm looking
> how I could in the following days, pass all that on to Debian as well.

thanks, I’ve moved the Salsa repo after you granted me the necessary rights.
Feel free to check that you still have access to the repo, or complain to me directly if not.

> I'll try to free up time to make the changes but it's not said. I don't
> have any Debian around right now.

That needs fixing.
Installing Debian is relatively straightforward these days, you know. ^^

Joke aside I’ve made the changes I proposed below and uploaded the package.
Thank you for working on it until now, I hope I’ll see you contributing to Debian again !


Happy hacking,
--
Aurélien