Bug#805829: r-cran-gsl: Fails to build with GSL 2

Bas Couwenberg

unread,

Nov 22, 2015, 4:10:03 PM11/22/15

to

Source: r-cran-gsl
Version: 1.9-10-1
Severity: important
Tags: upstream

Dear Maintainer,

Your package fails to build with GSL 2:

configure: error: Need GSL version >= 1.12
ERROR: configuration failed for package 'gsl'

This needs to be fixed for the ongoing gsl transition (#804246).

The full build log is attached, as is a patch to update the build
dependencies for GSL 2 (changing libgsl0-dev to libgsl-dev).

Kind Regards,

Bas

r-cran-gsl_1.9-10-1.1.build

r-cran-gsl_1.9-10-1.1.debdiff

Andreas Tille

unread,

Nov 24, 2015, 4:20:03 PM11/24/15

to

Hi Bas,

thanks for working on the libgsl migration. I commited a patch to SVN[1]
to circumvent the check by configure but that's not sufficient to do the
migration. The build fails with

gcc -std=gnu99 -I/usr/share/R/include -DNDEBUG -I/usr/include -I. -fpic -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -g -c ellint.c -o ellint.o
ellint.c: In function 'ellint_D_e':
ellint.c:82:55: warning: passing argument 4 of 'gsl_sf_ellint_D_e' makes pointer from integer without a cast [-Wint-conversion]
status[i] = gsl_sf_ellint_D_e(phi[i], k[i], n[i], sf_mode[*mode], &result) ;
^
In file included from ellint.c:1:0:
/usr/include/gsl/gsl_sf_ellint.h:84:5: note: expected 'gsl_sf_result * {aka struct gsl_sf_result_struct *}' but argument is of type 'int'
int gsl_sf_ellint_D_e(double phi, double k, gsl_mode_t mode, gsl_sf_result * result);
^
ellint.c:82:17: error: too many arguments to function 'gsl_sf_ellint_D_e'
status[i] = gsl_sf_ellint_D_e(phi[i], k[i], n[i], sf_mode[*mode], &result) ;
^
In file included from ellint.c:1:0:
/usr/include/gsl/gsl_sf_ellint.h:84:5: note: declared here
int gsl_sf_ellint_D_e(double phi, double k, gsl_mode_t mode, gsl_sf_result * result);
^
/usr/lib/R/etc/Makeconf:134: recipe for target 'ellint.o' failed
make[1]: *** [ellint.o] Error 1

Anybody with some gsl experience might perhaps know what to do next
hopefully.

Kind regards

Andreas.

[1] svn://anonscm.debian.org/debian-science/packages/R/trunk/packages/r-cran-gsl/trunk/

--
http://fam-tille.de

Sebastiaan Couwenberg

unread,

Dec 3, 2015, 11:00:04 AM12/3/15

to

Control: tags -1 patch fixed-upstream

Hi Andreas,

On 24-11-15 22:14, Andreas Tille wrote:
> thanks for working on the libgsl migration. I commited a patch to SVN[1]
> to circumvent the check by configure but that's not sufficient to do the
> migration. The build fails with
>

> In file included from ellint.c:1:0:
> /usr/include/gsl/gsl_sf_ellint.h:84:5: note: expected 'gsl_sf_result * {aka struct gsl_sf_result_struct *}' but argument is of type 'int'
> int gsl_sf_ellint_D_e(double phi, double k, gsl_mode_t mode, gsl_sf_result * result);
> ^
> ellint.c:82:17: error: too many arguments to function 'gsl_sf_ellint_D_e'
> status[i] = gsl_sf_ellint_D_e(phi[i], k[i], n[i], sf_mode[*mode], &result) ;
> ^
>

> Anybody with some gsl experience might perhaps know what to do next
> hopefully.

The attached patch add support for GSL 2.x and make r-cran-gsl build
successfully with GSL 2.1.

The changes were taken from yesterdays 1.9-10.1 upstream release, so
you'll want to package that instead.

https://cran.r-project.org/web/packages/gsl/
https://cran.r-project.org/src/contrib/gsl_1.9-10.1.tar.gz

Make sure to update the build dependency to libgsl-dev to not pull in
the old GSL 1.x packages via libgsl0-dev.

Kind Regards,

Bas

--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1

r-cran-gsl_1.9-10-1.1_patch.debdiff