Bug#975055: bsdiff: make bspatch a little less memory hungry

[Vincent Galceran]

Package: bsdiff
Version: 4.3-21+b1
Severity: normal
X-Debbugs-Cc: vincent_...@yahoo.com

Dear Maintainer,

This is the same problem as bug 632585 for bspatch instead of bsdiff.
bspatch should be able to run on systems with less available memory with this patch.

The patch in attachment includes:
- bspatch.c: we use mmap instead of malloc and read for old file in bspatch
- bspatch.c: we use mmap instead of malloc and write for new file in bspatch
- Makefile: gcc now requires to have libs at the end of command line when linking

Regards,

-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.9.0-2-amd64 (SMP w/2 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages bsdiff depends on:
ii libbz2-1.0 1.0.8-4
ii libc6 2.31-4

bsdiff recommends no packages.

bsdiff suggests no packages.

-- no debconf information

[tony mancill]

On Tue, Jan 11, 2022 at 09:51:55AM +0000, Vincent G. wrote:
> Hi,
> Here is the patch for 4.3-22.
> Regards,

Hello Vincent,

Thank you for the updated patch. I intend to add some autopkgtests to
bsdiff and then will apply the patch and upload.

Cheers,
tony

[tony mancill]

Hi Vincent,

The upload of 4.3-23 updates the packaging and adds an autopkgtest. It
doesn't include any changes to the sources, so you don't need to rework
the patch.

However, I'd like to ask whether you have reached out to upstream
regarding the mmap() improvement. It would be preferable to get this
folded into the upstream release. That makes it easier for us to assess
CVEs, etc.

Would you be willing to initiate a conversation with the upstream author
regarding the patch?

Thanks,
tony