Bug#703358: virtualbox-guest-dkms: vboxvideo_drm.c fails to compile after upgrade of linux-headers-3.2.0-4 from 3.2.35-2 to 3.2.39-2

[Tomasz Wierzbicki]

Package: virtualbox-guest-dkms
Version: 4.1.18-dfsg-2
Severity: important

Dear Maintainer,

Making dpkg-reconfigure on virtualbox-guest-dkms gives the following error:

Loading new virtualbox-guest-4.1.18 DKMS files...
Building only for 3.2.0-4-amd64
Building initial module for 3.2.0-4-amd64
Error! Bad return status for module build on kernel: 3.2.0-4-amd64 (x86_64)
Consult /var/lib/dkms/virtualbox-guest/4.1.18/build/make.log for more
information.

The make.log says (full contents of the file attached to the report):

[...]
CC [M] /var/lib/dkms/virtualbox-guest/4.1.18/build/vboxvideo/vboxvideo_drm.o
[...]
/var/lib/dkms/virtualbox-guest/4.1.18/build/vboxvideo/vboxvideo_drm.c:115:9:
error: field name not in record or union initializer

It seems this is the same problem that occurred earlier in RHEL: since
linux-3.3.0-rc1 drm_driver::fops is a pointer, but this change was
backported to erlier versions of the kernel, which the code in vboxvideo_drm.c
does
not recognize (it tests only wheather LINUX_VERSION_CODE <
KERNEL_VERSION(3,3,0)).
Indeed, when I replaced the offending file vboxvideo_drm.c with the following
downloaded
from the internet:

https://www.virtualbox.org/svn/vbox/trunk/src/VBox/Additions/linux/drm/vboxvideo_drm.c

and added the following line to it:

#define DRM_RHEL63

then the compilation went successfully.

I recreated the problem and report it from my virtualbox host system (although
installing guest additions in a host system makes little sense),
but the errors occurring during installation on the guest system (despite a
different architecture: pae instead of amd64) were identical.





-- System Information:
Debian Release: 7.0
APT prefers testing
APT policy: (901, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

[Roger Leigh]

severity 703358 serious
thanks

On Mon, Mar 18, 2013 at 08:06:29PM +0100, Tomasz Wierzbicki wrote:
> Making dpkg-reconfigure on virtualbox-guest-dkms gives the following error:
>
> Loading new virtualbox-guest-4.1.18 DKMS files...
> Building only for 3.2.0-4-amd64
> Building initial module for 3.2.0-4-amd64
> Error! Bad return status for module build on kernel: 3.2.0-4-amd64 (x86_64)
> Consult /var/lib/dkms/virtualbox-guest/4.1.18/build/make.log for more
> information.

Having virtualbox kernel modules broken out of the box for wheezy
isn't ideal. Looks like this broke relatively recently; increasing
the severity.

VirtualBox maintainers: would backporting the necessary bits be
possible to make it buildable with the wheezy kernel?


Thanks,
Roger

--
.''`. Roger Leigh
: :' : Debian GNU/Linux http://people.debian.org/~rleigh/
`. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools
`- GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org

[Felix Geyer]

On 20.03.2013 23:15, Roger Leigh wrote:
> severity 703358 serious
> thanks
>
> On Mon, Mar 18, 2013 at 08:06:29PM +0100, Tomasz Wierzbicki wrote:
>> Making dpkg-reconfigure on virtualbox-guest-dkms gives the following error:
>>
>> Loading new virtualbox-guest-4.1.18 DKMS files...
>> Building only for 3.2.0-4-amd64
>> Building initial module for 3.2.0-4-amd64
>> Error! Bad return status for module build on kernel: 3.2.0-4-amd64 (x86_64)
>> Consult /var/lib/dkms/virtualbox-guest/4.1.18/build/make.log for more
>> information.
> Having virtualbox kernel modules broken out of the box for wheezy
> isn't ideal. Looks like this broke relatively recently; increasing
> the severity.

This is caused by
* Backport drm and agp subsystems from Linux 3.4.29 (closes: #687442)
from linux 3.2.39-1 (2013-02-25).

> VirtualBox maintainers: would backporting the necessary bits be
> possible to make it buildable with the wheezy kernel?

The kernel module already supports kernel 3.4. The problem is detecting
that the 3.2 kernel contains a backported drm subsystem.

VirtualBox has this code to detect the backported drm subsystem in RHEL:

> # if RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(6,3)
> # define DRM_RHEL63
> # endif

Ideally we could use a similar check for Debian.
As a last resort I could forcefully define DRM_RHEL63 but that would break
pre-3.4 custom kernels.

Regards,
Felix