Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#1019347: Backups end up mostly empty when location.patterns is used and /root/.borgmatic exists
27 views
Skip to first unread message
Sven Bartscher
Sep 7, 2022, 1:00:04 PM9/7/22
to
Package: borgmatic
Version: 1.5.12-2
Severity: grave
Tags: upstream fixed-upstream
Forwarded: https://projects.torsion.org/borgmatic-collective/borgmatic/issues/574
Control: found -1 1.6.3-1
Hi,
Recently I reported the bug mentioned above upstream, which causes
most data to be silently excluded from backups if /root/.borgmatic
exists. Since details of the bug are already available in the upstream
bug report, I will omit them here for brevity.
Since the issue has already been fixed upstream, this bug is only
meant to track the issue in Debian.
I've set the severity to grave, because the bug causes borgmatic to
produce effectively empty backups, while the user may believe to have
secure backups, which qualifies as data loss to me. Feel free to lower
the severity to normal if you disagree.
Regards
Sven
-- System Information:
Debian Release: bookworm/sid
APT prefers testing-debug
APT policy: (990, 'testing-debug'), (990, 'testing'), (102, 'unstable-debug'), (102, 'unstable'), (101, 'experimental-debug'), (101, 'experimental')
merged-usr: no
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.18.0-4-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages borgmatic depends on:
ii borgbackup 1.2.1-2
ii python3 3.10.6-1
ii python3-colorama 0.4.5-2
ii python3-jsonschema 4.6.0-3
ii python3-pkg-resources 59.6.0-1.2
ii python3-requests 2.27.1+dfsg-1
ii python3-ruamel.yaml 0.17.16-1
borgmatic recommends no packages.
borgmatic suggests no packages.
-- no debconf information
Version: 1.5.12-2
Severity: grave
Tags: upstream fixed-upstream
Forwarded: https://projects.torsion.org/borgmatic-collective/borgmatic/issues/574
Control: found -1 1.6.3-1
Hi,
Recently I reported the bug mentioned above upstream, which causes
most data to be silently excluded from backups if /root/.borgmatic
exists. Since details of the bug are already available in the upstream
bug report, I will omit them here for brevity.
Since the issue has already been fixed upstream, this bug is only
meant to track the issue in Debian.
I've set the severity to grave, because the bug causes borgmatic to
produce effectively empty backups, while the user may believe to have
secure backups, which qualifies as data loss to me. Feel free to lower
the severity to normal if you disagree.
Regards
Sven
-- System Information:
Debian Release: bookworm/sid
APT prefers testing-debug
APT policy: (990, 'testing-debug'), (990, 'testing'), (102, 'unstable-debug'), (102, 'unstable'), (101, 'experimental-debug'), (101, 'experimental')
merged-usr: no
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.18.0-4-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages borgmatic depends on:
ii borgbackup 1.2.1-2
ii python3 3.10.6-1
ii python3-colorama 0.4.5-2
ii python3-jsonschema 4.6.0-3
ii python3-pkg-resources 59.6.0-1.2
ii python3-requests 2.27.1+dfsg-1
ii python3-ruamel.yaml 0.17.16-1
borgmatic recommends no packages.
borgmatic suggests no packages.
-- no debconf information
Iustin Pop
Sep 14, 2022, 5:10:04 PM9/14/22
to
From what I see, upstream version 1.7.1 fixes this
(https://github.com/borgmatic-collective/borgmatic/releases/tag/1.7.1):
#574: Fix for potential data loss (data not getting backed up) when the "patterns" option was
used with "source_directories" (or the "~/.borgmatic" path existed, which got injected into
"source_directories" implicitly). The fix is for borgmatic to convert "source_directories" into
patterns whenever "patterns" is used, working around a potential Borg bug:
borgbackup/borg#6994
Could you please package that (or the newer 1.7.2) to work around this?
thanks!
iustin
(https://github.com/borgmatic-collective/borgmatic/releases/tag/1.7.1):
#574: Fix for potential data loss (data not getting backed up) when the "patterns" option was
used with "source_directories" (or the "~/.borgmatic" path existed, which got injected into
"source_directories" implicitly). The fix is for borgmatic to convert "source_directories" into
patterns whenever "patterns" is used, working around a potential Borg bug:
borgbackup/borg#6994
Could you please package that (or the newer 1.7.2) to work around this?
thanks!
iustin
Sven Bartscher
Oct 7, 2022, 10:40:11 AM10/7/22
to
Hi,
I just noticed that the current upstream release 1.7.2 still has a bug
very similar to this bug present.
(https://projects.torsion.org/borgmatic-collective/borgmatic/issues/590)
It's basically the same bug, only with `patterns_from` instead of
`patterns`.
Regards
Sven
I just noticed that the current upstream release 1.7.2 still has a bug
very similar to this bug present.
(https://projects.torsion.org/borgmatic-collective/borgmatic/issues/590)
It's basically the same bug, only with `patterns_from` instead of
`patterns`.
Regards
Sven
Sven Bartscher
Oct 16, 2022, 5:11:12 PM10/16/22
to
Hi,
I just wanted to give a heads up, that earlier today I uploaded an NMU
to DELAYED+5 containing upstream version 1.7.4 which should fix this bug.
I pushed the changes to the packaging repository on salsa, so I assume a
debdiff of the NMU is not required here.
Regards
Sven
I just wanted to give a heads up, that earlier today I uploaded an NMU
to DELAYED+5 containing upstream version 1.7.4 which should fix this bug.
I pushed the changes to the packaging repository on salsa, so I assume a
debdiff of the NMU is not required here.
Regards
Sven
0 new messages