Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#985424: vorta: "Backup successful" notification even if return code is 1
48 views
Skip to first unread message
Sandro Tosi
Mar 17, 2021, 9:00:03 PM3/17/21
to
Package: vorta
Version: 0.7.5-1
Severity: normal
Hello,
i have a few unaccessible files, so vorta during the backup records that, and
the backup itself finished with a return code of 1.
but the notification says "backup successful" -- that's rather confusing
- does the return code of the backup not indicate the success or not of the
backup?
- will the backup end up not being succesful only if a specific list of return
codes are returned?
Regards,
Sandro
-- System Information:
Debian Release: 10.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.10.0-4-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages vorta depends on:
ii python3 3.9.2-2
ii python3-appdirs 1.4.3-1
ii python3-apscheduler 3.6.3-1
ii python3-dateutil 2.7.3-3
ii python3-paramiko 2.7.1-2
ii python3-peewee 3.13.1+dfsg-1+b3
ii python3-pkg-resources 46.1.3-1
ii python3-psutil 5.7.3-1
ii python3-pyqt5 5.15.2+dfsg-1+b1
ii python3-pyqt5.qsci 2.11.6+dfsg-1
ii python3-secretstorage 2.3.1-2
Versions of packages vorta recommends:
ii borgbackup 1.1.14-3
vorta suggests no packages.
-- no debconf information
Version: 0.7.5-1
Severity: normal
Hello,
i have a few unaccessible files, so vorta during the backup records that, and
the backup itself finished with a return code of 1.
but the notification says "backup successful" -- that's rather confusing
- does the return code of the backup not indicate the success or not of the
backup?
- will the backup end up not being succesful only if a specific list of return
codes are returned?
Regards,
Sandro
-- System Information:
Debian Release: 10.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.10.0-4-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages vorta depends on:
ii python3 3.9.2-2
ii python3-appdirs 1.4.3-1
ii python3-apscheduler 3.6.3-1
ii python3-dateutil 2.7.3-3
ii python3-paramiko 2.7.1-2
ii python3-peewee 3.13.1+dfsg-1+b3
ii python3-pkg-resources 46.1.3-1
ii python3-psutil 5.7.3-1
ii python3-pyqt5 5.15.2+dfsg-1+b1
ii python3-pyqt5.qsci 2.11.6+dfsg-1
ii python3-secretstorage 2.3.1-2
Versions of packages vorta recommends:
ii borgbackup 1.1.14-3
vorta suggests no packages.
-- no debconf information
Nicholas D Steeves
Apr 16, 2021, 9:50:04 PM4/16/21
to
Control: forwarded -1 https://github.com/borgbase/vorta/issues/916
Control: severity -1 important
Hi Sandro!
Sorry for my delay replying, and thank you *very much* for reporting
this bug.
Sandro Tosi <mo...@debian.org> writes:
> Package: vorta
> Version: 0.7.5-1
> Severity: normal
>
> Hello,
> i have a few unaccessible files, so vorta during the backup records that, and
> the backup itself finished with a return code of 1.
>
> but the notification says "backup successful" -- that's rather confusing
>
> - does the return code of the backup not indicate the success or not of the
> backup?
> - will the backup end up not being succesful only if a specific list of return
> codes are returned?
>
I've bumped the severity of this bug, because it sounds like it's not
clear that Vorta assumes that a backup consists solely of $USER
accessible paths, and this may result in the following case:
1. User adds / as a source
2. "backup successful"
3. Catastrophic system failure
4. Restoring from backup results in a broken Debian installation
5. User feels betrayed, Debian reputation for reliability suffers, trust
in Vorta suffers.
IMHO backup software reliability is like a file system reliability or
anything email-related--unexpected behaviour or bugs that result in an
incomplete dataset will prejudice the user against the software
forever.
To be fair, upstream is open about this limitation, but it sounds like
it's not visible enough, and permission checks are--after all--a
cornerstone of correct design ;-)
Regards,
Nicholas
Control: severity -1 important
Hi Sandro!
Sorry for my delay replying, and thank you *very much* for reporting
this bug.
Sandro Tosi <mo...@debian.org> writes:
> Package: vorta
> Version: 0.7.5-1
> Severity: normal
>
> Hello,
> i have a few unaccessible files, so vorta during the backup records that, and
> the backup itself finished with a return code of 1.
>
> but the notification says "backup successful" -- that's rather confusing
>
> - does the return code of the backup not indicate the success or not of the
> backup?
> - will the backup end up not being succesful only if a specific list of return
> codes are returned?
>
clear that Vorta assumes that a backup consists solely of $USER
accessible paths, and this may result in the following case:
1. User adds / as a source
2. "backup successful"
3. Catastrophic system failure
4. Restoring from backup results in a broken Debian installation
5. User feels betrayed, Debian reputation for reliability suffers, trust
in Vorta suffers.
IMHO backup software reliability is like a file system reliability or
anything email-related--unexpected behaviour or bugs that result in an
incomplete dataset will prejudice the user against the software
forever.
To be fair, upstream is open about this limitation, but it sounds like
it's not visible enough, and permission checks are--after all--a
cornerstone of correct design ;-)
Regards,
Nicholas
Nicholas D Steeves
Aug 18, 2021, 3:10:04 PM8/18/21
to
Hi Sandro,
Sandro Tosi <mo...@debian.org> writes:
> Package: vorta
> Version: 0.7.5-1
> Severity: normal
>
> Hello,
> i have a few unaccessible files, so vorta during the backup records that, and
> the backup itself finished with a return code of 1.
>
> but the notification says "backup successful" -- that's rather confusing
>
> - does the return code of the backup not indicate the success or not of the
> backup?
> - will the backup end up not being succesful only if a specific list of return
> codes are returned?
>
I just uploaded 0.7.7-1, but I'm not convinced that upstream's chosen
implementation sufficiently addresses this bug. Would you please give
it a try and let me know what you think?
Cheers,
Nicholas
Sandro Tosi <mo...@debian.org> writes:
> Package: vorta
> Version: 0.7.5-1
> Severity: normal
>
> Hello,
> i have a few unaccessible files, so vorta during the backup records that, and
> the backup itself finished with a return code of 1.
>
> but the notification says "backup successful" -- that's rather confusing
>
> - does the return code of the backup not indicate the success or not of the
> backup?
> - will the backup end up not being succesful only if a specific list of return
> codes are returned?
>
implementation sufficiently addresses this bug. Would you please give
it a try and let me know what you think?
Cheers,
Nicholas
Nicholas D Steeves
Jan 26, 2022, 7:40:04 PM1/26/22
to
tag moreinfo 987074
tag moreinfo 985424
tag moreinfo 987073
thanks
Please confirm if 0.8.2 (just uploaded) is affected.
tag moreinfo 985424
tag moreinfo 987073
thanks
Please confirm if 0.8.2 (just uploaded) is affected.
Nicholas D Steeves
Jan 26, 2022, 8:10:04 PM1/26/22
to
tag 987074 moreinfo
tag 985424 moreinfo
tag 987073 moreinfo
thanks
Please confirm if 0.8.2 (just uploaded) is affected. Sorry about the
noise in the last email.
tag 985424 moreinfo
tag 987073 moreinfo
thanks
Please confirm if 0.8.2 (just uploaded) is affected. Sorry about the
noise in the last email.
0 new messages