Bug#1012474: [PATCH] Xsession does not recognise shell builtins as session-type

[Brendan O'Dea]

Package: x11-common
Version: 1:7.7+23
Severity: normal
Tags: patch
X-Debbugs-Cc: b...@debian.org

A recent change[1] to 20x11-common_process-args causes
"/etc/X11/Xsession true" to pop up an xmessage error, followed by
running the default session.

The default xpra configuration contains such an invocation in order to
run /etc/X11/Xsession.d/* without actually running ~/.xsession.

The reason is that "command -v true" returns "true", which fails the
test for both -e and -x.

Given that "command -v program" already checks if program exists and is
executable, then the test may be simplified to just that invocation.

[1] https://salsa.debian.org/xorg-team/xorg/-/commit/3d6bd60c17ff052fc3f35eb0f17553fcf3d0b23f

-- System Information:
Debian Release: bookworm/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.17.0-2-686-pae (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages x11-common depends on:
ii lsb-base 11.2

x11-common recommends no packages.

x11-common suggests no packages.

-- no debconf information

[Vassilis Virvilis]

Thanks for this patch.

For months and months I had to go through the click + click ordeal in order to access the remote session.

I would note that it has to be applied in the client.

Thanks again.

Vassilis