Bug#559618: boswars: Toggling Fullscreen with the space key in Video Options makes it change back immediately
Kalle Olavi Niemitalo
Version: 2.5-2
Severity: minor
In the Video Options screen of BOS Wars, there is a check box labeled Fullscreen. If I press the Tab key enough times to move the focus to that, and then press the Space key, the game indeed switches to full-screen mode but then immediately switches back to windowed mode. Likewise, if I have checked the box with a pointing device and then press the Space key, the game switches to windowed mode but immediately back to full-screen mode.
Severity = minor because changing the check box with a pointing device works OK and this game practically requires one anyway.
I run a custom build of Mesa here to enable r600 support. That should however have no effect on this bug because I did not enable OpenGL in BOS Wars.
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (900, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.31-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages boswars depends on:
ii boswars-data 2.5-2 Images, data, and music files for
ii libc6 2.10.2-2 GNU C Library: Shared libraries
ii libgcc1 1:4.4.2-3 GCC support library
ii libgl1-mesa-glx [libgl 7.6-1.kon.1 A free implementation of the OpenG
ii liblua5.1-0 5.1.4-5 Simple, extensible, embeddable pro
ii libogg0 1.1.4~dfsg-1 Ogg bitstream library
ii libpng12-0 1.2.41-1 PNG library - runtime
ii libsdl1.2debian 1.2.13-5 Simple DirectMedia Layer
ii libstdc++6 4.4.2-3 The GNU Standard C++ Library v3
ii libtheora0 1.1.1-2 The Theora Video Compression Codec
ii libvorbis0a 1.2.3-3 The Vorbis General Audio Compressi
ii libx11-6 2:1.3.2-1 X11 client-side library
ii zlib1g 1:1.2.3.3.dfsg-15 compression library - runtime
boswars recommends no packages.
boswars suggests no packages.
-- no debconf information
Kalle Olavi Niemitalo
I debugged this now (over ssh so I could set breakpoints without
causing keyboard events) and found that the keypress event gets
duplicated in gcn::SDLInput::processKeyRepeat, thus causing two
separate calls to the Lua code and ultimately to ToggleFullScreen.
I guess the video mode switch takes so long that Bos Wars thinks
they key should repeat ... even though it has actually been
released already. The easiest fix might be to make the checkbox
widget change its state not on key press events but rather on key
release events, which are not duplicated in this way.
It would be cleaner not to generate the repeated events in the
first place, but I don't know how difficult it would be to detect
at that point of time that the key has already been released. It
might be just a matter of asking SDL or it might not; the
checkbox widget change would be easier to get reliably right.
Alexandre Detiste
This has been fixed upstream:
https://codeberg.org/boswars/boswars/commit/0ef4a1afe890d6c0cddc7393a0e29ecea274c054