Bug#1008708: pysolfc: After installing python3.10, pysolfc cannot start

[Roger D. Cook]

Package: pysolfc
Version: 2.6.4-3
Severity: grave
Tags: newcomer
Justification: renders package unusable

Dear Maintainer,

1. Attempted to start pysolfc through the menus; it failed to start.
2. Attempted to start from the command line; it failed to start with
the following messaging:

$ pysolfc
Traceback (most recent call last):
File "/usr/games/pysolfc", line 36, in <module>
from pysollib.main import main # noqa: E402,I202
File "/usr/share/games/pysolfc/pysollib/main.py", line 30, in <module>
from pysollib.app import Application
File "/usr/share/games/pysolfc/pysollib/app.py", line 32, in <module>
from pysollib.images import Images, SubsampledImages
File "/usr/share/games/pysolfc/pysollib/images.py", line 28, in <module>
from pysollib.pysoltk import copyImage, createBottom, createImage, loadImage
File "/usr/share/games/pysolfc/pysollib/pysoltk.py", line 35, in <module>
from pysollib.tile.tkhtml import * # noqa: F401,F403
File "/usr/share/games/pysolfc/pysollib/tile/tkhtml.py", line 29, in <module>
from pysollib.ui.tktile.tkhtml import Base_HTMLViewer
File "/usr/share/games/pysolfc/pysollib/ui/tktile/tkhtml.py", line 24, in <module>
import formatter
ModuleNotFoundError: No module named 'formatter'
$

Expected result is that the game starts.

After researching, I came across https://github.com/shlomif/PySolFC/issues/217
and https://github.com/shlomif/PySolFC/pull/218, which:
a) explained that the formatter module was deprecated in Python 3.4 and
removed in 3.10, and
b) fixed the issue upstream in PySolFC version 2.14, released September 9,
2021.

I believe the best fix is to import the newest version of pysolfc to the
Debian ecosystem.

-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.16.0-5-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages pysolfc depends on:
ii python3 3.10.4-1
ii python3-configobj 5.0.6-5
ii python3-pygame 2.1.2+dfsg-3
ii python3-random2 1.0.1-2.1
ii python3-six 1.16.0-3
ii python3-tk 3.9.12-1

Versions of packages pysolfc recommends:
ii python3-pil.imagetk 9.0.1-1

Versions of packages pysolfc suggests:
ii freecell-solver-bin 5.0.0-2+b1
ii pysolfc-cardsets 2.0+dfsg2-2.1

-- no debconf information

[Athos Ribeiro]

Hi,

First of all, IANAL.

As I commented in a similar bug in Ubuntu [1], while the fix for this
issue is available upstream and seems technically straightforward, it
injects a deprecated python module in its code base and re-licenses it
as CC0. The PSF license suggests "that PSF's License Agreement and PSF's
notice of copyright [...] are retained in Python alone or in any
derivative version" and that "in the event Licensee prepares a
derivative work that is based on or incorporates Python or any part
thereof [...], then Licensee hereby agrees to include in any such work a
brief summary of the changes made to Python."

[1] https://bugs.launchpad.net/ubuntu/+source/pysolfc/+bug/1967793/comments/8


--
Athos Ribeiro