Bug#665791: libnm-glib4: causes a segfault in gnome-shell

10 views
Skip to first unread message

Antti-Juhani Kaijanaho

unread,
Mar 26, 2012, 3:00:02 AM3/26/12
to
Package: libnm-glib4
Version: 0.9.4.0-1
Severity: important

Since upgrading to this version, gnome-shell has been crashing for me.

Downgrading to 0.9.2.0-2 makes the issue go away. So does, bizarrely,
rebuilding 0.9.4.0-1 with nostrip noopt (which I did to try to get a useful
backtrace).

By the way, a -dbg package would have been nice :-)

I rebuilt this package with nostrip (but without noopt) and obtained a
backtrace by logging in using "GNOME Classic" and then running at the console
DISPLAY=0:0 gdb --args /usr/bin/gnome-shell --replace
then asking for a backtrace after the segfault had occurred:

#0 0x00007fffee0274c7 in g_error_matches (error=0x1, domain=2155, code=4) at /tmp/buildd/glib2.0-2.30.2/./glib/gerror.c:509
No locals.
#1 0x00007ffff434fe36 in _nm_remote_settings_ensure_inited (self=0x10a4140) at nm-remote-settings.c:119
priv = 0x10a4160
error = 0x1
__func__ = "_nm_remote_settings_ensure_inited"
#2 0x00007ffff4351775 in nm_remote_settings_list_connections (settings=<optimized out>) at nm-remote-settings.c:480
priv = 0x10a4160
list = 0x0
iter = {dummy1 = 0x7fffffffd060, dummy2 = 0x10b4500, dummy3 = 0xffffffff, dummy4 = -153602442, dummy5 = 32767, dummy6 = 0x7fffffff00000011}
value = <optimized out>
__PRETTY_FUNCTION__ = "nm_remote_settings_list_connections"
#3 0x00007ffff51ae7bc in ffi_call_unix64 () from /usr/lib/x86_64-linux-gnu/libffi.so.5
No symbol table info available.
#4 0x00007ffff51ae237 in ffi_call () from /usr/lib/x86_64-linux-gnu/libffi.so.5
No symbol table info available.
#5 0x00007ffff71a8065 in ?? () from /usr/lib/libgjs.so.0
No symbol table info available.
#6 0x00007ffff71a9160 in ?? () from /usr/lib/libgjs.so.0
No symbol table info available.
#7 0x00007ffff6d013f5 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#8 0x00007ffff6ced7f2 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#9 0x00007ffff6d00d35 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#10 0x00007ffff6d011d2 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#11 0x00007ffff6cd2f21 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#12 0x00007ffff6d01253 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#13 0x00007ffff6d02083 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#14 0x00007ffff6c7af41 in JS_CallFunctionValue () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#15 0x00007ffff719bf6c in gjs_call_function_value () from /usr/lib/libgjs.so.0
No symbol table info available.
#16 0x00007ffff71a695d in gjs_closure_invoke () from /usr/lib/libgjs.so.0
No symbol table info available.
#17 0x00007ffff71afda9 in ?? () from /usr/lib/libgjs.so.0
No symbol table info available.
#18 0x00007fffee709804 in g_closure_invoke (closure=0x1091dd0, return_value=0x0, n_param_values=1, param_values=0x7fffdc0619a0,
invocation_hint=<optimized out>) at /tmp/buildd/glib2.0-2.30.2/./gobject/gclosure.c:774
marshal = 0x7ffff71afb50
marshal_data = <optimized out>
in_marshal = <optimized out>
__PRETTY_FUNCTION__ = "g_closure_invoke"
#19 0x00007fffee71b78a in signal_emit_unlocked_R (node=<optimized out>, detail=0, instance=0x10a4140, emission_return=0x0, instance_and_params=0x7fffdc0619a0)
at /tmp/buildd/glib2.0-2.30.2/./gobject/gsignal.c:3272
tmp = <optimized out>
handler = 0xf2e530
accumulator = 0x0
emission = {next = 0x0, instance = 0x10a4140, ihint = {signal_id = 370, detail = 0, run_type = G_SIGNAL_RUN_FIRST}, state = EMISSION_RUN,
chain_type = 4}
class_closure = 0x1091ec0
hlist = 0x7ffff3a516d0
handler_list = 0xf2e530
return_accu = 0x0
accu = {g_type = 0, data = {{v_int = 0, v_uint = 0, v_long = 0, v_ulong = 0, v_int64 = 0, v_uint64 = 0, v_float = 0, v_double = 0, v_pointer = 0x0}, {
v_int = 0, v_uint = 0, v_long = 0, v_ulong = 0, v_int64 = 0, v_uint64 = 0, v_float = 0, v_double = 0, v_pointer = 0x0}}}
signal_id = 370
max_sequential_handler_number = 2980
return_value_altered = 1
#20 0x00007fffee724e11 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=<optimized out>)
at /tmp/buildd/glib2.0-2.30.2/./gobject/gsignal.c:3003
instance_and_params = 0x7fffdc0619a0
signal_return_type = 4
param_values = 0x7fffdc0619b8
node = 0x10920d0
i = <optimized out>
n_params = 0
__PRETTY_FUNCTION__ = "g_signal_emit_valist"
#21 0x00007fffee724fb2 in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>)
at /tmp/buildd/glib2.0-2.30.2/./gobject/gsignal.c:3060
var_args = {{gp_offset = 24, fp_offset = 48, overflow_arg_area = 0x7fffffffe320, reg_save_area = 0x7fffffffe260}}
#22 0x00007ffff4350f76 in fetch_connections_done (proxy=0x10f2c00, call=0x1, user_data=0x10a4140) at nm-remote-settings.c:422
self = 0x10a4140
priv = 0x10a4160
connections = <optimized out>
error = 0x0
i = <optimized out>
__func__ = "fetch_connections_done"
#23 0x00007ffff3c6fd4a in ?? () from /lib/x86_64-linux-gnu/libdbus-1.so.3
No symbol table info available.
#24 0x00007ffff3c72fda in dbus_connection_dispatch () from /lib/x86_64-linux-gnu/libdbus-1.so.3
No symbol table info available.
#25 0x00007ffff3eb3735 in ?? () from /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2
No symbol table info available.
#26 0x00007fffee03c0cf in g_main_dispatch (context=0x61cdd0) at /tmp/buildd/glib2.0-2.30.2/./glib/gmain.c:2442
dispatch = 0x7ffff3eb3720
was_in_call = 0
user_data = 0x0
callback = 0
cb_funcs = 0x0
cb_data = 0x0
current_source_link = {data = 0x643ad0, next = 0x0}
need_destroy = <optimized out>
source = 0x643ad0
current = 0xd1d850
i = <optimized out>
#27 g_main_context_dispatch (context=0x61cdd0) at /tmp/buildd/glib2.0-2.30.2/./glib/gmain.c:2998
No locals.
#28 0x00007fffee03c8c8 in g_main_context_iterate (context=0x61cdd0, block=<optimized out>, dispatch=1, self=<optimized out>)
at /tmp/buildd/glib2.0-2.30.2/./glib/gmain.c:3076
max_priority = 0
timeout = 0
some_ready = 1
nfds = 11
allocated_nfds = <optimized out>
fds = <optimized out>
#29 0x00007fffee03ce02 in g_main_loop_run (loop=0x61fd30) at /tmp/buildd/glib2.0-2.30.2/./glib/gmain.c:3284
__PRETTY_FUNCTION__ = "g_main_loop_run"
#30 0x00007ffff7416691 in meta_run () from /usr/lib/libmutter.so.0
No symbol table info available.
#31 0x0000000000402c61 in main ()
No symbol table info available.

-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.13-ibid-1 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libnm-glib4 depends on:
ii libc6 2.13-27
ii libdbus-1-3 1.4.18-1
ii libdbus-glib-1-2 0.98-1
ii libgcrypt11 1.5.0-3
ii libglib2.0-0 2.30.2-6
ii libgnutls26 2.12.18-1
ii libgudev-1.0-0 175-3.1
ii libnm-util2 0.9.4.0-1
ii libuuid1 2.20.1-4

libnm-glib4 recommends no packages.

libnm-glib4 suggests no packages.

-- no debconf information



--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org

Michael Biebl

unread,
Apr 2, 2012, 1:40:01 AM4/2/12
to
On 26.03.2012 08:49, Antti-Juhani Kaijanaho wrote:
> Package: libnm-glib4
> Version: 0.9.4.0-1
> Severity: important
>
> Since upgrading to this version, gnome-shell has been crashing for me.
>
> Downgrading to 0.9.2.0-2 makes the issue go away. So does, bizarrely,
> rebuilding 0.9.4.0-1 with nostrip noopt (which I did to try to get a useful
> backtrace).
>
> By the way, a -dbg package would have been nice :-)

apt-get install network-manager-dbg

> I rebuilt this package with nostrip (but without noopt) and obtained a
> backtrace by logging in using "GNOME Classic" and then running at the console
> DISPLAY=0:0 gdb --args /usr/bin/gnome-shell --replace
> then asking for a backtrace after the segfault had occurred:

Please test 0.9.4.0-2 which I've uploaded a few minutes ago.



--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

signature.asc

Antti-Juhani Kaijanaho

unread,
Apr 2, 2012, 4:00:02 AM4/2/12
to
Version: 0.9.4.0-2

On Mon, Apr 02, 2012 at 07:29:16AM +0200, Michael Biebl wrote:
> On 26.03.2012 08:49, Antti-Juhani Kaijanaho wrote:
> > By the way, a -dbg package would have been nice :-)
>
> apt-get install network-manager-dbg

Ah. I suppose a more thorough search might have found that. Then again, how
was I supposed to know that it contains symbols for libnm-glib4? (I see
there's a dependency, but that's an awfully subtle clue.)

Anyway, thanks.

> > I rebuilt this package with nostrip (but without noopt) and obtained a
> > backtrace by logging in using "GNOME Classic" and then running at the console
> > DISPLAY=0:0 gdb --args /usr/bin/gnome-shell --replace
> > then asking for a backtrace after the segfault had occurred:
>
> Please test 0.9.4.0-2 which I've uploaded a few minutes ago.

Still the same symptom, though the backtrace has changed:

#0 0x00007fffedc84475 in *__GI_raise (sig=<optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
pid = <optimized out>
selftid = <optimized out>
#1 0x00007fffedc876f0 in *__GI_abort () at abort.c:92
act = {__sigaction_handler = {sa_handler = 0x7fffffffbd38, sa_sigaction = 0x7fffffffbd38}, sa_mask = {__val = {140737488338208, 140737488349447, 20,
140737183862242, 3, 140737488338218, 6, 140737183862246, 2, 140737488338206, 2, 140737183853249, 1, 140737183862242, 3, 140737488338212}},
sa_flags = 12, sa_restorer = 0x7fffedd9cde6}
sigs = {__val = {32, 0 <repeats 15 times>}}
#2 0x00007fffedcbe26b in __libc_message (do_abort=<optimized out>, fmt=<optimized out>) at ../sysdeps/unix/sysv/linux/libc_fatal.c:189
ap = {{gp_offset = 40, fp_offset = 48, overflow_arg_area = 0x7fffffffc6a0, reg_save_area = 0x7fffffffc5b0}}
ap_copy = {{gp_offset = 16, fp_offset = 48, overflow_arg_area = 0x7fffffffc6a0, reg_save_area = 0x7fffffffc5b0}}
fd = 28
on_2 = <optimized out>
list = <optimized out>
nlist = 0
cp = <optimized out>
written = false
#3 0x00007fffedcc7ab6 in malloc_printerr (action=3, str=0x7fffedd9b86a "free(): invalid pointer", ptr=<optimized out>) at malloc.c:6283
buf = "0000000000f479cc"
cp = 0x0
#4 0x00007fffedccc7ec in *__GI___libc_free (mem=<optimized out>) at malloc.c:3738
ar_ptr = 0x7fffedfd4e60
p = 0x6
#5 0x00007fffee0104f2 in g_error_free (error=0xfe3b20) at /tmp/buildd/glib2.0-2.32.0/./glib/gerror.c:476
No locals.
#6 0x00007ffff3f2ad94 in _nm_remote_settings_ensure_inited (self=0xff3110) at nm-remote-settings.c:123
priv = 0xff3130
error = 0xfe3b20
__func__ = "_nm_remote_settings_ensure_inited"
#7 0x00007ffff3f2cb0a in nm_remote_settings_new (bus=<optimized out>) at nm-remote-settings.c:735
settings = 0xff3110
#8 0x00007ffff4d897bc in ffi_call_unix64 () from /usr/lib/x86_64-linux-gnu/libffi.so.5
No symbol table info available.
#9 0x00007ffff4d89237 in ffi_call () from /usr/lib/x86_64-linux-gnu/libffi.so.5
No symbol table info available.
#10 0x00007ffff71a5065 in ?? () from /usr/lib/libgjs.so.0
No symbol table info available.
#11 0x00007ffff71a6160 in ?? () from /usr/lib/libgjs.so.0
No symbol table info available.
#12 0x00007ffff6cfe3f5 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#13 0x00007ffff6cea7f2 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#14 0x00007ffff6cfdd35 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#15 0x00007ffff6cfe1d2 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#16 0x00007ffff6cd0291 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#17 0x00007ffff6cf4606 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#18 0x00007ffff6cfdd35 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#19 0x00007ffff6cff875 in ?? () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#20 0x00007ffff6c78265 in JS_EvaluateUCScriptForPrincipals () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#21 0x00007ffff6c78532 in JS_EvaluateUCScript () from /usr/lib/libmozjs185.so.1.0
No symbol table info available.
#22 0x00007ffff7195859 in gjs_context_eval () from /usr/lib/libgjs.so.0
No symbol table info available.
#23 0x00007ffff7b67ecc in ?? () from /usr/lib/gnome-shell/libgnome-shell.so
No symbol table info available.
#24 0x00007ffff73f69d0 in meta_plugin_manager_initialize () from /usr/lib/libmutter.so.0
No symbol table info available.
#25 0x00007ffff73f3969 in meta_compositor_manage_screen () from /usr/lib/libmutter.so.0
No symbol table info available.
#26 0x00007ffff74095f4 in meta_display_open () from /usr/lib/libmutter.so.0
No symbol table info available.
#27 0x00007ffff741367d in meta_run () from /usr/lib/libmutter.so.0
No symbol table info available.
#28 0x0000000000402c91 in main ()
No symbol table info available.

Versions of immediately relevant packages:

ii gnome-shell 3.2.2.1-3 graphical shell for the GNOME desktop
ii libnm-glib4 0.9.4.0-2 network management framework (GLib shared library)
ii network-manager-dbg 0.9.4.0-2 network management framework (debugging symbols)

--
Antti-Juhani Kaijanaho, Jyväskylä, Finland
http://antti-juhani.kaijanaho.fi/newblog/
signature.asc

Michael Biebl

unread,
Apr 2, 2012, 4:30:02 AM4/2/12
to
On 02.04.2012 09:38, Antti-Juhani Kaijanaho wrote:
> Version: 0.9.4.0-2
>
> On Mon, Apr 02, 2012 at 07:29:16AM +0200, Michael Biebl wrote:
>> On 26.03.2012 08:49, Antti-Juhani Kaijanaho wrote:
>>> By the way, a -dbg package would have been nice :-)
>>
>> apt-get install network-manager-dbg
>
> Ah. I suppose a more thorough search might have found that. Then again, how
> was I supposed to know that it contains symbols for libnm-glib4? (I see
> there's a dependency, but that's an awfully subtle clue.)
>
> Anyway, thanks.
>
>>> I rebuilt this package with nostrip (but without noopt) and obtained a
>>> backtrace by logging in using "GNOME Classic" and then running at the console
>>> DISPLAY=0:0 gdb --args /usr/bin/gnome-shell --replace
>>> then asking for a backtrace after the segfault had occurred:
>>
>> Please test 0.9.4.0-2 which I've uploaded a few minutes ago.
>
> Still the same symptom, though the backtrace has changed:

As this seems to be a regression between 0.9.2 and 0.9.4, could you run
git bisect on
git://anongit.freedesktop.org/NetworkManager/NetworkManager
to find the faulty commit.

Problem is, I can't reproduce the issue myself, which makes it a bit
hard to track it down.

Michael
signature.asc

Antti-Juhani Kaijanaho

unread,
Apr 2, 2012, 7:00:02 AM4/2/12
to
On Mon, Apr 02, 2012 at 10:18:57AM +0200, Michael Biebl wrote:
> As this seems to be a regression between 0.9.2 and 0.9.4, could you run
> git bisect on
> git://anongit.freedesktop.org/NetworkManager/NetworkManager
> to find the faulty commit.

Bisect blames the following commit (looks plausible to me):

commit 762df85234e7a042a2a5d31053e6cc273ae3e2ec
Author: Dan Williams <dc...@redhat.com>
Date: Wed Mar 21 12:37:39 2012 -0500

libnm-glib: ensure bindings-created objects work as expected (rh #802536)

Bindings (like GObject Introspection) almost always create objects
using g_object_new() by default and don't use our helper functions
like nm_client_new(). Thus we need to make sure that if the
object is created in that way, any property accesses or functions
that return properties ensure that the object is fully initialized,
which is what the _new() functions were supposed to do. In one
case in NMClient that was missing (getting active connections)
and wasn't happening at all in NMRemoteSettings, which are our two
entry points into libnm-glib.

This allows this python+GI sequence to return the expected active
connection list:

from gi.repository import NMClient
nmclient = NMClient.Client(dbus_path='/org/freedesktop/NetworkManager')
active = nmclient.get_active_connections()
print(active)

where previously it returned an empty list because the NMClient
wasn't fully initialized by the time nm_client_get_active_connections()
was called.
signature.asc

Antti-Juhani Kaijanaho

unread,
Apr 2, 2012, 7:40:02 AM4/2/12
to
I also tested upstream master as of 75de203. The bug remains unfixed.
signature.asc

Antti-Juhani Kaijanaho

unread,
Apr 2, 2012, 9:30:02 AM4/2/12
to
Note that #665808 (reported against gnome-shell) is likely the same bug as
this.
signature.asc

Michael Biebl

unread,
Apr 2, 2012, 7:50:01 PM4/2/12
to
On 02.04.2012 12:49, Antti-Juhani Kaijanaho wrote:
> On Mon, Apr 02, 2012 at 10:18:57AM +0200, Michael Biebl wrote:
>> As this seems to be a regression between 0.9.2 and 0.9.4, could you run
>> git bisect on
>> git://anongit.freedesktop.org/NetworkManager/NetworkManager
>> to find the faulty commit.
>
> Bisect blames the following commit (looks plausible to me):
>
> commit 762df85234e7a042a2a5d31053e6cc273ae3e2ec
> Author: Dan Williams <dc...@redhat.com>
> Date: Wed Mar 21 12:37:39 2012 -0500
>
> libnm-glib: ensure bindings-created objects work as expected (rh #802536)

Thanks a lot for your efforts! Really appreciated.

How exactly do you trigger the crash? Is this reproducible?
signature.asc

Antti-Juhani Kaijanaho

unread,
Apr 2, 2012, 11:50:01 PM4/2/12
to
On Tue, Apr 03, 2012 at 01:45:34AM +0200, Michael Biebl wrote:
> How exactly do you trigger the crash? Is this reproducible?

Crash happens several seconds after startup but before gnome-shell accepts user
input. It is reproducible without exceptions.

In bisect testing, I would reproduce the bug by logging in using Gnome Classic
and then starting gnome-shell --replace (with LD_LIBRARY_PATH pointing to the
library being tested and with DISPLAY set appropriately) in a virtual console.
Either I could log off using gnome-shell (in which case the tested library
version was good) or gnome-shell never appears and the virtual console reveals
a segfault (in which case the library version was bad).

I suspect it may be relevant that I don't have network-manager installed. I
may try to test this supposition later today.

--
Antti-Juhani Kaijanaho, Jyväskylä, Finland
http://antti-juhani.kaijanaho.fi/newblog/
http://www.flickr.com/photos/antti-juhani/

signature.asc

Michael Biebl

unread,
Apr 3, 2012, 5:10:02 AM4/3/12
to
On 03.04.2012 05:43, Antti-Juhani Kaijanaho wrote:
> On Tue, Apr 03, 2012 at 01:45:34AM +0200, Michael Biebl wrote:
>> How exactly do you trigger the crash? Is this reproducible?

>
> I suspect it may be relevant that I don't have network-manager installed. I
> may try to test this supposition later today.

Ah, right, this seems to be a duplicate of #665808 indeed, then.

I was already beginning to wonder why I didn't encounter the crash, but
I do use network-manager obviously.
signature.asc

Antti-Juhani Kaijanaho

unread,
Apr 3, 2012, 5:30:01 AM4/3/12
to
On Tue, Apr 03, 2012 at 11:06:25AM +0200, Michael Biebl wrote:
> On 03.04.2012 05:43, Antti-Juhani Kaijanaho wrote:
> > On Tue, Apr 03, 2012 at 01:45:34AM +0200, Michael Biebl wrote:
> >> How exactly do you trigger the crash? Is this reproducible?
>
> >
> > I suspect it may be relevant that I don't have network-manager installed. I
> > may try to test this supposition later today.
>
> Ah, right

Indeed, installing network-manager makes the bug disappear.
signature.asc

Antti-Juhani Kaijanaho

unread,
Apr 3, 2012, 5:40:02 AM4/3/12
to
The problem appears to be fixed now in upstream master.
I will run some tests to tell which patch fixes it.
signature.asc

Antti-Juhani Kaijanaho

unread,
Apr 3, 2012, 5:50:02 AM4/3/12
to
On Tue, Apr 03, 2012 at 12:36:04PM +0300, Antti-Juhani Kaijanaho wrote:
> The problem appears to be fixed now in upstream master.
> I will run some tests to tell which patch fixes it.

Silly me - it has to be 8bb27 as it's the only commit after my yesterday tests,
and in my tests yesterday it wasn't fixed in upstream master.
signature.asc

Antti-Juhani Kaijanaho

unread,
Apr 3, 2012, 6:10:02 AM4/3/12
to
tags 665791 + patch
thanks

On Tue, Apr 03, 2012 at 12:39:16PM +0300, Antti-Juhani Kaijanaho wrote:
> Silly me - it has to be 8bb27 as it's the only commit after my yesterday tests,
> and in my tests yesterday it wasn't fixed in upstream master.

Confirmed. I just tested this by importing that patch into the
network-manager/0.9.4.0-2 source and building and installing the resulting
libnm-glib4; the bug is gone.


commit 8bb278944496102a4afad46b53e1e8279425aaac
Author: Jiří Klimeš <jkl...@redhat.com>
Date: Mon Apr 2 16:37:55 2012 +0200

libnm-glib: initialize GError, else invalid free() crash can occur (rh #809123)

diff --git a/libnm-glib/nm-remote-settings.c b/libnm-glib/nm-remote-settings.c
index 9a81a8d..68aaeb4 100644
--- a/libnm-glib/nm-remote-settings.c
+++ b/libnm-glib/nm-remote-settings.c
@@ -109,7 +109,7 @@ static void
_nm_remote_settings_ensure_inited (NMRemoteSettings *self)
{
NMRemoteSettingsPrivate *priv = NM_REMOTE_SETTINGS_GET_PRIVATE (self);
- GError *error;
+ GError *error = NULL;

if (!priv->inited) {
if (!g_initable_init (G_INITABLE (self), NULL, &error)) {
signature.asc

Michael Biebl

unread,
Apr 3, 2012, 6:20:02 AM4/3/12
to
reassign 665808 libnm-glib4
forcemerge 665791 665808
affects 665791 gnome-shell
severity 665791 grave
thanks

On 03.04.2012 12:03, Antti-Juhani Kaijanaho wrote:
> tags 665791 + patch
> thanks
>
> On Tue, Apr 03, 2012 at 12:39:16PM +0300, Antti-Juhani Kaijanaho wrote:
>> Silly me - it has to be 8bb27 as it's the only commit after my yesterday tests,
>> and in my tests yesterday it wasn't fixed in upstream master.
>
> Confirmed. I just tested this by importing that patch into the
> network-manager/0.9.4.0-2 source and building and installing the resulting
> libnm-glib4; the bug is gone.

Perfect, thanks again for your great help!

Will release a fixed network-manager package later today.

Cheers,
Michael
signature.asc
Reply all
Reply to author
Forward
0 new messages