Bug#1042979: subversion-tools: psvn.el does not work with emacs 29.1

[OHURA Makoto]

Package: subversion-tools
Version: 1.14.2-4+b2
Severity: normal
Tags: patch
X-Debbugs-Cc: none, OHURA Makoto <oh...@debian.org>

Dear Maintainer,

After upgrading emacs 29.1, psvn.el does not work fine. Emacs 29.1 doesn't support the function, toggle-read-only. Use read-only-mode. I attach a patch to this e-mail.

Thanks.

-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.4.0-1-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages subversion-tools depends on:
ii libapr1 1.7.2-3
ii libc6 2.37-6
ii libsvn1 1.14.2-4+b2
ii subversion 1.14.2-4+b2

Versions of packages subversion-tools recommends:
ii libconfig-inifiles-perl 3.000003-2
ii libsvn-perl 1.14.2-4+b2
ii liburi-perl 5.19-2
ii postfix [mail-transport-agent] 3.8.1-2
ii rsync 3.2.7-1
ii svn2cl 0.14-3

Versions of packages subversion-tools suggests:
pn ruby-svn <none>

-- no debconf information

----
OHURA Makoto: oh...@debian.org(Debian Project)
oh...@netfort.gr.jp(LILO/Netfort)
GnuPG public key: http://www.netfort.gr.jp/~ohura/gpg.asc.txt
fingerprint: 54F6 D1B1 2EE1 81CD 65E3 A1D3 EEA2 EFA2 77DC E083
http://www.netfort.gr.jp/~ohura/

[James McCoy]

On Fri, Aug 04, 2023 at 01:18:15AM +0900, OHURA Makoto wrote:
> After upgrading emacs 29.1, psvn.el does not work fine. Emacs 29.1
> doesn't support the function, toggle-read-only. Use read-only-mode.
> I attach a patch to this e-mail.

Thanks for the patch!

> --- psvn.el.old 2023-08-04 01:00:23.460477204 +0900
> +++ psvn.el 2023-08-04 00:28:50.764059785 +0900
> @@ -2248,7 +2248,7 @@
> (setq mode-line-process 'svn-status-mode-line-process)
> (run-hooks 'svn-status-mode-hook)
> (let ((view-read-only nil))
> - (toggle-read-only 1)))
> + (read-only-mode 1)))

If we make this change, then it won't work with older emacs versions.
I'd like to send the fix upstream, but would need this resolved first.

Is it possible to make these changes compatible with both old and new
emacs?

Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB