Bug#718861: magit: Compilation errors with emacs-snapshot

[Axel Beckert]

Package: magit
Version: 1.2.0-1
Severity: normal

Dear Magit Maintainers,

emacs-snapshot (2:20130804-1 from the unstable repo of
http://emacs.naquadah.org/) currently fails to install on my Sid
machines. It seems that magit is the cause (or at least one of the
causes):

[…]
Loading /etc/emacs/site-start.d/51oneliner-el.el (source)...
Error while loading 51oneliner-el: Cannot open load file: no such file or directory, oneliner
Eager macro-expansion failure: (wrong-type-argument listp 769)

In toplevel form:
magit-topgit.el:25:1:Error: Wrong type argument: listp, 769

In toplevel form:
magit.el:792:27:Error: Wrong type argument: listp, 769
Eager macro-expansion failure: (wrong-type-argument listp 769)

In toplevel form:
magit-key-mode.el:1:1:Error: Wrong type argument: listp, 769
Eager macro-expansion failure: (wrong-type-argument listp 769)

In toplevel form:
magit-svn.el:30:1:Error: Wrong type argument: listp, 769
Eager macro-expansion failure: (wrong-type-argument listp 769)

In toplevel form:
magit-bisect.el:1:1:Error: Wrong type argument: listp, 769
Eager macro-expansion failure: (wrong-type-argument listp 769)

In toplevel form:
magit-stgit.el:42:1:Error: Wrong type argument: listp, 769
Wrote /usr/share/emacs-snapshot/site-lisp/magit/magit-classic-theme.elc
Eager macro-expansion failure: (wrong-type-argument listp 769)

In toplevel form:
magit-simple-keys.el:26:1:Error: Wrong type argument: listp, 769
Wrote /usr/share/emacs-snapshot/site-lisp/magit/rebase-mode.elc
Eager macro-expansion failure: (wrong-type-argument listp 769)

In toplevel form:
magit-wip.el:49:1:Error: Wrong type argument: listp, 769
Eager macro-expansion failure: (wrong-type-argument listp 769)

In toplevel form:
magit-blame.el:34:1:Error: Wrong type argument: listp, 769
ERROR: install script from magit package failed

(I'm reporting this in Debian as this issue will likely show up with
Debian's official GNU Emacs package, later, too.)

-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (990, 'unstable'), (900, 'testing'), (899, 'testing-proposed-updates'), (600, 'stable'), (500, 'proposed-updates'), (200, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.10-1-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages magit depends on:
ii dpkg 1.17.1
ih emacs-snapshot 2:20130804-1
ii emacs23 23.4+1-4.1
ii emacs24 24.3+1-1.1
ii git [git-core] 1:1.8.4~rc1-1
ii git-core 1:1.8.4~rc1-1
ii install-info 5.1.dfsg.1-4

magit recommends no packages.

magit suggests no packages.

-- no debconf information


--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org

[Timo Juhani Lindfors]

Axel Beckert <a...@debian.org> writes:
> emacs-snapshot (2:20130804-1 from the unstable repo of
> http://emacs.naquadah.org/) currently fails to install on my Sid
> machines. It seems that magit is the cause (or at least one of the
> causes):
>

> In toplevel form:
> magit.el:792:27:Error: Wrong type argument: listp, 769
> Eager macro-expansion failure: (wrong-type-argument listp 769)

Quick googling suggests that this could be fixed by

https://github.com/magit/magit/commit/ff24d86ef9ee5cb76e08b9ba115f6c92e8c5ec2e

commit ff24d86ef9ee5cb76e08b9ba115f6c92e8c5ec2e
Author: Jonas Bernoulli <jo...@bernoul.li>
Date: Sun Jun 23 18:35:10 2013 +0200

magit-delete-directory: use copy of tramp-compat-delete-directory

Previously we determined the number of arguments `delete-directory'
accepts at compile time and defined this function accordingly. Now
`magit-delete-directory' assume `delete-directory' supports RECURSIVE
and only if that causes `wrong-number-of-arguments' it does the
recursive delete itself.

This fixes #684. The old code broke on 24.3.50 and also was more noisy
and ugly than what we have now.

[Timo Juhani Lindfors]

Axel Beckert <a...@debian.org> writes:
> emacs-snapshot (2:20130804-1 from the unstable repo of
> http://emacs.naquadah.org/) currently fails to install on my Sid
> machines. It seems that magit is the cause (or at least one of the
> causes):
>

> In toplevel form:
> magit.el:792:27:Error: Wrong type argument: listp, 769
> Eager macro-expansion failure: (wrong-type-argument listp 769)

thanks for the report. If you have time it'd be really nice to know if
this occurs with upstream git version. They seem to have made 745
commits since the last release:

https://github.com/magit/magit