Bug#1053128: smbclient: "smbtree -N" causes a segfault when "server min protocol = NT1"

[Dmitry]

Package: smbclient
Version: 2:4.17.10+dfsg-0+deb12u1
Severity: important
X-Debbugs-Cc: dmitry.s...@gmail.com

Dear Maintainer,

* What led up to the situation?

1. apt install samba smbclient
2. nano /etc/samba/smb.conf
3. I added the line "server min protocol = NT1" after [global].
4. I saved the file and closed the editor.
5. testparm -s
6. systemctl restart smbd nmbd
7. smbtree -N --option="client min protocol=NT1"

* What was the outcome of this action?

PANIC (pid 2395): Signal 11: Segmentation fault in 4.17.10-Debian
BACKTRACE: 14 stack frames:
#0 /usr/lib/x86_64-linux-gnu/samba/libgenrand-samba4.so.0(log_stack_trace+0x2e) [0x7fc8789c955e]
#1 /usr/lib/x86_64-linux-gnu/samba/libgenrand-samba4.so.0(smb_panic+0x9) [0x7fc8789c97b9]
#2 /usr/lib/x86_64-linux-gnu/samba/libgenrand-samba4.so.0(+0x1851) [0x7fc8789c9851]
#3 /lib/x86_64-linux-gnu/libc.so.6(+0x3bfd0) [0x7fc878b32fd0]
#4 /lib/x86_64-linux-gnu/libbsd.so.0(strlcpy+0x10) [0x7fc878ce45e0]
#5 /lib/x86_64-linux-gnu/libsmbclient.so.0(+0x14280) [0x7fc878f3b280]
#6 /lib/x86_64-linux-gnu/libsmbclient.so.0(+0x14809) [0x7fc878f3b809]
#7 /lib/x86_64-linux-gnu/libsmbclient.so.0(+0x1491c) [0x7fc878f3b91c]
#8 /lib/x86_64-linux-gnu/libsmbclient.so.0(+0x15430) [0x7fc878f3c430]
#9 /lib/x86_64-linux-gnu/libsmbclient.so.0(+0xd187) [0x7fc878f34187]
#10 smbtree(main+0x25a) [0x564c2a2bb68a]
#11 /lib/x86_64-linux-gnu/libc.so.6(+0x271ca) [0x7fc878b1e1ca]
#12 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x85) [0x7fc878b1e285]
#13 smbtree(_start+0x21) [0x564c2a2bbb11]
smb_panic(): calling panic action [/usr/share/samba/panic-action 2395]
smb_panic(): action returned status 0
Can not dump core: corepath not set up

* What outcome did you expect instead?

Display network resources without crashing.

p.s. Without "-N" the utility works correctly.


-- System Information:
Debian Release: 12.1
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-12-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages smbclient depends on:
ii libarchive13 3.6.2-1
ii libbsd0 0.11.7-2
ii libc6 2.36-9+deb12u1
ii libgnutls30 3.7.9-2
ii libpopt0 1.19+dfsg-1
ii libreadline8 8.2-1.3
ii libsmbclient 2:4.17.10+dfsg-0+deb12u1
ii libtalloc2 2.4.0-f2
ii libtevent0 0.14.1-1
ii samba-common 2:4.17.10+dfsg-0+deb12u1
ii samba-libs 2:4.17.10+dfsg-0+deb12u1

smbclient recommends no packages.

Versions of packages smbclient suggests:
pn cifs-utils <none>
pn heimdal-clients <none>

-- no debconf information

[Dmitry Telegin]

I found this bug in samba:
Bug 15170 - smbtree seg fault if using -N option.
https://bugzilla.samba.org/show_bug.cgi?id=15170

I checked this error in CentOS Stream 9 (samba 4.18.6-100.el9) -
successfully reproduced.

[Michael Tokarev]

Control: found -1 2:4.19.4+dfsg-2
Control: tag -1 + confirmed upstream

This is still happening with 4.19.4, fwiw.

/mjt