Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#1063270: xen: NMU diff for 64-bit time_t transition
0 views
Skip to first unread message
Maximilian Engelhardt
Feb 8, 2024, 5:50:04 PM2/8/24
to
Control: found -1 4.17.2+76-ge1f9cb16e2-1
Hi Steve,
Thanks for taking care about the 64-bit time_t transition.
Unfortunately your attached patch looks a bit strange to me. It adds
autogenerated files, but especially FTBFS in your experimental upload.
You can find an updated patch attached to this mail that only contains the
relevant changes and does the rename in one more place to fix the FTBFS.
With this mail I also mark the xen version currently in testing as affected so
this bug does not prevent the migration of the xen version currently in
unstable (4.17.3+10-g091466ba55-1).
I also did compile xen in qemu for armhf one time with the current unstable
version and one time with the change below to test the time_t transition.
The resulting binaries were the same (thanks xen is buildable reproducibly).
So maybe the transition is not needed for xen, but unfortunately my knowledge
is not that much that I can say this for sure.
--- a/debian/rules
+++ b/debian/rules
@@ -12,6 +12,10 @@ export DEB_VERSION
# DEB_MAINTAINER is used by our delta queue
export DEB_MAINTAINER := $(shell sed -ne 's/^Maintainer: \(.*\)$$/\1/p' debian/control)
+export DEB_BUILD_OPTIONS=abi=+lfs
+export _FILE_OFFSET_BITS=64
+export _TIME_BITS=64
+
# This influences dpkg-buildflags to specify better linker
# options. See https://wiki.debian.org/Hardening
# Apparently some of these might incur silent breakage
@@ -26,7 +30,7 @@ export DEB_MAINTAINER := $(shell sed -ne 's/^Maintainer: \(.*\)$$/\1/p' debian/c
# Inexplicably, if you tell make `export V=value' and `$(shell ...)'
# it does not pass V to the shell. WTF. So we set a variable
# dbmo which we include in the relevant $(shell ...) invocations.
-dbmo= DEB_BUILD_MAINT_OPTIONS="hardening=+all"
+dbmo= DEB_BUILD_MAINT_OPTIONS="hardening=+all abi=+lfs" _FILE_OFFSET_BITS=64 _TIME_BITS=64
# Architecture handling.
#
Hi Steve,
Thanks for taking care about the 64-bit time_t transition.
Unfortunately your attached patch looks a bit strange to me. It adds
autogenerated files, but especially FTBFS in your experimental upload.
You can find an updated patch attached to this mail that only contains the
relevant changes and does the rename in one more place to fix the FTBFS.
With this mail I also mark the xen version currently in testing as affected so
this bug does not prevent the migration of the xen version currently in
unstable (4.17.3+10-g091466ba55-1).
I also did compile xen in qemu for armhf one time with the current unstable
version and one time with the change below to test the time_t transition.
The resulting binaries were the same (thanks xen is buildable reproducibly).
So maybe the transition is not needed for xen, but unfortunately my knowledge
is not that much that I can say this for sure.
--- a/debian/rules
+++ b/debian/rules
@@ -12,6 +12,10 @@ export DEB_VERSION
# DEB_MAINTAINER is used by our delta queue
export DEB_MAINTAINER := $(shell sed -ne 's/^Maintainer: \(.*\)$$/\1/p' debian/control)
+export DEB_BUILD_OPTIONS=abi=+lfs
+export _FILE_OFFSET_BITS=64
+export _TIME_BITS=64
+
# This influences dpkg-buildflags to specify better linker
# options. See https://wiki.debian.org/Hardening
# Apparently some of these might incur silent breakage
@@ -26,7 +30,7 @@ export DEB_MAINTAINER := $(shell sed -ne 's/^Maintainer: \(.*\)$$/\1/p' debian/c
# Inexplicably, if you tell make `export V=value' and `$(shell ...)'
# it does not pass V to the shell. WTF. So we set a variable
# dbmo which we include in the relevant $(shell ...) invocations.
-dbmo= DEB_BUILD_MAINT_OPTIONS="hardening=+all"
+dbmo= DEB_BUILD_MAINT_OPTIONS="hardening=+all abi=+lfs" _FILE_OFFSET_BITS=64 _TIME_BITS=64
# Architecture handling.
#
0 new messages