Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#993515: catch: FTBFS with glibc 2.34
4 views
Skip to first unread message
Graham Inggs
Sep 2, 2021, 9:10:05 AM9/2/21
to
Source: catch
Version: 1.12.1-1.1
Severity: important
Hi Maintainer
Catch will FTBFS once glibc is upgraded to 2.34 due to MINSIGSTKSZ and
SIGSTKSZ no longer being defined.
This was fixed Catch2's upstream [1]. I'm not sure if this can be
adapted for Catch(1).
Another approach is to simply replace SIGSTKSZ with a constant, as
done in Fedora [2].
Regards
Graham
[1] https://github.com/catchorg/Catch2/issues/2178
[2] https://src.fedoraproject.org/rpms/catch1/c/059104ba87494c0b5ebe16844ec190f253e51cac
Version: 1.12.1-1.1
Severity: important
Hi Maintainer
Catch will FTBFS once glibc is upgraded to 2.34 due to MINSIGSTKSZ and
SIGSTKSZ no longer being defined.
This was fixed Catch2's upstream [1]. I'm not sure if this can be
adapted for Catch(1).
Another approach is to simply replace SIGSTKSZ with a constant, as
done in Fedora [2].
Regards
Graham
[1] https://github.com/catchorg/Catch2/issues/2178
[2] https://src.fedoraproject.org/rpms/catch1/c/059104ba87494c0b5ebe16844ec190f253e51cac
Aurelien Jarno
Jan 6, 2022, 6:00:04 PM1/6/22
to
On 2021-09-02 14:37, Graham Inggs wrote:
> Source: catch
> Version: 1.12.1-1.1
> Severity: important
>
> Hi Maintainer
>
> Catch will FTBFS once glibc is upgraded to 2.34 due to MINSIGSTKSZ and
> SIGSTKSZ no longer being defined.
>
> This was fixed Catch2's upstream [1]. I'm not sure if this can be
> adapted for Catch(1).
> Another approach is to simply replace SIGSTKSZ with a constant, as
> done in Fedora [2].
Please note that glibc 2.34 is available in experimental for a few
> Source: catch
> Version: 1.12.1-1.1
> Severity: important
>
> Hi Maintainer
>
> Catch will FTBFS once glibc is upgraded to 2.34 due to MINSIGSTKSZ and
> SIGSTKSZ no longer being defined.
>
> This was fixed Catch2's upstream [1]. I'm not sure if this can be
> adapted for Catch(1).
> Another approach is to simply replace SIGSTKSZ with a constant, as
> done in Fedora [2].
weeks. It should ease testing the fix.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aure...@aurel32.net http://www.aurel32.net
Drew Parsons
Feb 4, 2022, 11:10:05 AM2/4/22
to
Source: catch
Version: 1.12.1-1.1
Followup-For: Bug #993515
Control: tags -1 patch
Upstream prepared a patch for catch2, PR#2317
https://github.com/catchorg/Catch2/pull/2317
dolfin uses a vendored copy of the merged catch.hpp. I prepared a
patch for it (attached), which could be adapted for the catch package.
Version: 1.12.1-1.1
Followup-For: Bug #993515
Control: tags -1 patch
Upstream prepared a patch for catch2, PR#2317
https://github.com/catchorg/Catch2/pull/2317
dolfin uses a vendored copy of the merged catch.hpp. I prepared a
patch for it (attached), which could be adapted for the catch package.
Drew Parsons
Feb 5, 2022, 3:00:04 PM2/5/22
to
forwarded 993515 https://github.com/catchorg/Catch2/issues/2178
thanks
Discussion of the upstream bug fixed by commit c0d0a50bd (not PR#2317)
was in issue #2178
thanks
Discussion of the upstream bug fixed by commit c0d0a50bd (not PR#2317)
was in issue #2178
Drew Parsons
Feb 5, 2022, 3:30:04 PM2/5/22
to
Source: catch
Followup-For: Bug #993515
Actually upsteam catch (catch2) had some criticisms of the PR#2317
patch that I referenced.
Among other things it should still use SIGSTKSZ not MINSIGSTKSZ.
The actual patch to catch2 was commit c0d0a50bd
https://github.com/catchorg/Catch2/commit/c0d0a50bdb2ae2f749443c0386c2b25379bdbf76
I adapted my dolfin patch to align with commit c0d0a50bd to use SIGSTKSZ
not MINSIGSTKSZ (and use 32 * 1024 as the backup default value).
I'm attaching the updated dolfin patch here for reference.
Followup-For: Bug #993515
Actually upsteam catch (catch2) had some criticisms of the PR#2317
patch that I referenced.
Among other things it should still use SIGSTKSZ not MINSIGSTKSZ.
The actual patch to catch2 was commit c0d0a50bd
https://github.com/catchorg/Catch2/commit/c0d0a50bdb2ae2f749443c0386c2b25379bdbf76
I adapted my dolfin patch to align with commit c0d0a50bd to use SIGSTKSZ
not MINSIGSTKSZ (and use 32 * 1024 as the backup default value).
I'm attaching the updated dolfin patch here for reference.
0 new messages